wapmorgan / Morphos

src/English/NounPluralization.php

<?php
namespace morphos\English;

use morphos\S;

class NounPluralization extends \morphos\NounPluralization
{
    private static $exceptions = [
        'chief' => 'chiefs',
        'basis' => 'bases',
        'crisis' => 'crises',
        'radius' => 'radii',
        'nucleus' => 'nuclei',
        'curriculum' => 'curricula',
        'man' => 'men',
        'woman' => 'women',
        'child' => 'children',
        'foot' => 'feet',
        'tooth' => 'teeth',
        'ox' => 'oxen',
        'goose' => 'geese',
        'mouse' => 'mice'
    ];

    private static $without_paired_form = [
        'knowledge',
        'progress',
        'advise',
        'ink',
        'money',
        'scissors',
        'spectacles',
        'trousers',
    ];

    public static $consonants = ['b', 'c', 'd', 'f', 'g', 'h', 'j', 'k', 'l', 'm', 'n', 'p', 'q', 'r', 's', 't', 'v', 'x', 'z', 'w'];

    /**
     * @param $word
     * @param int $count
     * @return string
     */
    public static function pluralize($word, $count = 2)
    {
        if ($count == 1) {
            return $word;
        }

        $word = S::lower($word);

The expression \morphos\S::lower($word); of type boolean|string adds the type boolean to the return on line 51 which is incompatible with the return type documented by morphos\English\NounPluralization::pluralize of type string.

        if (in_array($word, self::$without_paired_form)) {
            return $word;
        } elseif (isset(self::$exceptions[$word])) {
            return self::$exceptions[$word];
        }

        if (in_array(S::slice($word, -1), ['s', 'x']) || in_array(S::slice($word, -2), array('sh', 'ch'))) {

It seems like $word defined by \morphos\S::lower($word) on line 49 can also be of type boolean; however, morphos\S::slice() does only seem to accept string, maybe add an additional type check?

            return $word.'es';
        } elseif (S::slice($word, -1) == 'o') {

It seems like $word defined by \morphos\S::lower($word) on line 49 can also be of type boolean; however, morphos\S::slice() does only seem to accept string, maybe add an additional type check?

            return $word.'es';
        } elseif (S::slice($word, -1) == 'y' && in_array(S::slice($word, -2, -1), self::$consonants)) {

It seems like $word defined by \morphos\S::lower($word) on line 49 can also be of type boolean; however, morphos\S::slice() does only seem to accept string, maybe add an additional type check?

            return S::slice($word, 0, -1).'ies';

It seems like $word defined by \morphos\S::lower($word) on line 49 can also be of type boolean; however, morphos\S::slice() does only seem to accept string, maybe add an additional type check?

        } elseif (S::slice($word, -2) == 'fe' || S::slice($word, -1) == 'f') {

It seems like $word defined by \morphos\S::lower($word) on line 49 can also be of type boolean; however, morphos\S::slice() does only seem to accept string, maybe add an additional type check?

            if (S::slice($word, -1) == 'f') {

It seems like $word defined by \morphos\S::lower($word) on line 49 can also be of type boolean; however, morphos\S::slice() does only seem to accept string, maybe add an additional type check?

                return S::slice($word, 0, -1).'ves';

It seems like $word defined by \morphos\S::lower($word) on line 49 can also be of type boolean; however, morphos\S::slice() does only seem to accept string, maybe add an additional type check?

            } else {
                return S::slice($word, 0, -2).'ves';

It seems like $word defined by \morphos\S::lower($word) on line 49 can also be of type boolean; however, morphos\S::slice() does only seem to accept string, maybe add an additional type check?

            }
        } else {
            return $word.'s';
        }
    }
}