Issues in LastNamesInflection.php - All Issues - Inspection of "Add run-away vowels list of Geographical names and..." - wapmorgan/Morphos - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 622740...e78b73 )

by f

created 2018-09-07 19:57 UTC

src/Russian/LastNamesInflection.php (36 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace morphos\Russian;

use morphos\S;

/**
 * Rules are from http://gramma.ru/SPR/?id=2.8
 */
class LastNamesInflection extends \morphos\NamesInflection implements Cases
{
    use RussianLanguage, CasesHelper;

    protected static $menPostfixes = ['ов', 'ев' ,'ин' ,'ын', 'ой', 'ий'];
    protected static $womenPostfixes = ['ва', 'на', 'ая', 'яя'];

    /**
     * @param $name
     * @param null $gender
     * @return bool
     */
    public static function isMutable($name, $gender = null)
    {
        $name = S::lower($name);
        if ($gender === null) {
            $gender = self::detectGender($name);
        }
        // составная фамилия - разбить на части и проверить по отдельности
        if (strpos($name, '-') !== false) {
            foreach (explode('-', $name) as $part) {
                if (static::isMutable($part, $gender))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    return true;
            }
            return false;
        }

        if (in_array(S::slice($name, -1), ['а', 'я'], true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return true;
        }

        if ($gender == self::MALE) {
            // Несклоняемые фамилии (Фоминых, Седых / Стецко, Писаренко)
            if (in_array(S::slice($name, -2), ['ых', 'ко'], true))
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                return false;

            // Несклоняемые, образованные из родительного падежа личного или прозвищного имени главы семьи
            // суффиксы: ово, аго
            if (in_array(S::slice($name, -3), ['ово', 'аго'], true))
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                return false;

            // Типичные суффикс мужских фамилий
            if (in_array(S::slice($name, -2), ['ов', 'ев', 'ин', 'ын', 'ий', 'ой'], true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                return true;
            }

            // Согласная на конце
            if (self::isConsonant(S::slice($name, -1))) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                return true;
            }

            // Мягкий знак на конце
            if (S::slice($name, -1) == 'ь') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                return true;
            }

        } else {

            // Типичные суффиксы женских фамилий
            if (in_array(S::slice($name, -2), ['ва', 'на', 'ая'], true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                return true;
            }
        }

        return false;
    }

    /**
     * @param $name
     * @return null|string
     */
    public static function detectGender($name)
    {
        $name = S::lower($name);
        if (in_array(S::slice($name, -2), self::$menPostfixes, true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return self::MALE;
        }
        if (in_array(S::slice($name, -2), self::$womenPostfixes, true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            return self::FEMALE;
        }

        return null;
    }

    /**
     * @param $name
     * @param null|string $gender
     * @return array
     */
    public static function getCases($name, $gender = null)
    {
        $name = S::lower($name);
        if ($gender === null) {
            $gender = self::detectGender($name);
        }

        // составная фамилия - разбить на части и склонять по отдельности
        if (strpos($name, '-') !== false) {
            $parts = explode('-', $name);
            $cases = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            foreach ($parts as $i => $part) {
                $parts[$i] = static::getCases($part, $gender);
            }

            return self::composeCasesFromWords($parts, '-');
        }

        if (static::isMutable($name, $gender)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            if ($gender == self::MALE) {
                if (in_array(S::slice($name, -2), ['ов', 'ев', 'ин', 'ын'], true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    $prefix = S::name($name);
                    return [
                        self::IMENIT => $prefix,
                        self::RODIT => $prefix.'а',
                        self::DAT => $prefix.'у',
                        self::VINIT => $prefix.'а',
                        self::TVORIT => $prefix.'ым',
                        self::PREDLOJ => $prefix.'е'
                    ];
                } elseif (in_array(S::slice($name, -4), ['ский', 'ской', 'цкий', 'цкой'], true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    $prefix = S::name(S::slice($name, 0, -2));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => S::name($name),
                        self::RODIT => $prefix.'ого',
                        self::DAT => $prefix.'ому',
                        self::VINIT => $prefix.'ого',
                        self::TVORIT => $prefix.'им',
                        self::PREDLOJ => $prefix.'ом'
                    ];
                // Верхний / Убогий / Толстой
                // Верхнего / Убогого / Толстого
                // Верхнему / Убогому / Толстому
                // Верхним / Убогим / Толстым
                // О Верхнем / Об Убогом / О Толстом
                } else if (in_array(S::slice($name, -2), ['ой', 'ый', 'ий'], true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    $prefix = S::name(S::slice($name, 0, -2));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => S::name($name),
                        self::RODIT => $prefix.'ого',
                        self::DAT => $prefix.'ому',
                        self::VINIT => $prefix.'ого',
                        self::TVORIT => $prefix.'ым',
                        self::PREDLOJ => $prefix.'ом'
                    ];
                }

            } else {
                if (in_array(S::slice($name, -3), ['ова', 'ева', 'ина', 'ына'], true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => S::name($name),
                        self::RODIT => $prefix.'ой',
                        self::DAT => $prefix.'ой',
                        self::VINIT => $prefix.'у',
                        self::TVORIT => $prefix.'ой',
                        self::PREDLOJ => $prefix.'ой'
                    ];
                }

                if (in_array(S::slice($name, -2), ['ая'], true)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    $prefix = S::name(S::slice($name, 0, -2));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    return [
                        self::IMENIT => S::name($name),
                        self::RODIT => $prefix.'ой',
                        self::DAT => $prefix.'ой',
                        self::VINIT => $prefix.'ую',
                        self::TVORIT => $prefix.'ой',
                        self::PREDLOJ => $prefix.'ой'
                    ];
                }
            }

            if (S::slice($name, -1) == 'я') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                return [
                    self::IMENIT => S::name($name),
                    self::RODIT => $prefix.'и',
                    self::DAT => $prefix.'е',
                    self::VINIT => $prefix.'ю',
                    self::TVORIT => $prefix.'ей',
                    self::PREDLOJ => $prefix.'е'
                ];
            } elseif (S::slice($name, -1) == 'а') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                return [
                    self::IMENIT => S::name($name),
                    self::RODIT => $prefix.(self::isDeafConsonant(S::slice($name, -2, -1)) ? 'и' : 'ы'),
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                    self::DAT => $prefix.'е',
                    self::VINIT => $prefix.'у',
                    self::TVORIT => $prefix.'ой',
                    self::PREDLOJ => $prefix.'е'
                ];
            } elseif (self::isConsonant(S::slice($name, -1)) && S::slice($name, -2) != 'ых') {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                $prefix = S::name($name);
                return [
                    self::IMENIT => S::name($name),
                    self::RODIT => $prefix.'а',
                    self::DAT => $prefix.'у',
                    self::VINIT => $prefix.'а',
                    self::TVORIT => $prefix.'ом',
                    self::PREDLOJ => $prefix.'е'
                ];
            } elseif (S::slice($name, -1) == 'ь' && $gender == self::MALE) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                $prefix = S::name(S::slice($name, 0, -1));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                return [
                    self::IMENIT => S::name($name),
                    self::RODIT => $prefix.'я',
                    self::DAT => $prefix.'ю',
                    self::VINIT => $prefix.'я',
                    self::TVORIT => $prefix.'ем',
                    self::PREDLOJ => $prefix.'е'
                ];
            }
        }

        $name = S::name($name);
        return array_fill_keys([self::IMENIT, self::RODIT, self::DAT, self::VINIT, self::TVORIT, self::PREDLOJ], $name);
    }

    /**
     * @param $name
     * @param $case
     * @param null $gender
     * @return string
     * @throws \Exception
     */
    public static function getCase($name, $case, $gender = null)
    {
        if (!static::isMutable($name, $gender)) {
            return $name;
        } else {
            $case = self::canonizeCase($case);
            $forms = self::getCases($name, $gender);
            return $forms[$case];
        }
    }
}


1			<?php
2			namespace morphos\Russian;
3
4			use morphos\S;
5
6			/**
7			* Rules are from http://gramma.ru/SPR/?id=2.8
8			*/
9			class LastNamesInflection extends \morphos\NamesInflection implements Cases
10			{
11			use RussianLanguage, CasesHelper;
12
13			protected static $menPostfixes = ['ов', 'ев' ,'ин' ,'ын', 'ой', 'ий'];
14			protected static $womenPostfixes = ['ва', 'на', 'ая', 'яя'];
15
16			/**
17			* @param $name
18			* @param null $gender
19			* @return bool
20			*/
21	60		public static function isMutable($name, $gender = null)
22			{
23	60		$name = S::lower($name);
24	60		if ($gender === null) {
25			$gender = self::detectGender($name);
26			}
27			// составная фамилия - разбить на части и проверить по отдельности
28	60		if (strpos($name, '-') !== false) {
29	3		foreach (explode('-', $name) as $part) {
30	3		if (static::isMutable($part, $gender))
			0 ignored issues – show Bug introduced 2018-05-16 20:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$gender` defined by `self::detectGender($name)` on line `25` can also be of type `string`; however, `morphos\Russian\LastNamesInflection::isMutable()` does only seem to accept `null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
31	3		return true;
32			}
33			return false;
34			}
35
36	60	View Code Duplication	if (in_array(S::slice($name, -1), ['а', 'я'], true)) {
			0 ignored issues – show Security Bug introduced 2018-05-16 20:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$name` defined by `\morphos\S::lower($name)` on line `23` can also be of type `false`; however, `morphos\S::slice()` does only seem to accept `string`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history... Duplication introduced 2018-06-20 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37	22		return true;
38			}

wapmorgan / Morphos

Push — master ( 622740...e78b73 )

src/Russian/LastNamesInflection.php (36 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like