wapmorgan /
Morphos
| Conditions | 22 |
| Paths | 26 |
| Total Lines | 107 |
| Code Lines | 77 |
| Lines | 23 |
| Ratio | 21.5 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 32 | static public function getCases($name) { |
||
| 33 | $name = S::lower($name); |
||
| 34 | |||
| 35 | // check for name of two words |
||
| 36 | if (strpos($name, ' ') !== false) { |
||
| 37 | $parts = explode(' ', $name); |
||
| 38 | $cases = array(); |
||
|
|
|||
| 39 | $result = array(); |
||
| 40 | foreach ($parts as $i => $part) { |
||
| 41 | $result[$i] = static::getCases($part); |
||
| 42 | if ($i > 0) |
||
| 43 | $result[$i][self::PREDLOJ] = substr(strstr($result[$i][self::PREDLOJ], ' '), 1); |
||
| 44 | } |
||
| 45 | |||
| 46 | $cases = array(); |
||
| 47 | foreach (array(self::IMENIT, self::RODIT, self::DAT, self::VINIT, self::TVORIT, self::PREDLOJ) as $case) { |
||
| 48 | foreach ($parts as $i => $part) { |
||
| 49 | $cases[$case][] = $result[$i][$case]; |
||
| 50 | } |
||
| 51 | $cases[$case] = implode(' ', $cases[$case]); |
||
| 52 | } |
||
| 53 | return $cases; |
||
| 54 | } |
||
| 55 | |||
| 56 | if (!in_array($name, self::$abbreviations)) { |
||
| 57 | if (S::slice($name, -2) == 'ий') { |
||
| 58 | // Нижний, Русский |
||
| 59 | $prefix = S::name(S::slice($name, 0, -2)); |
||
| 60 | return array( |
||
| 61 | self::IMENIT => $prefix.'ий', |
||
| 62 | self::RODIT => $prefix.(self::isVelarConsonant(S::slice($name, -3, -2)) ? 'ого' : 'его'), |
||
| 63 | self::DAT => $prefix.(self::isVelarConsonant(S::slice($name, -3, -2)) ? 'ому' : 'ему'), |
||
| 64 | self::VINIT => $prefix.'ий', |
||
| 65 | self::TVORIT => $prefix.'им', |
||
| 66 | self::PREDLOJ => self::choosePrepositionByFirstLetter($prefix, 'об', 'о').' '.$prefix.'ем', |
||
| 67 | ); |
||
| 68 | } else if (S::slice($name, -1) == 'а') { |
||
| 69 | // Москва, Рига |
||
| 70 | $prefix = S::name(S::slice($name, 0, -1)); |
||
| 71 | return array( |
||
| 72 | self::IMENIT => $prefix.'а', |
||
| 73 | self::RODIT => $prefix.(self::isVelarConsonant(S::slice($name, -2, -1)) ? 'и' : 'ы'), |
||
| 74 | self::DAT => $prefix.'е', |
||
| 75 | self::VINIT => $prefix.'у', |
||
| 76 | self::TVORIT => $prefix.'ой', |
||
| 77 | self::PREDLOJ => self::choosePrepositionByFirstLetter($prefix, 'об', 'о').' '.$prefix.'е', |
||
| 78 | ); |
||
| 79 | } else if (S::slice($name, -1) == 'я') { |
||
| 80 | // Азия |
||
| 81 | $prefix = S::name(S::slice($name, 0, -1)); |
||
| 82 | return array( |
||
| 83 | self::IMENIT => S::name($name), |
||
| 84 | self::RODIT => $prefix.'и', |
||
| 85 | self::DAT => $prefix.'и', |
||
| 86 | self::VINIT => $prefix.'ю', |
||
| 87 | self::TVORIT => $prefix.'ей', |
||
| 88 | self::PREDLOJ => self::choosePrepositionByFirstLetter($prefix, 'об', 'о').' '.$prefix.'и', |
||
| 89 | ); |
||
| 90 | View Code Duplication | } else if (S::slice($name, -1) == 'й') { |
|
| 91 | // Ишимбай |
||
| 92 | $prefix = S::name(S::slice($name, 0, -1)); |
||
| 93 | return array( |
||
| 94 | self::IMENIT => $prefix.'й', |
||
| 95 | self::RODIT => $prefix.'я', |
||
| 96 | self::DAT => $prefix.'ю', |
||
| 97 | self::VINIT => $prefix.'й', |
||
| 98 | self::TVORIT => $prefix.'ем', |
||
| 99 | self::PREDLOJ => self::choosePrepositionByFirstLetter($prefix, 'об', 'о').' '.$prefix.'е', |
||
| 100 | ); |
||
| 101 | } else if (self::isConsonant(S::slice($name, -1))) { |
||
| 102 | $prefix = S::name($name); |
||
| 103 | // Париж, Валаам, Киев |
||
| 104 | return array( |
||
| 105 | self::IMENIT => $prefix, |
||
| 106 | self::RODIT => $prefix.'а', |
||
| 107 | self::DAT => $prefix.'у', |
||
| 108 | self::VINIT => $prefix, |
||
| 109 | self::TVORIT => $prefix.(self::isVelarConsonant(S::slice($name, -2, -1)) ? 'ем' : 'ом'), |
||
| 110 | self::PREDLOJ => self::choosePrepositionByFirstLetter($prefix, 'об', 'о').' '.$prefix.'е', |
||
| 111 | ); |
||
| 112 | } |
||
| 113 | |||
| 114 | $suffixes = array('ов', 'ёв', 'ев', 'ин', 'ын'); |
||
| 115 | if ((in_array(S::slice($name, -1), array('е', 'о')) && in_array(S::slice($name, -3, -1), $suffixes)) || in_array(S::slice($name, -2), $suffixes)) { |
||
| 116 | // ово, ёво, ... |
||
| 117 | if (in_array(S::slice($name, -3, -1), $suffixes)) { |
||
| 118 | $prefix = S::name(S::slice($name, 0, -1)); |
||
| 119 | } |
||
| 120 | // ов, её, ... |
||
| 121 | else if (in_array(S::slice($name, -2), $suffixes)) { |
||
| 122 | $prefix = S::name($name); |
||
| 123 | } |
||
| 124 | return array( |
||
| 125 | self::IMENIT => S::name($name), |
||
| 126 | self::RODIT => $prefix.'а', |
||
| 127 | self::DAT => $prefix.'у', |
||
| 128 | self::VINIT => S::name($name), |
||
| 129 | self::TVORIT => $prefix.'ем', |
||
| 130 | self::PREDLOJ => self::choosePrepositionByFirstLetter($prefix, 'об', 'о').' '.$prefix.'е', |
||
| 131 | ); |
||
| 132 | } |
||
| 133 | } |
||
| 134 | |||
| 135 | // if no rules matches or name is immutable |
||
| 136 | $name = in_array($name, self::$abbreviations) ? S::upper($name) : S::name($name); |
||
| 137 | return array_fill_keys(array(self::IMENIT, self::RODIT, self::DAT, self::VINIT, self::TVORIT), $name) + array(self::PREDLOJ => self::choosePrepositionByFirstLetter($name, 'об', 'о').' '.$name); |
||
| 138 | } |
||
| 139 | |||
| 145 | } |
Loading history...
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.