CatalogFactory::__construct() - Code Metrics - Inspection of "Use the JSONDecoder from wambo core" - wambo-co/module-catalog - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( b02061...820347 )

by Andreas

created 2016-08-02 18:13 UTC

CatalogFactory::__construct() A

↳ Parent: CatalogFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	0
cts	6
cp	0
rs	9.4285
cc	1
eloc	5
nc	1
nop	2
crap	2

<?php

namespace Wambo\Catalog;

use League\Flysystem\FilesystemInterface;
use Wambo\Catalog\Exception\CatalogException;
use Wambo\Catalog\Mapper\CatalogMapper;
use Wambo\Catalog\Mapper\ContentMapper;
use Wambo\Catalog\Mapper\ProductMapper;
use Wambo\Catalog\Model\Catalog;

/**
 * Class CatalogFactory creates Catalog models
 *
 * @package Wambo\Catalog
 */
class CatalogFactory
{
    /** @var CatalogProviderInterface $catalogProvider */
    private $catalogProvider;

    /**
     * CatalogFactory constructor.
     *
     * @param FilesystemInterface $filesystem
     * @param string              $jsonCatalogFilePath The path to the JSON catalog
     */
    public function __construct(FilesystemInterface $filesystem, string $jsonCatalogFilePath)
    {
        $contentMapper = new ContentMapper();
        $productMapper = new ProductMapper($contentMapper);
        $catalogMapper = new CatalogMapper($productMapper);

        $this->catalogProvider = new JSONCatalogProvider($filesystem, $jsonCatalogFilePath, $catalogMapper);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Get the product catalog
     *
     * @return Catalog
     *
     * @throws CatalogException
     */
    public function getCatalog()
    {
        return $this->catalogProvider->getCatalog();
    }
}

1			<?php
2
3			namespace Wambo\Catalog;
4
5			use League\Flysystem\FilesystemInterface;
6			use Wambo\Catalog\Exception\CatalogException;
7			use Wambo\Catalog\Mapper\CatalogMapper;
8			use Wambo\Catalog\Mapper\ContentMapper;
9			use Wambo\Catalog\Mapper\ProductMapper;
10			use Wambo\Catalog\Model\Catalog;
11
12			/**
13			* Class CatalogFactory creates Catalog models
14			*
15			* @package Wambo\Catalog
16			*/
17			class CatalogFactory
18			{
19			/** @var CatalogProviderInterface $catalogProvider */
20			private $catalogProvider;
21
22			/**
23			* CatalogFactory constructor.
24			*
25			* @param FilesystemInterface $filesystem
26			* @param string $jsonCatalogFilePath The path to the JSON catalog
27			*/
28			public function __construct(FilesystemInterface $filesystem, string $jsonCatalogFilePath)
29			{
30			$contentMapper = new ContentMapper();
31			$productMapper = new ProductMapper($contentMapper);
32			$catalogMapper = new CatalogMapper($productMapper);
33
34			$this->catalogProvider = new JSONCatalogProvider($filesystem, $jsonCatalogFilePath, $catalogMapper);
			0 ignored issues – show Bug introduced 2016-08-02 18:16 UTC by Report Bug Copy Issue Report The call to `JSONCatalogProvider::__construct()` misses a required argument `$catalogMapper`. This check looks for function calls that miss required arguments. Loading history... Documentation introduced 2016-08-02 18:16 UTC by Report Bug Copy Issue Report `$catalogMapper` is of type `object<Wambo\Catalog\Mapper\CatalogMapper>`, but the function expects a `object<Wambo\Core\Storage\JSONDecoder>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35			}
36
37			/**
38			* Get the product catalog
39			*
40			* @return Catalog
41			*
42			* @throws CatalogException
43			*/
44			public function getCatalog()
45			{
46			return $this->catalogProvider->getCatalog();
47			}
48			}

wambo-co / module-catalog

Push — develop ( b02061...820347 )

CatalogFactory::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like