Wambo\Catalog\JSONCatalogProvider

Complexity

Total Complexity

4

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	getCatalog()	0	22	3

<?php

namespace Wambo\Catalog;

use League\Flysystem\FilesystemInterface;
use Wambo\Catalog\Exception\CatalogException;
use Wambo\Catalog\Exception\JSONException;
use Wambo\Catalog\Mapper\CatalogMapper;
use Wambo\Catalog\Model\Catalog;
use Wambo\Core\Storage\JSONDecoder;

/**
 * Class JSONCatalogProvider reads product and catalog data from an JSON file.
 */
class JSONCatalogProvider implements CatalogProviderInterface
{
    /**
     * @var FilesystemInterface $filesystem The filesystem this Catalog instance works on
     */
    private $filesystem;

    /**
     * @var string $catalogFilePath The path to the JSON file containing the catalog in the given $filesystem
     */
    private $catalogFilePath;

    /**
     * @var CatalogMapper A catalog mapper for converting unstructured catalog data into Catalog models
     */
    private $catalogMapper;
    /**
     * @var JSONDecoder
     */
    private $jsonDecoder;

    /**
     * Creates a new instance of the JSONCatalogProvider class.
     *
     * @param FilesystemInterface $filesystem      The filesystem this Catalog instance works on
     * @param string              $catalogFilePath The path to the JSON file containing the catalog in the given
     *                                             $filesystem
     *
     * @param JSONDecoder         $jsonDecoder     A JSON decoder
     * @param CatalogMapper       $catalogMapper   A catalog mapper for converting unstructured catalog data into
     *                                             Catalog models
     */
    public function __construct(
        FilesystemInterface $filesystem,
        string $catalogFilePath,
        JSONDecoder $jsonDecoder,
        CatalogMapper $catalogMapper
    ) {
        $this->filesystem = $filesystem;
        $this->catalogFilePath = $catalogFilePath;
        $this->jsonDecoder = $jsonDecoder;
        $this->catalogMapper = $catalogMapper;
    }

    /**
     * Get the product catalog.
     *
     * @return Catalog
     *
     * @throws CatalogException If the catalog could not be created.
     */
    public function getCatalog()
    {
        if ($this->filesystem->has($this->catalogFilePath) == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            throw new CatalogException(sprintf("The given catalog file path \"%s\" does not exist.",
                $this->catalogFilePath));
        }

        try {

            $json = $this->filesystem->read($this->catalogFilePath);
            $catalogData = $this->jsonDecoder->getData($json);

It seems like $json defined by $this->filesystem->read($this->catalogFilePath) on line 75 can also be of type false; however, Wambo\Core\Storage\JSONDecoder::getData() does only seem to accept string, did you maybe forget to handle an error condition?

            // convert the catalog data into a Catalog model
            $catalog = $this->catalogMapper->getCatalog($catalogData);

            return $catalog;

        } catch (\Exception $catalogException) {
            throw new CatalogException(sprintf("Unable to read catalog from %s: ", $this->catalogFilePath,
                $catalogException->getMessage()), $catalogException);
        }
    }
}