CatalogFactoryTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	48
Duplicated Lines	77.08 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCatalog_IntegrationTest_CatalogJSONIsValid_CatalogIsReturned()	18	18	1
A	getCatalog_IntegrationTest_CatalogJSONIsInvalid_CatalogExceptionIsThrown()	19	19	1

<?php
use League\Flysystem\Filesystem;
use League\Flysystem\Memory\MemoryAdapter;
use Wambo\Catalog\CatalogFactory;
use Wambo\Catalog\Error\CatalogException;

/**
 * Class CatalogFactoryTest tests the Wambo\Catalog\CatalogFactory class.
 */
class CatalogFactoryTest extends PHPUnit_Framework_TestCase

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @test
     */
    public function getCatalog_IntegrationTest_CatalogJSONIsValid_CatalogIsReturned()

This method seems to be duplicated in your project.

    {
        // arrange
        $catalogFilePath = "catalog.json";
        $filesystem = new Filesystem(new MemoryAdapter());
        $catalogJSON = <<<JSON
[]
JSON;
        $filesystem->write($catalogFilePath, $catalogJSON);

        $catalogFactory = new CatalogFactory($filesystem, $catalogFilePath);

        // act
        $catalog = $catalogFactory->getCatalog();

        // assert
        $this->assertNotNull($catalog, "The catalog should not be null");
    }

    /**
     * @test
     * @expectedException Wambo\Catalog\Error\CatalogException
     */
    public function getCatalog_IntegrationTest_CatalogJSONIsInvalid_CatalogExceptionIsThrown()

This method seems to be duplicated in your project.

    {
        // arrange
        $catalogFilePath = "catalog.json";
        $filesystem = new Filesystem(new MemoryAdapter());
        $catalogJSON = <<<JSON
[
    {
        "sku": ""
    }
]
JSON;
        $filesystem->write($catalogFilePath, $catalogJSON);

        $catalogFactory = new CatalogFactory($filesystem, $catalogFilePath);

        // act
        $catalogFactory->getCatalog();
    }
}