ZendMail::send() - Code Metrics - Inspection of "Added support for PHPMailer" - waltertamboer/communicator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 83526e...bd9b49 )

by Walter

created 2017-06-08 14:09 UTC

ZendMail::send() A

↳ Parent: ZendMail::sendToRecipient()

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	3
nc	2
nop	5

<?php
/**
 * Communicator (https://github.com/waltertamboer/communicator)
 *
 * @link https://github.com/waltertamboer/communicator for the canonical source repository
 * @copyright Copyright (c) 2017 Communicator (https://github.com/waltertamboer/communicator)
 * @license https://github.com/waltertamboer/communicator/blob/master/LICENSE.md MIT
 */

namespace Communicator\Transport\Email\Transport;

use Communicator\Message;
use Communicator\Recipient\RecipientInterface;
use Zend\Mail\Message as ZendMessage;
use Zend\Mail\Transport\TransportInterface;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Zend\Mime\Message as MimeMessage;
use Zend\Mime\Part;

/**
 * An e-mail transport that makes use of Zend\Mail.
 */
final class ZendMail extends AbstractTransport
{
    /**
     * The mailer used to send messages.
     *
     * @var TransportInterface
     */
    private $transport;

    /**
     * Initializes a new instance of this class.
     *
     * @param TransportInterface $transport
     */
    public function __construct(TransportInterface $transport)
    {
        $this->transport = $transport;
    }

    /**
     * Sends a message to the given recipient.
     *
     * @param RecipientInterface $recipient The recipient that should receive the message.
     * @param Message $message The message that should be sent.
     * @param string $subject The subject of the message.
     * @param string $text The plain text message.
     * @param null|string $html An optional HTML version of the message.
     */
    protected function sendToRecipient(
        RecipientInterface $recipient,
        Message $message,
        string $subject,
        string $text,
        ?string $html
    ): void {
        $addresses = $this->getAddresses($recipient, $message);

        foreach ($addresses as $address) {
            /** @var ZendMessage $emailMessage */
            $emailMessage = new ZendMessage();
            $emailMessage->setSubject($subject);
            $emailMessage->setTo($address);
            $emailMessage->setBody($text);
            $emailMessage->setEncoding('UTF-8');

            if ($this->getFromAddress() !== null) {
                $emailMessage->setFrom($this->getFromAddress(), $this->getFromName());
            }

            $textPart = new Part($text);
            $textPart->type = 'text/plain';

            $bodyPart = new MimeMessage();
            $bodyPart->addPart($textPart);

            if ($html) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $htmlPart = new Part($html);
                $htmlPart->type = 'text/html';

                $bodyPart->addPart($htmlPart);
            }

            $this->transport->send($emailMessage);
        }
    }
}


1			<?php
2			/**
3			* Communicator (https://github.com/waltertamboer/communicator)
4			*
5			* @link https://github.com/waltertamboer/communicator for the canonical source repository
6			* @copyright Copyright (c) 2017 Communicator (https://github.com/waltertamboer/communicator)
7			* @license https://github.com/waltertamboer/communicator/blob/master/LICENSE.md MIT
8			*/
9
10			namespace Communicator\Transport\Email\Transport;
11
12			use Communicator\Message;
13			use Communicator\Recipient\RecipientInterface;
14			use Zend\Mail\Message as ZendMessage;
15			use Zend\Mail\Transport\TransportInterface;
			0 ignored issues – show Bug introduced 2017-06-07 20:42 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Communicator\Transport\E...port\TransportInterface`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
16			use Zend\Mime\Message as MimeMessage;
17			use Zend\Mime\Part;
18
19			/**
20			* An e-mail transport that makes use of Zend\Mail.
21			*/
22			final class ZendMail extends AbstractTransport
23			{
24			/**
25			* The mailer used to send messages.
26			*
27			* @var TransportInterface
28			*/
29			private $transport;
30
31			/**
32			* Initializes a new instance of this class.
33			*
34			* @param TransportInterface $transport
35			*/
36			public function __construct(TransportInterface $transport)
37			{
38			$this->transport = $transport;
39			}
40
41			/**
42			* Sends a message to the given recipient.
43			*
44			* @param RecipientInterface $recipient The recipient that should receive the message.
45			* @param Message $message The message that should be sent.
46			* @param string $subject The subject of the message.
47			* @param string $text The plain text message.
48			* @param null\|string $html An optional HTML version of the message.
49			*/
50			protected function sendToRecipient(
51			RecipientInterface $recipient,
52			Message $message,
53			string $subject,
54			string $text,
55			?string $html
56			): void {
57			$addresses = $this->getAddresses($recipient, $message);
58
59			foreach ($addresses as $address) {
60			/** @var ZendMessage $emailMessage */
61			$emailMessage = new ZendMessage();
62			$emailMessage->setSubject($subject);
63			$emailMessage->setTo($address);
64			$emailMessage->setBody($text);
65			$emailMessage->setEncoding('UTF-8');
66
67			if ($this->getFromAddress() !== null) {
68			$emailMessage->setFrom($this->getFromAddress(), $this->getFromName());
69			}
70
71			$textPart = new Part($text);
72			$textPart->type = 'text/plain';
73
74			$bodyPart = new MimeMessage();
75			$bodyPart->addPart($textPart);
76
77			if ($html) {
			0 ignored issues – show Bug Best Practice introduced 2017-06-07 20:42 UTC by Report Bug Copy Issue Report The expression `$html` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
78			$htmlPart = new Part($html);
79			$htmlPart->type = 'text/html';
80
81			$bodyPart->addPart($htmlPart);
82			}
83
84			$this->transport->send($emailMessage);
85			}
86			}
87			}
88

waltertamboer / communicator

Push — master ( 83526e...bd9b49 )

ZendMail::send() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like