Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class HttpTest extends \PHPUnit_Framework_TestCase |
||
9 | { |
||
10 | |||
11 | /** @var Http */ |
||
12 | private $sut; |
||
13 | |||
14 | public function testShouldBeInstantiated() |
||
19 | |||
20 | View Code Duplication | public function testShouldReturnData() |
|
27 | |||
28 | /** |
||
29 | * @expectedException \Exception |
||
30 | * @expectedExceptionCode 1 |
||
31 | * @expectedExceptionMessage error |
||
32 | */ |
||
33 | View Code Duplication | public function testShouldThrowException() |
|
40 | |||
41 | View Code Duplication | private function libCurlReturnData() |
|
53 | |||
54 | View Code Duplication | private function libCurlReturnsNothing() |
|
67 | } |
||
68 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.