Ip2c\Ip2c

Complexity

Total Complexity

5

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	self()	0	4	1
A	ip()	0	4	1
A	dec()	0	4	1
A	doRequest()	0	4	1

<?php

namespace Ip2c;

use Ip2c\Http\Request;
use Ip2c\Http\Response;
use Ip2c\Ip\IpUtil;

class Ip2c
{
    private $ip2cBaseUrl = 'http://ip2c.org';
    private $queryStringSelf = 'self';
    private $queryStringDec = 'dec=';

    /** @var Request */
    private $request;
    /** @var IpUtil */
    private $ipUtil;

    /**
     * Ip2c constructor.
     * @param Request $request
     * @param IpUtil $ipUtil
     */
    public function __construct(Request $request, IpUtil $ipUtil)
    {
        $this->request = $request;
        $this->ipUtil = $ipUtil;
    }

    /**
     * @return Response
     */
    public function self()
    {
        return $this->doRequest($this->queryStringSelf);
    }

    /**
     * @param string $ip
     * @return Response
     */
    public function ip($ip)
    {
        return $this->dec($this->ipUtil->ip2long($ip));

It seems like $this->ipUtil->ip2long($ip) targeting Ip2c\Ip\IpUtil::ip2long() can also be of type double or false; however, Ip2c\Ip2c::dec() does only seem to accept integer, maybe add an additional type check?

    }

    /**
     * @param int $ip2long
     * @return Response
     */
    public function dec($ip2long)
    {
        return $this->doRequest($this->queryStringDec . $ip2long);
    }

    /**
     * @param string $queryString
     * @return Response
     * @throws \Exception
     */
    private function doRequest($queryString)
    {
        return new Response($this->request->doRequest($this->ip2cBaseUrl, $queryString));
    }
}