Sorter.compare - Code Metrics - Inspection of "Refactor multisort" - w3nl/array-helpers - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#33)

by Pieter Epeüs

created 2020-09-24 17:18 UTC

Sorter.compare A

↳ Parent: Sorter

Complexity

Conditions

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	12
dl	0
loc	22
rs	9.3333
c	0
b	0
f	0
cc	5

class Sorter {
    constructor(key, direction) {
        this.key = key;
        this.moveDirection = direction === 'desc' ? -1 : 1;
    }

    order(original) {
        return original.sort(this.compare.bind(this));
    }

    compare(firstElement, secondElement) {
        let nameA = firstElement[this.key];
        let nameB = secondElement[this.key];

        if (typeof nameA === 'string') {
            nameA = nameA.toUpperCase();
        }

        if (typeof nameB === 'string') {
            nameB = nameB.toUpperCase();
        }

        if (nameA < nameB) {
            return -1 * this.moveDirection;
        }

        if (nameA > nameB) {
            return 1 * this.moveDirection;
        }

        return 0;
    }
}

module.exports = function multisort(original, key, direction) {
    const sorter = new Sorter(key, direction);

    return sorter.order(original);
};


1			class Sorter {
2			constructor(key, direction) {
3			this.key = key;
4			this.moveDirection = direction === 'desc' ? -1 : 1;
5			}
6
7			order(original) {
8			return original.sort(this.compare.bind(this));
9			}
10
11			compare(firstElement, secondElement) {
12			let nameA = firstElement[this.key];
13			let nameB = secondElement[this.key];
14
15			if (typeof nameA === 'string') {
16			nameA = nameA.toUpperCase();
17			}
18
19			if (typeof nameB === 'string') {
20			nameB = nameB.toUpperCase();
21			}
22
23			if (nameA < nameB) {
24			return -1 * this.moveDirection;
25			}
26
27			if (nameA > nameB) {
28			return 1 * this.moveDirection;
29			}
30
31			return 0;
32			}
33			}
34
35			module.exports = function multisort(original, key, direction) {
36			const sorter = new Sorter(key, direction);
37
38			return sorter.order(original);
39			};
40

w3nl / array-helpers

Pull Request — master (#33)

Sorter.compare A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like