| Conditions | 1 |
| Paths | 1 |
| Total Lines | 253 |
| Code Lines | 250 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 21 | private static function getCountriesList() |
||
| 22 | { |
||
| 23 | return array( |
||
| 24 | 'AF' => 'AFGHANISTAN', |
||
| 25 | 'AL' => 'ALBANIA', |
||
| 26 | 'DZ' => 'ALGERIA', |
||
| 27 | 'AS' => 'AMERICAN SAMOA', |
||
| 28 | 'AD' => 'ANDORRA', |
||
| 29 | 'AO' => 'ANGOLA', |
||
| 30 | 'AI' => 'ANGUILLA', |
||
| 31 | 'AQ' => 'ANTARCTICA', |
||
| 32 | 'AG' => 'ANTIGUA AND BARBUDA', |
||
| 33 | 'AR' => 'ARGENTINA', |
||
| 34 | 'AM' => 'ARMENIA', |
||
| 35 | 'AW' => 'ARUBA', |
||
| 36 | 'AU' => 'AUSTRALIA', |
||
| 37 | 'AT' => 'AUSTRIA', |
||
| 38 | 'AZ' => 'AZERBAIJAN', |
||
| 39 | 'BS' => 'BAHAMAS', |
||
| 40 | 'BH' => 'BAHRAIN', |
||
| 41 | 'BD' => 'BANGLADESH', |
||
| 42 | 'BB' => 'BARBADOS', |
||
| 43 | 'BY' => 'BELARUS', |
||
| 44 | 'BE' => 'BELGIUM', |
||
| 45 | 'BZ' => 'BELIZE', |
||
| 46 | 'BJ' => 'BENIN', |
||
| 47 | 'BM' => 'BERMUDA', |
||
| 48 | 'BT' => 'BHUTAN', |
||
| 49 | 'BO' => 'BOLIVIA, PLURINATIONAL STATE OF', |
||
| 50 | 'BQ' => 'BONAIRE, SINT EUSTATIUS AND SABA', |
||
| 51 | 'BA' => 'BOSNIA AND HERZEGOVINA', |
||
| 52 | 'BW' => 'BOTSWANA', |
||
| 53 | 'BV' => 'BOUVET ISLAND', |
||
| 54 | 'BR' => 'BRAZIL', |
||
| 55 | 'IO' => 'BRITISH INDIAN OCEAN TERRITORY', |
||
| 56 | 'BN' => 'BRUNEI DARUSSALAM', |
||
| 57 | 'BG' => 'BULGARIA', |
||
| 58 | 'BF' => 'BURKINA FASO', |
||
| 59 | 'BI' => 'BURUNDI', |
||
| 60 | 'KH' => 'CAMBODIA', |
||
| 61 | 'CM' => 'CAMEROON', |
||
| 62 | 'CA' => 'CANADA', |
||
| 63 | 'CV' => 'CAPE VERDE', |
||
| 64 | 'KY' => 'CAYMAN ISLANDS', |
||
| 65 | 'CF' => 'CENTRAL AFRICAN REPUBLIC', |
||
| 66 | 'TD' => 'CHAD', |
||
| 67 | 'CL' => 'CHILE', |
||
| 68 | 'CN' => 'CHINA', |
||
| 69 | 'CX' => 'CHRISTMAS ISLAND', |
||
| 70 | 'CC' => 'COCOS (KEELING) ISLANDS', |
||
| 71 | 'CO' => 'COLOMBIA', |
||
| 72 | 'KM' => 'COMOROS', |
||
| 73 | 'CG' => 'CONGO', |
||
| 74 | 'CD' => 'CONGO, THE DEMOCRATIC REPUBLIC OF THE', |
||
| 75 | 'CK' => 'COOK ISLANDS', |
||
| 76 | 'CR' => 'COSTA RICA', |
||
| 77 | 'CI' => 'COTE DIVOIRE', |
||
| 78 | 'HR' => 'CROATIA', |
||
| 79 | 'CU' => 'CUBA', |
||
| 80 | 'CW' => 'CURACAO', |
||
| 81 | 'CY' => 'CYPRUS', |
||
| 82 | 'CZ' => 'CZECH REPUBLIC', |
||
| 83 | 'DK' => 'DENMARK', |
||
| 84 | 'DJ' => 'DJIBOUTI', |
||
| 85 | 'DM' => 'DOMINICA', |
||
| 86 | 'DO' => 'DOMINICAN REPUBLIC', |
||
| 87 | 'EC' => 'ECUADOR', |
||
| 88 | 'EG' => 'EGYPT', |
||
| 89 | 'SV' => 'EL SALVADOR', |
||
| 90 | 'GQ' => 'EQUATORIAL GUINEA', |
||
| 91 | 'ER' => 'ERITREA', |
||
| 92 | 'EE' => 'ESTONIA', |
||
| 93 | 'ET' => 'ETHIOPIA', |
||
| 94 | 'FK' => 'FALKLAND ISLANDS (MALVINAS)', |
||
| 95 | 'FO' => 'FAROE ISLANDS', |
||
| 96 | 'FJ' => 'FIJI', |
||
| 97 | 'FI' => 'FINLAND', |
||
| 98 | 'FR' => 'FRANCE', |
||
| 99 | 'GF' => 'FRENCH GUIANA', |
||
| 100 | 'PF' => 'FRENCH POLYNESIA', |
||
| 101 | 'TF' => 'FRENCH SOUTHERN TERRITORIES', |
||
| 102 | 'GA' => 'GABON', |
||
| 103 | 'GM' => 'GAMBIA', |
||
| 104 | 'GE' => 'GEORGIA', |
||
| 105 | 'DE' => 'GERMANY', |
||
| 106 | 'GH' => 'GHANA', |
||
| 107 | 'GI' => 'GIBRALTAR', |
||
| 108 | 'GR' => 'GREECE', |
||
| 109 | 'GL' => 'GREENLAND', |
||
| 110 | 'GD' => 'GRENADA', |
||
| 111 | 'GP' => 'GUADELOUPE', |
||
| 112 | 'GU' => 'GUAM', |
||
| 113 | 'GT' => 'GUATEMALA', |
||
| 114 | 'GG' => 'GUERNSEY', |
||
| 115 | 'GN' => 'GUINEA', |
||
| 116 | 'GW' => 'GUINEA-BISSAU', |
||
| 117 | 'GY' => 'GUYANA', |
||
| 118 | 'HT' => 'HAITI', |
||
| 119 | 'HM' => 'HEARD ISLAND AND MCDONALD ISLANDS', |
||
| 120 | 'VA' => 'HOLY SEE (VATICAN CITY STATE)', |
||
| 121 | 'HN' => 'HONDURAS', |
||
| 122 | 'HK' => 'HONG KONG', |
||
| 123 | 'HU' => 'HUNGARY', |
||
| 124 | 'IS' => 'ICELAND', |
||
| 125 | 'IN' => 'INDIA', |
||
| 126 | 'ID' => 'INDONESIA', |
||
| 127 | 'IR' => 'IRAN, ISLAMIC REPUBLIC OF', |
||
| 128 | 'IQ' => 'IRAQ', |
||
| 129 | 'IE' => 'IRELAND', |
||
| 130 | 'IM' => 'ISLE OF MAN', |
||
| 131 | 'IL' => 'ISRAEL', |
||
| 132 | 'IT' => 'ITALY', |
||
| 133 | 'JM' => 'JAMAICA', |
||
| 134 | 'JP' => 'JAPAN', |
||
| 135 | 'JE' => 'JERSEY', |
||
| 136 | 'JO' => 'JORDAN', |
||
| 137 | 'KZ' => 'KAZAKHSTAN', |
||
| 138 | 'KE' => 'KENYA', |
||
| 139 | 'KI' => 'KIRIBATI', |
||
| 140 | 'KP' => 'KOREA, DEMOCRATIC PEOPLES REPUBLIC OF', |
||
| 141 | 'KR' => 'KOREA, REPUBLIC OF', |
||
| 142 | 'KW' => 'KUWAIT', |
||
| 143 | 'KG' => 'KYRGYZSTAN', |
||
| 144 | 'LA' => 'LAO PEOPLES DEMOCRATIC REPUBLIC', |
||
| 145 | 'LV' => 'LATVIA', |
||
| 146 | 'LB' => 'LEBANON', |
||
| 147 | 'LS' => 'LESOTHO', |
||
| 148 | 'LR' => 'LIBERIA', |
||
| 149 | 'LY' => 'LIBYA', |
||
| 150 | 'LI' => 'LIECHTENSTEIN', |
||
| 151 | 'LT' => 'LITHUANIA', |
||
| 152 | 'LU' => 'LUXEMBOURG', |
||
| 153 | 'MO' => 'MACAO', |
||
| 154 | 'MK' => 'MACEDONIA, THE FORMER YUGOSLAV REPUBLIC OF', |
||
| 155 | 'MG' => 'MADAGASCAR', |
||
| 156 | 'MW' => 'MALAWI', |
||
| 157 | 'MY' => 'MALAYSIA', |
||
| 158 | 'MV' => 'MALDIVES', |
||
| 159 | 'ML' => 'MALI', |
||
| 160 | 'MT' => 'MALTA', |
||
| 161 | 'MH' => 'MARSHALL ISLANDS', |
||
| 162 | 'MQ' => 'MARTINIQUE', |
||
| 163 | 'MR' => 'MAURITANIA', |
||
| 164 | 'MU' => 'MAURITIUS', |
||
| 165 | 'YT' => 'MAYOTTE', |
||
| 166 | 'MX' => 'MEXICO', |
||
| 167 | 'FM' => 'MICRONESIA, FEDERATED STATES OF', |
||
| 168 | 'MD' => 'MOLDOVA, REPUBLIC OF', |
||
| 169 | 'MC' => 'MONACO', |
||
| 170 | 'MN' => 'MONGOLIA', |
||
| 171 | 'ME' => 'MONTENEGRO', |
||
| 172 | 'MS' => 'MONTSERRAT', |
||
| 173 | 'MA' => 'MOROCCO', |
||
| 174 | 'MZ' => 'MOZAMBIQUE', |
||
| 175 | 'MM' => 'MYANMAR', |
||
| 176 | 'NA' => 'NAMIBIA', |
||
| 177 | 'NR' => 'NAURU', |
||
| 178 | 'NP' => 'NEPAL', |
||
| 179 | 'NL' => 'NETHERLANDS', |
||
| 180 | 'NC' => 'NEW CALEDONIA', |
||
| 181 | 'NZ' => 'NEW ZEALAND', |
||
| 182 | 'NI' => 'NICARAGUA', |
||
| 183 | 'NE' => 'NIGER', |
||
| 184 | 'NG' => 'NIGERIA', |
||
| 185 | 'NU' => 'NIUE', |
||
| 186 | 'NF' => 'NORFOLK ISLAND', |
||
| 187 | 'MP' => 'NORTHERN MARIANA ISLANDS', |
||
| 188 | 'NO' => 'NORWAY', |
||
| 189 | 'OM' => 'OMAN', |
||
| 190 | 'PK' => 'PAKISTAN', |
||
| 191 | 'PW' => 'PALAU', |
||
| 192 | 'PS' => 'PALESTINE, STATE OF', |
||
| 193 | 'PA' => 'PANAMA', |
||
| 194 | 'PG' => 'PAPUA NEW GUINEA', |
||
| 195 | 'PY' => 'PARAGUAY', |
||
| 196 | 'PE' => 'PERU', |
||
| 197 | 'PH' => 'PHILIPPINES', |
||
| 198 | 'PN' => 'PITCAIRN', |
||
| 199 | 'PL' => 'POLAND', |
||
| 200 | 'PT' => 'PORTUGAL', |
||
| 201 | 'PR' => 'PUERTO RICO', |
||
| 202 | 'QA' => 'QATAR', |
||
| 203 | 'RE' => 'REUNION', |
||
| 204 | 'RO' => 'ROMANIA', |
||
| 205 | 'RU' => 'RUSSIAN FEDERATION', |
||
| 206 | 'RW' => 'RWANDA', |
||
| 207 | 'BL' => 'SAINT BARTHv�LEMY', |
||
| 208 | 'SH' => 'SAINT HELENA, ASCENSION AND TRISTAN DA CUNHA', |
||
| 209 | 'KN' => 'SAINT KITTS AND NEVIS', |
||
| 210 | 'LC' => 'SAINT LUCIA', |
||
| 211 | 'MF' => 'SAINT MARTIN (FRENCH PART)', |
||
| 212 | 'PM' => 'SAINT PIERRE AND MIQUELON', |
||
| 213 | 'VC' => 'SAINT VINCENT AND THE GRENADINES', |
||
| 214 | 'WS' => 'SAMOA', |
||
| 215 | 'SM' => 'SAN MARINO', |
||
| 216 | 'ST' => 'SAO TOME AND PRINCIPE', |
||
| 217 | 'SA' => 'SAUDI ARABIA', |
||
| 218 | 'SN' => 'SENEGAL', |
||
| 219 | 'RS' => 'SERBIA', |
||
| 220 | 'SC' => 'SEYCHELLES', |
||
| 221 | 'SL' => 'SIERRA LEONE', |
||
| 222 | 'SG' => 'SINGAPORE', |
||
| 223 | 'SX' => 'SINT MAARTEN (DUTCH PART)', |
||
| 224 | 'SK' => 'SLOVAKIA', |
||
| 225 | 'SI' => 'SLOVENIA', |
||
| 226 | 'SB' => 'SOLOMON ISLANDS', |
||
| 227 | 'SO' => 'SOMALIA', |
||
| 228 | 'ZA' => 'SOUTH AFRICA', |
||
| 229 | 'GS' => 'SOUTH GEORGIA AND THE SOUTH SANDWICH ISLANDS', |
||
| 230 | 'SS' => 'SOUTH SUDAN', |
||
| 231 | 'ES' => 'SPAIN', |
||
| 232 | 'LK' => 'SRI LANKA', |
||
| 233 | 'SD' => 'SUDAN', |
||
| 234 | 'SR' => 'SURINAME', |
||
| 235 | 'SJ' => 'SVALBARD AND JAN MAYEN', |
||
| 236 | 'SZ' => 'SWAZILAND', |
||
| 237 | 'SE' => 'SWEDEN', |
||
| 238 | 'CH' => 'SWITZERLAND', |
||
| 239 | 'SY' => 'SYRIAN ARAB REPUBLIC', |
||
| 240 | 'TW' => 'TAIWAN, PROVINCE OF CHINA', |
||
| 241 | 'TJ' => 'TAJIKISTAN', |
||
| 242 | 'TZ' => 'TANZANIA, UNITED REPUBLIC OF', |
||
| 243 | 'TH' => 'THAILAND', |
||
| 244 | 'TL' => 'TIMOR-LESTE', |
||
| 245 | 'TG' => 'TOGO', |
||
| 246 | 'TK' => 'TOKELAU', |
||
| 247 | 'TO' => 'TONGA', |
||
| 248 | 'TT' => 'TRINIDAD AND TOBAGO', |
||
| 249 | 'TN' => 'TUNISIA', |
||
| 250 | 'TR' => 'TURKEY', |
||
| 251 | 'TM' => 'TURKMENISTAN', |
||
| 252 | 'TC' => 'TURKS AND CAICOS ISLANDS', |
||
| 253 | 'TV' => 'TUVALU', |
||
| 254 | 'UG' => 'UGANDA', |
||
| 255 | 'UA' => 'UKRAINE', |
||
| 256 | 'AE' => 'UNITED ARAB EMIRATES', |
||
| 257 | 'GB' => 'UNITED KINGDOM', |
||
| 258 | 'US' => 'UNITED STATES', |
||
| 259 | 'UM' => 'UNITED STATES MINOR OUTLYING ISLANDS', |
||
| 260 | 'UY' => 'URUGUAY', |
||
| 261 | 'UZ' => 'UZBEKISTAN', |
||
| 262 | 'VU' => 'VANUATU', |
||
| 263 | 'VE' => 'VENEZUELA, BOLIVARIAN REPUBLIC OF', |
||
| 264 | 'VN' => 'VIET NAM', |
||
| 265 | 'VG' => 'VIRGIN ISLANDS, BRITISH', |
||
| 266 | 'VI' => 'VIRGIN ISLANDS, U.S.', |
||
| 267 | 'WF' => 'WALLIS AND FUTUNA', |
||
| 268 | 'EH' => 'WESTERN SAHARA', |
||
| 269 | 'YE' => 'YEMEN', |
||
| 270 | 'ZM' => 'ZAMBIA', |
||
| 271 | 'ZW' => 'ZIMBABWE' |
||
| 272 | ); |
||
| 273 | } |
||
| 274 | } |
||
| 275 |
This check looks for the generic type
arrayas a return type and suggests a more specific type. This type is inferred from the actual code.