w3l\Holt45\Convert

Complexity

Total Complexity

9

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	rgbhex()	0	7	2
B	hexrgb()	0	19	5
A	colorBlend()	0	10	2

<?php
namespace w3l\Holt45;
trait Convert {

	/**
	 * Converts red-green-blue(RGB) to hexadecimal
	 *
	 * @param array $rgb RGB color
	 * @return string Hexadecimal color
	 */
	public static function rgbhex($rgb) {
		$hex = "";
		foreach($rgb AS $color) {
			$hex .= str_pad(dechex($color), 2, "0", STR_PAD_LEFT);
		}
		return $hex;
	}

	/**
	 * Converts hexadecimal to red-green-blue(RGB)
	 *
	 * @param string $hex Hexadecimal color
	 * @return array RGB color

Should the return type not be array<integer|double>|null?

	 */
	function hexrgb($hex) {

It is generally recommended to explicitly declare the visibility for methods.

		$hex = preg_replace("/[^0-9A-Fa-f]/", '', $hex);

		$strlenHex = strlen($hex);

		if($strlenHex >= 3) {
			if($strlenHex >= 6) {
				if($strlenHex > 6) {
					$hex = substr($hex,0,6);
				}
				$hexArray = str_split($hex,2);
			} elseif($strlenHex < 6) {
				$hexArray = array("$hex[0]$hex[0]", "$hex[1]$hex[1]", "$hex[2]$hex[2]");
			}
			return array(hexdec($hexArray[0]), hexdec($hexArray[1]), hexdec($hexArray[2]));

The variable $hexArray does not seem to be defined for all execution paths leading up to this point.

		}

		return NULL;
	}
	/**
	 * Converts hexadecimal to red-green-blue(RGB)
	 *
	 * @param array $arrayRGB RGB color
	 * @param array $arrayRGB2 RGB color
	 * @return array Blended RGB color
	 */
	function colorBlend($arrayRGB,$arrayRGB2) {

It is generally recommended to explicitly declare the visibility for methods.

		$arrayBlend = array();

		for($i = 0; $i < count($arrayRGB); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

			$arrayBlend[] = round(($arrayRGB[$i]+$arrayRGB2[$i])/2);
		}

		return $arrayBlend;
	}

}