Browser::getClientBrowser() - Code Metrics - Inspection of "4 new functions..." - w3l/holt45 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#37)

by w3l

created 2016-01-28 22:56 UTC

Browser::getClientBrowser() C

↳ Parent: Browser

Complexity

Conditions	11
Paths	9

Size

Total Lines	25
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	25
rs	5.2653
cc	11
eloc	18
nc	9
nop	0

How to fix Complexity

<?php
/**
 * Misc.php
 */
namespace w3l\Holt45;

/**
 * Things that does not fit in other traits...
 */
trait Browser
{
    /**
     * Get client ip-address
     *
     * @return null|string User ip-address
     */
    public static function getClientIpAddress($fallbackReturn = null)
    {
        if (getenv('HTTP_CLIENT_IP')) {
            return getenv('HTTP_CLIENT_IP');
        } elseif (getenv('HTTP_X_FORWARDED_FOR')) {
            return getenv('HTTP_X_FORWARDED_FOR');
        } elseif (getenv('HTTP_X_FORWARDED')) {
            return getenv('HTTP_X_FORWARDED');
        } elseif (getenv('HTTP_FORWARDED_FOR')) {
            return getenv('HTTP_FORWARDED_FOR');
        } elseif (getenv('HTTP_FORWARDED')) {
            return getenv('HTTP_FORWARDED');
        } elseif (getenv('REMOTE_ADDR')) {
            return getenv('REMOTE_ADDR');
        }
        /* Unknown IP */
        return $fallbackReturn;
    }

    /**
     * Get client operating system
     *
     * NOTICE: HTTP_USER_AGENT is easily spoofed. Don't trust this data.
     *
     * @used-by: Holt45::kbdSymbol()
     *
     * @return null|string User operating system(win|mac|linux)
     */
    public static function getClientOperatingSystem()
    {
        if(getenv('HTTP_USER_AGENT')) {
            $userAgent = getenv('HTTP_USER_AGENT');

            if (preg_match('/linux/i', $userAgent)) {
                return 'linux';
            } elseif (preg_match('/macintosh|mac os x/i', $userAgent)) {
                return'mac';
            } elseif (preg_match('/windows|win32/i', $userAgent)) {
                return 'win';
            }
        }
        
        return null;
    }

    /**
     * Get client browser
     *
     * NOTICE: HTTP_USER_AGENT is easily spoofed. Don't trust this data.
     *
     * @return null|string User browser(Internet Explorer|Camino|Firefox|Safari|Chrome|Konqueror|Opera)
     */
    public static function getClientBrowser()
    {
        if(getenv('HTTP_USER_AGENT')) {
            
            $userAgent = getenv('HTTP_USER_AGENT');
            
            if ((preg_match('/MSIE/i',$userAgent) || preg_match('/Trident/i',$userAgent)) && !preg_match('/Opera/i',$userAgent)) {

               return 'Internet Explorer';
            } elseif(preg_match('/Camino/i', $userAgent)) {
                return "Camino";
            } elseif(preg_match('/Firefox/i', $userAgent)) {
                return "Firefox";
            } elseif(preg_match('/Safari/i', $userAgent)) {
                return "Safari";
            } elseif(preg_match('/Chrome/i', $userAgent)) {
                return "Chrome";
            } elseif(preg_match('/Konqueror/i', $userAgent)) {
                return "Konqueror";
            } elseif(preg_match('/Opera/i', $userAgent)) {
                return "Opera";
            }
        }
        
        return null;
    }
}


GitHub Access Token became invalid

Pull Request — master (#37)

Browser::getClientBrowser() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1			<?php
2			/**
3			* Misc.php
4			*/
5			namespace w3l\Holt45;
6
7			/**
8			* Things that does not fit in other traits...
9			*/
10			trait Browser
11			{
12			/**
13			* Get client ip-address
14			*
15			* @return null\|string User ip-address
16			*/
17			public static function getClientIpAddress($fallbackReturn = null)
18			{
19			if (getenv('HTTP_CLIENT_IP')) {
20			return getenv('HTTP_CLIENT_IP');
21			} elseif (getenv('HTTP_X_FORWARDED_FOR')) {
22			return getenv('HTTP_X_FORWARDED_FOR');
23			} elseif (getenv('HTTP_X_FORWARDED')) {
24			return getenv('HTTP_X_FORWARDED');
25			} elseif (getenv('HTTP_FORWARDED_FOR')) {
26			return getenv('HTTP_FORWARDED_FOR');
27			} elseif (getenv('HTTP_FORWARDED')) {
28			return getenv('HTTP_FORWARDED');
29			} elseif (getenv('REMOTE_ADDR')) {
30			return getenv('REMOTE_ADDR');
31			}
32			/* Unknown IP */
33			return $fallbackReturn;
34			}
35
36			/**
37			* Get client operating system
38			*
39			* NOTICE: HTTP_USER_AGENT is easily spoofed. Don't trust this data.
40			*
41			* @used-by: Holt45::kbdSymbol()
42			*
43			* @return null\|string User operating system(win\|mac\|linux)
44			*/
45			public static function getClientOperatingSystem()
46			{
47			if(getenv('HTTP_USER_AGENT')) {
48			$userAgent = getenv('HTTP_USER_AGENT');
49
50			if (preg_match('/linux/i', $userAgent)) {
51			return 'linux';
52			} elseif (preg_match('/macintosh\|mac os x/i', $userAgent)) {
53			return'mac';
54			} elseif (preg_match('/windows\|win32/i', $userAgent)) {
55			return 'win';
56			}
57			}
58
59			return null;
60			}
61
62			/**
63			* Get client browser
64			*
65			* NOTICE: HTTP_USER_AGENT is easily spoofed. Don't trust this data.
66			*
67			* @return null\|string User browser(Internet Explorer\|Camino\|Firefox\|Safari\|Chrome\|Konqueror\|Opera)
68			*/
69			public static function getClientBrowser()
70			{
71			if(getenv('HTTP_USER_AGENT')) {
72
73			$userAgent = getenv('HTTP_USER_AGENT');
74
75			if ((preg_match('/MSIE/i',$userAgent) \|\| preg_match('/Trident/i',$userAgent)) && !preg_match('/Opera/i',$userAgent)) {
			0 ignored issues – show Coding Style introduced 2016-01-28 22:57 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 130 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
76			return 'Internet Explorer';
77			} elseif(preg_match('/Camino/i', $userAgent)) {
78			return "Camino";
79			} elseif(preg_match('/Firefox/i', $userAgent)) {
80			return "Firefox";
81			} elseif(preg_match('/Safari/i', $userAgent)) {
82			return "Safari";
83			} elseif(preg_match('/Chrome/i', $userAgent)) {
84			return "Chrome";
85			} elseif(preg_match('/Konqueror/i', $userAgent)) {
86			return "Konqueror";
87			} elseif(preg_match('/Opera/i', $userAgent)) {
88			return "Opera";
89			}
90			}
91
92			return null;
93			}
94			}
95

w3l / holt45

GitHub Access Token became invalid

Pull Request — master (#37)

Browser::getClientBrowser() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like