Session - Code Metrics - Inspection of "Merge pull request #9 from w3l/dev" - w3l/holt45 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (9f36d7)

by w3l

created 2016-01-22 04:36 UTC

Session A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
lcom	0
cbo	0
dl	0
loc	55
c	1
b	0
f	0
rs	10

4 Methods

Rating	Name	Size	Complexity
A	session_set()	3	1
A	session_isset()	14	4
A	session_read()	3	1
A	session_delete()	3	1

<?php
namespace Holt45;
trait Session {

	/**
	 * Handle sessions - set session
	 *
	 * @param string $name Session name
	 * @param string $content Session content
	 * @param int $expires How many seconds before the session should expire.
	 */
	public static function session_set($name, $content, $expires = 86400) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		$_SESSION[$name] = (time() + $expires).'-'.$content;
	}

	/**
	 * Handle sessions - check if session is set and not expired.
	 *
	 * @param string $name Session name
	 * @return bool Session status
	 */
	public static function session_isset($name) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		if(isset($_SESSION[$name])) {
			$expires = current(explode("-",$_SESSION[$name]));
			if(ctype_digit($expires) && $expires > time()) {
				return true;
				
			} else {
				unset($_SESSION[$name]);
				return false;
			}
		} else {
			return false;
		}
	}

	/**
	 * Handle sessions - Get session content
	 *
	 * @param string $name Session name
	 * @return string Session content
	 */
	public static function session_read($name) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		return substr(strstr($_SESSION[$name], '-'),1);
	}

	/**
	 * Handle sessions - Delete session
	 *
	 * @param string $name Session name
	 * @return void
	 */
	public static function session_delete($name) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		unset($_SESSION[$name]);
	}

}

1			<?php
2			namespace Holt45;
3			trait Session {
4
5			/**
6			* Handle sessions - set session
7			*
8			* @param string $name Session name
9			* @param string $content Session content
10			* @param int $expires How many seconds before the session should expire.
11			*/
12			public static function session_set($name, $content, $expires = 86400) {
			0 ignored issues – show Coding Style introduced 2016-01-22 02:52 UTC by Report Bug Copy Issue Report `session_set` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
13			$_SESSION[$name] = (time() + $expires).'-'.$content;
14			}
15
16			/**
17			* Handle sessions - check if session is set and not expired.
18			*
19			* @param string $name Session name
20			* @return bool Session status
21			*/
22			public static function session_isset($name) {
			0 ignored issues – show Coding Style introduced 2016-01-22 02:52 UTC by Report Bug Copy Issue Report `session_isset` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
23			if(isset($_SESSION[$name])) {
24			$expires = current(explode("-",$_SESSION[$name]));
25			if(ctype_digit($expires) && $expires > time()) {
26			return true;
27
28			} else {
29			unset($_SESSION[$name]);
30			return false;
31			}
32			} else {
33			return false;
34			}
35			}
36
37			/**
38			* Handle sessions - Get session content
39			*
40			* @param string $name Session name
41			* @return string Session content
42			*/
43			public static function session_read($name) {
			0 ignored issues – show Coding Style introduced 2016-01-22 02:52 UTC by Report Bug Copy Issue Report `session_read` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
44			return substr(strstr($_SESSION[$name], '-'),1);
45			}
46
47			/**
48			* Handle sessions - Delete session
49			*
50			* @param string $name Session name
51			* @return void
52			*/
53			public static function session_delete($name) {
			0 ignored issues – show Coding Style introduced 2016-01-22 02:52 UTC by Report Bug Copy Issue Report `session_delete` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
54			unset($_SESSION[$name]);
55			}
56
57			}

w3l / holt45

GitHub Access Token became invalid

Branch — master (9f36d7)

Session A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like