Conditions | 1 |
Paths | 1 |
Total Lines | 254 |
Code Lines | 251 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
21 | private static function getCountriesList() |
||
22 | { |
||
23 | return array( |
||
24 | 'AF' => 'AFGHANISTAN', |
||
25 | 'AL' => 'ALBANIA', |
||
26 | 'DZ' => 'ALGERIA', |
||
27 | 'AS' => 'AMERICAN SAMOA', |
||
28 | 'AD' => 'ANDORRA', |
||
29 | 'AO' => 'ANGOLA', |
||
30 | 'AI' => 'ANGUILLA', |
||
31 | 'AQ' => 'ANTARCTICA', |
||
32 | 'AG' => 'ANTIGUA AND BARBUDA', |
||
33 | 'AR' => 'ARGENTINA', |
||
34 | 'AM' => 'ARMENIA', |
||
35 | 'AW' => 'ARUBA', |
||
36 | 'AU' => 'AUSTRALIA', |
||
37 | 'AT' => 'AUSTRIA', |
||
38 | 'AX' => 'ÅLAND ISLANDS', |
||
39 | 'AZ' => 'AZERBAIJAN', |
||
40 | 'BS' => 'BAHAMAS', |
||
41 | 'BH' => 'BAHRAIN', |
||
42 | 'BD' => 'BANGLADESH', |
||
43 | 'BB' => 'BARBADOS', |
||
44 | 'BY' => 'BELARUS', |
||
45 | 'BE' => 'BELGIUM', |
||
46 | 'BZ' => 'BELIZE', |
||
47 | 'BJ' => 'BENIN', |
||
48 | 'BM' => 'BERMUDA', |
||
49 | 'BT' => 'BHUTAN', |
||
50 | 'BO' => 'BOLIVIA, PLURINATIONAL STATE OF', |
||
51 | 'BQ' => 'BONAIRE, SINT EUSTATIUS AND SABA', |
||
52 | 'BA' => 'BOSNIA AND HERZEGOVINA', |
||
53 | 'BW' => 'BOTSWANA', |
||
54 | 'BV' => 'BOUVET ISLAND', |
||
55 | 'BR' => 'BRAZIL', |
||
56 | 'IO' => 'BRITISH INDIAN OCEAN TERRITORY', |
||
57 | 'BN' => 'BRUNEI DARUSSALAM', |
||
58 | 'BG' => 'BULGARIA', |
||
59 | 'BF' => 'BURKINA FASO', |
||
60 | 'BI' => 'BURUNDI', |
||
61 | 'KH' => 'CAMBODIA', |
||
62 | 'CM' => 'CAMEROON', |
||
63 | 'CA' => 'CANADA', |
||
64 | 'CV' => 'CAPE VERDE', |
||
65 | 'KY' => 'CAYMAN ISLANDS', |
||
66 | 'CF' => 'CENTRAL AFRICAN REPUBLIC', |
||
67 | 'TD' => 'CHAD', |
||
68 | 'CL' => 'CHILE', |
||
69 | 'CN' => 'CHINA', |
||
70 | 'CX' => 'CHRISTMAS ISLAND', |
||
71 | 'CC' => 'COCOS (KEELING) ISLANDS', |
||
72 | 'CO' => 'COLOMBIA', |
||
73 | 'KM' => 'COMOROS', |
||
74 | 'CG' => 'CONGO', |
||
75 | 'CD' => 'CONGO, THE DEMOCRATIC REPUBLIC OF THE', |
||
76 | 'CK' => 'COOK ISLANDS', |
||
77 | 'CR' => 'COSTA RICA', |
||
78 | 'CI' => 'COTE DIVOIRE', |
||
79 | 'HR' => 'CROATIA', |
||
80 | 'CU' => 'CUBA', |
||
81 | 'CW' => 'CURAÇAO', |
||
82 | 'CY' => 'CYPRUS', |
||
83 | 'CZ' => 'CZECH REPUBLIC', |
||
84 | 'DK' => 'DENMARK', |
||
85 | 'DJ' => 'DJIBOUTI', |
||
86 | 'DM' => 'DOMINICA', |
||
87 | 'DO' => 'DOMINICAN REPUBLIC', |
||
88 | 'EC' => 'ECUADOR', |
||
89 | 'EG' => 'EGYPT', |
||
90 | 'SV' => 'EL SALVADOR', |
||
91 | 'GQ' => 'EQUATORIAL GUINEA', |
||
92 | 'ER' => 'ERITREA', |
||
93 | 'EE' => 'ESTONIA', |
||
94 | 'ET' => 'ETHIOPIA', |
||
95 | 'FK' => 'FALKLAND ISLANDS (MALVINAS)', |
||
96 | 'FO' => 'FAROE ISLANDS', |
||
97 | 'FJ' => 'FIJI', |
||
98 | 'FI' => 'FINLAND', |
||
99 | 'FR' => 'FRANCE', |
||
100 | 'GF' => 'FRENCH GUIANA', |
||
101 | 'PF' => 'FRENCH POLYNESIA', |
||
102 | 'TF' => 'FRENCH SOUTHERN TERRITORIES', |
||
103 | 'GA' => 'GABON', |
||
104 | 'GM' => 'GAMBIA', |
||
105 | 'GE' => 'GEORGIA', |
||
106 | 'DE' => 'GERMANY', |
||
107 | 'GH' => 'GHANA', |
||
108 | 'GI' => 'GIBRALTAR', |
||
109 | 'GR' => 'GREECE', |
||
110 | 'GL' => 'GREENLAND', |
||
111 | 'GD' => 'GRENADA', |
||
112 | 'GP' => 'GUADELOUPE', |
||
113 | 'GU' => 'GUAM', |
||
114 | 'GT' => 'GUATEMALA', |
||
115 | 'GG' => 'GUERNSEY', |
||
116 | 'GN' => 'GUINEA', |
||
117 | 'GW' => 'GUINEA-BISSAU', |
||
118 | 'GY' => 'GUYANA', |
||
119 | 'HT' => 'HAITI', |
||
120 | 'HM' => 'HEARD ISLAND AND MCDONALD ISLANDS', |
||
121 | 'VA' => 'HOLY SEE (VATICAN CITY STATE)', |
||
122 | 'HN' => 'HONDURAS', |
||
123 | 'HK' => 'HONG KONG', |
||
124 | 'HU' => 'HUNGARY', |
||
125 | 'IS' => 'ICELAND', |
||
126 | 'IN' => 'INDIA', |
||
127 | 'ID' => 'INDONESIA', |
||
128 | 'IR' => 'IRAN, ISLAMIC REPUBLIC OF', |
||
129 | 'IQ' => 'IRAQ', |
||
130 | 'IE' => 'IRELAND', |
||
131 | 'IM' => 'ISLE OF MAN', |
||
132 | 'IL' => 'ISRAEL', |
||
133 | 'IT' => 'ITALY', |
||
134 | 'JM' => 'JAMAICA', |
||
135 | 'JP' => 'JAPAN', |
||
136 | 'JE' => 'JERSEY', |
||
137 | 'JO' => 'JORDAN', |
||
138 | 'KZ' => 'KAZAKHSTAN', |
||
139 | 'KE' => 'KENYA', |
||
140 | 'KI' => 'KIRIBATI', |
||
141 | 'KP' => 'KOREA, DEMOCRATIC PEOPLES REPUBLIC OF', |
||
142 | 'KR' => 'KOREA, REPUBLIC OF', |
||
143 | 'KW' => 'KUWAIT', |
||
144 | 'KG' => 'KYRGYZSTAN', |
||
145 | 'LA' => 'LAO PEOPLES DEMOCRATIC REPUBLIC', |
||
146 | 'LV' => 'LATVIA', |
||
147 | 'LB' => 'LEBANON', |
||
148 | 'LS' => 'LESOTHO', |
||
149 | 'LR' => 'LIBERIA', |
||
150 | 'LY' => 'LIBYA', |
||
151 | 'LI' => 'LIECHTENSTEIN', |
||
152 | 'LT' => 'LITHUANIA', |
||
153 | 'LU' => 'LUXEMBOURG', |
||
154 | 'MO' => 'MACAO', |
||
155 | 'MK' => 'MACEDONIA, THE FORMER YUGOSLAV REPUBLIC OF', |
||
156 | 'MG' => 'MADAGASCAR', |
||
157 | 'MW' => 'MALAWI', |
||
158 | 'MY' => 'MALAYSIA', |
||
159 | 'MV' => 'MALDIVES', |
||
160 | 'ML' => 'MALI', |
||
161 | 'MT' => 'MALTA', |
||
162 | 'MH' => 'MARSHALL ISLANDS', |
||
163 | 'MQ' => 'MARTINIQUE', |
||
164 | 'MR' => 'MAURITANIA', |
||
165 | 'MU' => 'MAURITIUS', |
||
166 | 'YT' => 'MAYOTTE', |
||
167 | 'MX' => 'MEXICO', |
||
168 | 'FM' => 'MICRONESIA, FEDERATED STATES OF', |
||
169 | 'MD' => 'MOLDOVA, REPUBLIC OF', |
||
170 | 'MC' => 'MONACO', |
||
171 | 'MN' => 'MONGOLIA', |
||
172 | 'ME' => 'MONTENEGRO', |
||
173 | 'MS' => 'MONTSERRAT', |
||
174 | 'MA' => 'MOROCCO', |
||
175 | 'MZ' => 'MOZAMBIQUE', |
||
176 | 'MM' => 'MYANMAR', |
||
177 | 'NA' => 'NAMIBIA', |
||
178 | 'NR' => 'NAURU', |
||
179 | 'NP' => 'NEPAL', |
||
180 | 'NL' => 'NETHERLANDS', |
||
181 | 'NC' => 'NEW CALEDONIA', |
||
182 | 'NZ' => 'NEW ZEALAND', |
||
183 | 'NI' => 'NICARAGUA', |
||
184 | 'NE' => 'NIGER', |
||
185 | 'NG' => 'NIGERIA', |
||
186 | 'NU' => 'NIUE', |
||
187 | 'NF' => 'NORFOLK ISLAND', |
||
188 | 'MP' => 'NORTHERN MARIANA ISLANDS', |
||
189 | 'NO' => 'NORWAY', |
||
190 | 'OM' => 'OMAN', |
||
191 | 'PK' => 'PAKISTAN', |
||
192 | 'PW' => 'PALAU', |
||
193 | 'PS' => 'PALESTINE, STATE OF', |
||
194 | 'PA' => 'PANAMA', |
||
195 | 'PG' => 'PAPUA NEW GUINEA', |
||
196 | 'PY' => 'PARAGUAY', |
||
197 | 'PE' => 'PERU', |
||
198 | 'PH' => 'PHILIPPINES', |
||
199 | 'PN' => 'PITCAIRN', |
||
200 | 'PL' => 'POLAND', |
||
201 | 'PT' => 'PORTUGAL', |
||
202 | 'PR' => 'PUERTO RICO', |
||
203 | 'QA' => 'QATAR', |
||
204 | 'RE' => 'RÉUNION', |
||
205 | 'RO' => 'ROMANIA', |
||
206 | 'RU' => 'RUSSIAN FEDERATION', |
||
207 | 'RW' => 'RWANDA', |
||
208 | 'BL' => 'SAINT BARTHÉLEMY', |
||
209 | 'SH' => 'SAINT HELENA, ASCENSION AND TRISTAN DA CUNHA', |
||
210 | 'KN' => 'SAINT KITTS AND NEVIS', |
||
211 | 'LC' => 'SAINT LUCIA', |
||
212 | 'MF' => 'SAINT MARTIN (FRENCH PART)', |
||
213 | 'PM' => 'SAINT PIERRE AND MIQUELON', |
||
214 | 'VC' => 'SAINT VINCENT AND THE GRENADINES', |
||
215 | 'WS' => 'SAMOA', |
||
216 | 'SM' => 'SAN MARINO', |
||
217 | 'ST' => 'SAO TOME AND PRINCIPE', |
||
218 | 'SA' => 'SAUDI ARABIA', |
||
219 | 'SN' => 'SENEGAL', |
||
220 | 'RS' => 'SERBIA', |
||
221 | 'SC' => 'SEYCHELLES', |
||
222 | 'SL' => 'SIERRA LEONE', |
||
223 | 'SG' => 'SINGAPORE', |
||
224 | 'SX' => 'SINT MAARTEN (DUTCH PART)', |
||
225 | 'SK' => 'SLOVAKIA', |
||
226 | 'SI' => 'SLOVENIA', |
||
227 | 'SB' => 'SOLOMON ISLANDS', |
||
228 | 'SO' => 'SOMALIA', |
||
229 | 'ZA' => 'SOUTH AFRICA', |
||
230 | 'GS' => 'SOUTH GEORGIA AND THE SOUTH SANDWICH ISLANDS', |
||
231 | 'SS' => 'SOUTH SUDAN', |
||
232 | 'ES' => 'SPAIN', |
||
233 | 'LK' => 'SRI LANKA', |
||
234 | 'SD' => 'SUDAN', |
||
235 | 'SR' => 'SURINAME', |
||
236 | 'SJ' => 'SVALBARD AND JAN MAYEN', |
||
237 | 'SZ' => 'SWAZILAND', |
||
238 | 'SE' => 'SWEDEN', |
||
239 | 'CH' => 'SWITZERLAND', |
||
240 | 'SY' => 'SYRIAN ARAB REPUBLIC', |
||
241 | 'TW' => 'TAIWAN, PROVINCE OF CHINA', |
||
242 | 'TJ' => 'TAJIKISTAN', |
||
243 | 'TZ' => 'TANZANIA, UNITED REPUBLIC OF', |
||
244 | 'TH' => 'THAILAND', |
||
245 | 'TL' => 'TIMOR-LESTE', |
||
246 | 'TG' => 'TOGO', |
||
247 | 'TK' => 'TOKELAU', |
||
248 | 'TO' => 'TONGA', |
||
249 | 'TT' => 'TRINIDAD AND TOBAGO', |
||
250 | 'TN' => 'TUNISIA', |
||
251 | 'TR' => 'TURKEY', |
||
252 | 'TM' => 'TURKMENISTAN', |
||
253 | 'TC' => 'TURKS AND CAICOS ISLANDS', |
||
254 | 'TV' => 'TUVALU', |
||
255 | 'UG' => 'UGANDA', |
||
256 | 'UA' => 'UKRAINE', |
||
257 | 'AE' => 'UNITED ARAB EMIRATES', |
||
258 | 'GB' => 'UNITED KINGDOM', |
||
259 | 'US' => 'UNITED STATES', |
||
260 | 'UM' => 'UNITED STATES MINOR OUTLYING ISLANDS', |
||
261 | 'UY' => 'URUGUAY', |
||
262 | 'UZ' => 'UZBEKISTAN', |
||
263 | 'VU' => 'VANUATU', |
||
264 | 'VE' => 'VENEZUELA, BOLIVARIAN REPUBLIC OF', |
||
265 | 'VN' => 'VIET NAM', |
||
266 | 'VG' => 'VIRGIN ISLANDS, BRITISH', |
||
267 | 'VI' => 'VIRGIN ISLANDS, U.S.', |
||
268 | 'WF' => 'WALLIS AND FUTUNA', |
||
269 | 'EH' => 'WESTERN SAHARA', |
||
270 | 'YE' => 'YEMEN', |
||
271 | 'ZM' => 'ZAMBIA', |
||
272 | 'ZW' => 'ZIMBABWE' |
||
273 | ); |
||
274 | } |
||
275 | } |
||
276 |
This check looks for the generic type
array
as a return type and suggests a more specific type. This type is inferred from the actual code.