Vyuldashev\XmlToArray\XmlToArray::convertDomElement()

Complexity

Conditions	10
Paths	20

Size

Total Lines	54
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

<?php
    protected function convertDomElement(DOMElement $element)
    {
        $result = $this->convertAttributes($element->attributes);

It seems like $element->attributes can also be of type null; however, parameter $nodeMap of Vyuldashev\XmlToArray\XmlToArray::convertAttributes() does only seem to accept DOMNamedNodeMap, maybe add an additional type check?

        $sameNamesOccurrences = [];
        $sameNodeNameIndexes = [];

        if ($element->childNodes->length > 1) {
            $childNodeNames = [];

            foreach ($element->childNodes as $node) {
                $childNodeNames[] = $node->nodeName;
            }

            $sameNamesOccurrences = array_count_values($childNodeNames);
        }

        foreach ($element->childNodes as $node) {
            if ($node instanceof DOMCdataSection) {
                $result['_cdata'] = $node->data;

                continue;
            }
            if ($node instanceof DOMText) {
                $result = $node->textContent;

                continue;
            }
            if ($node instanceof DOMElement) {
                $nodeName = $node->nodeName;
                $hasSameName = array_key_exists($nodeName, $sameNamesOccurrences) && $sameNamesOccurrences[$nodeName] > 1;

                if ($hasSameName === false) {
                    $result[$nodeName] = $this->convertDomElement($node);
                    continue;
                }

                // If we already have a child node with the same name, we need to increment
                // and keep track of their index.

                if (isset($sameNodeNameIndexes[$nodeName])) {
                    $key = $sameNodeNameIndexes[$nodeName] + 1;
                } else {
                    $key = 0;
                }

                $result[$nodeName][$key] = $this->convertDomElement($node);
                $sameNodeNameIndexes[$nodeName] = $key;

                continue;
            }
        }

        return $result;
    }