Vyuldashev\XmlToArray\XmlToArray::convertDomElement()

Complexity

Conditions	11
Paths	45

Size

Total Lines	49
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

<?php
    protected function convertDomElement(DOMElement $element)
    {
        $sameNames = [];
        $result = $this->convertAttributes($element->attributes);

It seems like $element->attributes can also be of type null; however, parameter $nodeMap of Vyuldashev\XmlToArray\XmlToArray::convertAttributes() does only seem to accept DOMNamedNodeMap, maybe add an additional type check?

        // Creates an index which counts each key, starting at zero, e.g. ['foo' => 2, 'bar' => 0]
        $childNodeNames = [];

The assignment to $childNodeNames is dead and can be removed.

        foreach ($element->childNodes as $key => $node) {
            if (array_key_exists($node->nodeName, $sameNames)) {
                $sameNames[$node->nodeName] += 1;
            } else {
                $sameNames[$node->nodeName] = 0;
            }
        }

        foreach ($element->childNodes as $key => $node) {
            if (is_null($result)) {
                $result = [];
            }

            if ($node instanceof DOMCdataSection) {
                $result['_cdata'] = $node->data;

                continue;
            }
            if ($node instanceof DOMText) {
                if (empty($result)) {
                    $result = $node->textContent;
                } else {
                    $result['_value'] = $node->textContent;
                }
                continue;
            }
            if ($node instanceof DOMElement) {
                if ($sameNames[$node->nodeName]) { // Truthy — When $sameNames['foo'] > 0
                    if (!array_key_exists($node->nodeName, $result)) { // Setup $result['foo']
                        $result[$node->nodeName] = [];
                    }

                    $result[$node->nodeName][$key] = $this->convertDomElement($node); // Store as $result['foo'][*]
                } else {
                    $result[$node->nodeName] = $this->convertDomElement($node); // Store as $result['foo']
                }

                continue;
            }
        }

        return $result;
    }