writers.*JSONWriter.Open - Code Metrics - Inspection of "Refactor json writer" - vvval/go-metadata-scanner - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 98b3e2...f5bfd5 )

by Valentin

created 2018-10-15 12:55 UTC

writers.*JSONWriter.Open A

↳ Parent: cmd/scancmd/writers/json.go

Complexity

Conditions

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	8
nop	2
dl	0
loc	12
rs	10
c	0
b	0
f	0

package writers

import (
	"encoding/json"
	"github.com/vvval/go-metadata-scanner/vars"
)

type JSONWriter struct {
	BaseWriter
	buf map[string]map[string]interface{}
}

// Headers to be like: Filename, XMP, IPTC, etc...
func (w *JSONWriter) Write(file *vars.File) error {
	w.buf[file.RelPath()] = packJSONLine(file, w.headers)

	return nil
}

func (w *JSONWriter) Open(filename string, headers []string) error {
	w.BaseWriter = NewWriter(filename, headers)

	file, err := openFile(w.filename)
	if err != nil {
		return err
	}

	w.buf = make(map[string]map[string]interface{})
	w.file = file

	return nil
}

func (w *JSONWriter) Close() error {
	packed, err := json.MarshalIndent(w.buf, "", "  ")
	if err != nil {
		return err
	}

	w.file.Write(packed)
	closeFile(w.file)

	return nil
}

func packJSONLine(file *vars.File, headers []string) map[string]interface{} {
	record := map[string]interface{}{}
	for k, v := range tagsByGroups(file, headers) {
		record[k] = v
	}

	return record
}


1			package writers
2
3			import (
4			"encoding/json"
5			"github.com/vvval/go-metadata-scanner/vars"
6			)
7
8			type JSONWriter struct {
9			BaseWriter
10			buf map[string]map[string]interface{}
11			}
12
13			// Headers to be like: Filename, XMP, IPTC, etc...
14			func (w JSONWriter) Write(file vars.File) error {
15			w.buf[file.RelPath()] = packJSONLine(file, w.headers)
16
17			return nil
18			}
19
20			func (w *JSONWriter) Open(filename string, headers []string) error {
21			w.BaseWriter = NewWriter(filename, headers)
22
23			file, err := openFile(w.filename)
24			if err != nil {
25			return err
26			}
27
28			w.buf = make(map[string]map[string]interface{})
29			w.file = file
30
31			return nil
32			}
33
34			func (w *JSONWriter) Close() error {
35			packed, err := json.MarshalIndent(w.buf, "", " ")
36			if err != nil {
37			return err
38			}
39
40			w.file.Write(packed)
41			closeFile(w.file)
42
43			return nil
44			}
45
46			func packJSONLine(file *vars.File, headers []string) map[string]interface{} {
47			record := map[string]interface{}{}
48			for k, v := range tagsByGroups(file, headers) {
49			record[k] = v
50			}
51
52			return record
53			}
54

vvval / go-metadata-scanner

Push — master ( 98b3e2...f5bfd5 )

writers.*JSONWriter.Open A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like