vvval /
go-metadata-scanner
| Conditions | 14 |
| Total Lines | 64 |
| Code Lines | 42 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like cmd.scanHandler often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | package cmd |
||
| 46 | func scanHandler(flags scancmd.Flags, appConfig config.AppConfig, initialPoolSize, minChunkSize int) error { |
||
| 47 | if flags.Verbosity() { |
||
| 48 | log.Visibility.Debug = true |
||
| 49 | log.Visibility.Log = true |
||
| 50 | } |
||
| 51 | |||
| 52 | log.Log("Scanning...", fmt.Sprintf("Directory is \"%s\"", util.Abs(flags.Directory()))) |
||
| 53 | |||
| 54 | var files = scan.MustDir(flags.Directory(), appConfig.Extensions()) |
||
| 55 | poolSize, chunkSize := util.AdjustSizes(len(files), initialPoolSize, minChunkSize) |
||
| 56 | |||
| 57 | var chunks = make(chan vars.Chunk) |
||
| 58 | var scannedFiles = make(chan vars.File) |
||
| 59 | var wg sync.WaitGroup |
||
| 60 | scancmd.CreatePool( |
||
| 61 | &wg, |
||
| 62 | poolSize, |
||
| 63 | chunks, |
||
| 64 | func(files vars.Chunk) ([]byte, error) { |
||
| 65 | return etool.Read(files, appConfig.Fields()) |
||
| 66 | }, |
||
| 67 | func(data []byte) { |
||
| 68 | for _, parsed := range etool.Parse(data) { |
||
| 69 | scannedFiles <- parsed |
||
| 70 | } |
||
| 71 | }, |
||
| 72 | ) |
||
| 73 | |||
| 74 | for _, chunk := range files.Split(chunkSize) { |
||
| 75 | wg.Add(1) |
||
| 76 | chunks <- chunk |
||
| 77 | } |
||
| 78 | |||
| 79 | go func() { |
||
| 80 | wg.Wait() |
||
| 81 | close(chunks) |
||
| 82 | close(scannedFiles) |
||
| 83 | }() |
||
| 84 | |||
| 85 | outputFilename := randomizeOutputFilename(flags.Filename()) |
||
| 86 | |||
| 87 | headers := packHeaders(appConfig.Fields()) |
||
| 88 | wr, err := writers.Get(flags.Format()) |
||
| 89 | if err != nil { |
||
| 90 | return err |
||
| 91 | } |
||
| 92 | |||
| 93 | err = wr.Open(outputFilename, headers) |
||
| 94 | if err != nil { |
||
| 95 | return err |
||
| 96 | } |
||
| 97 | defer wr.Close() |
||
| 98 | |||
| 99 | for file := range scannedFiles { |
||
| 100 | file.WithRelPath(flags.Directory()) |
||
| 101 | err := wr.Write(&file) |
||
| 102 | if err != nil { |
||
| 103 | log.Failure("CSV write", fmt.Sprintf("failed writing data for \"%s\" file", file.RelPath())) |
||
| 104 | } |
||
| 105 | } |
||
| 106 | |||
| 107 | log.Done("Scanning completed", fmt.Sprintf("Output file is \"%s\" file", outputFilename)) |
||
| 108 | |||
| 109 | return nil |
||
| 110 | } |
||
| 130 |
