Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
19 | class CommandController extends Controller |
||
20 | { |
||
21 | /** |
||
22 | * @var string|null models class name separate by `,`. |
||
23 | */ |
||
24 | public $models; |
||
25 | |||
26 | /** |
||
27 | * @inheritDoc |
||
28 | */ |
||
29 | public function options($actionID) |
||
33 | |||
34 | /** |
||
35 | * @inheritDoc |
||
36 | */ |
||
37 | 2 | public function beforeAction($action) |
|
47 | |||
48 | /** |
||
49 | * Import the given models into the search index. |
||
50 | */ |
||
51 | 1 | View Code Duplication | public function actionImport() |
63 | |||
64 | /** |
||
65 | * Delete the model class records from the index. |
||
66 | */ |
||
67 | 1 | View Code Duplication | public function actionDelete() |
79 | |||
80 | |||
81 | } |
||
82 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.