ParentRuntime::createProcess() - Code Metrics - Inspection of "Updated test time async" - vuongxuongminh/yii2-async - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8a3baa...fa7e80 )

by Vuong

created 2019-05-07 04:03 UTC

ParentRuntime::createProcess() A

↳ Parent: ParentRuntime

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3.0327

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	11
cts	13
cp	0.8462
rs	9.568
c	0
b	0
f	0
cc	3
nc	4
nop	1
crap	3.0327

<?php
/**
 * @link https://github.com/vuongxuongminh/yii2-async
 * @copyright Copyright (c) 2019 Vuong Xuong Minh
 * @license [New BSD License](http://www.opensource.org/licenses/bsd-license.php)
 */

namespace vxm\async\runtime;

use Spatie\Async\Pool;
use Spatie\Async\Process\ParallelProcess;
use Spatie\Async\Process\Runnable;
use Spatie\Async\Process\SynchronousProcess;
use Spatie\Async\Runtime\ParentRuntime as BaseParentRuntime;
use Symfony\Component\Process\Process;

/**
 * ParentRuntime support invoke yii app in child runtime mode.
 *
 * @author Vuong Minh <[email protected]>
 * @since 1.0.0
 */
class ParentRuntime extends BaseParentRuntime
{

    /**
     * @inheritDoc
     */
    public static function createProcess($task): Runnable
    {
        if (!self::$isInitialised) {
            self::init();
        }

        list($task, $appConfigFile) = $task;

        if (!Pool::isSupported()) {
            return SynchronousProcess::create($task, self::getId());
        }

        $process = new Process(implode(' ', [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'exec php',
            self::$childProcessScript,
            self::$autoloader,
            self::encodeTask($task),
            $appConfigFile
        ]));

        return ParallelProcess::create($process, self::getId());
    }
}


1		<?php
2		/**
3		* @link https://github.com/vuongxuongminh/yii2-async
4		* @copyright Copyright (c) 2019 Vuong Xuong Minh
5		* @license [New BSD License](http://www.opensource.org/licenses/bsd-license.php)
6		*/
7
8		namespace vxm\async\runtime;
9
10		use Spatie\Async\Pool;
11		use Spatie\Async\Process\ParallelProcess;
12		use Spatie\Async\Process\Runnable;
13		use Spatie\Async\Process\SynchronousProcess;
14		use Spatie\Async\Runtime\ParentRuntime as BaseParentRuntime;
15		use Symfony\Component\Process\Process;
16
17		/**
18		* ParentRuntime support invoke yii app in child runtime mode.
19		*
20		* @author Vuong Minh <[email protected]>
21		* @since 1.0.0
22		*/
23		class ParentRuntime extends BaseParentRuntime
24		{
25
26		/**
27		* @inheritDoc
28		*/
29	8	public static function createProcess($task): Runnable
30		{
31	8	if (!self::$isInitialised) {
32		self::init();
33		}
34
35	8	list($task, $appConfigFile) = $task;
36
37	8	if (!Pool::isSupported()) {
38		return SynchronousProcess::create($task, self::getId());
39		}
40
41	8	$process = new Process(implode(' ', [
		0 ignored issues – show Documentation introduced 2019-05-07 04:05 UTC by Report Bug Copy Issue Report `implode(' ', array('exec...task), $appConfigFile))` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42	8	'exec php',
43	8	self::$childProcessScript,
44	8	self::$autoloader,
45	8	self::encodeTask($task),
46	8	$appConfigFile
47		]));
48
49	8	return ParallelProcess::create($process, self::getId());
50		}
51		}
52

vuongxuongminh / yii2-async

Push — master ( 8a3baa...fa7e80 )

ParentRuntime::createProcess() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like