VXM\MobileFirst\MobileRedirect

Complexity

Total Complexity

8

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	handle()	0	8	2
A	shouldRedirect()	0	6	2
A	getUrlFor()	0	14	3

<?php
/**
 * @link https://github.com/vuongxuongminh/laravel-mobile-first
 *
 * @copyright (c) Vuong Xuong Minh
 * @license [MIT](https://opensource.org/licenses/MIT)
 */

namespace VXM\MobileFirst;

use Closure;
use Illuminate\Support\Arr;
use Jenssegers\Agent\Agent;
use Illuminate\Support\Facades\Redirect;

/**
 * @author Vuong Minh <vuongxuongminh@gmail.com>
 * @since  1.0.0
 */
class MobileRedirect
{
    /**
     * Mobile base url.
     *
     * @var string
     */
    protected $baseUrl;

    /**
     * Keep url path when redirect to `baseUrl`.
     *
     * @var bool
     */
    protected $keepPath;

    /**
     * Methods should redirect.
     *
     * @var array
     */
    protected $methods;

    /**
     * Redirect status code.
     *
     * @var int
     */
    protected $statusCode;

    /**
     * Create new MobileRedirect instance.
     *
     * @param string $baseUrl
     * @param bool $keepPath
     * @param int $statusCode
     */
    public function __construct(string $baseUrl, bool $keepPath, int $statusCode, array $methods)
    {
        $this->baseUrl = $baseUrl;
        $this->methods = $methods;
        $this->keepPath = $keepPath;
        $this->statusCode = $statusCode;
    }

    /**
     * Redirect to mobile site if end-user not using desktop device.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        if ($this->shouldRedirect($request)) {
            return Redirect::to($this->getUrlFor($request), $this->statusCode);
        }

        return $next($request);
    }

    /**
     * Return should redirect or not by request given.
     *
     * @param \Illuminate\Http\Request $request
     * @return bool
     */
    protected function shouldRedirect($request): bool
    {
        $agent = new Agent($request->server());

It seems like $request->server() targeting Illuminate\Http\Concerns\InteractsWithInput::server() can also be of type string; however, Mobile_Detect::__construct() does only seem to accept null|array, maybe add an additional type check?

        return ! $agent->isDesktop() && in_array($request->getMethod(), $this->methods);
    }

    /**
     * Get url for request.
     *
     * @param \Illuminate\Http\Request $request
     * @return string
     */
    protected function getUrlFor($request): string
    {
        $url = $this->baseUrl;

        if ($this->keepPath) {
            $url = rtrim($url).$request->getPathInfo();

            if ($query = Arr::query($request->query())) {

It seems like $request->query() targeting Illuminate\Http\Concerns\InteractsWithInput::query() can also be of type null or string; however, Illuminate\Support\Arr::query() does only seem to accept array, maybe add an additional type check?

                $url .= '?'.$query;
            }
        }

        return $url;
    }
}