Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | View Code Duplication | class EditStaffRequest implements RequestInterface |
|
|
|||
11 | { |
||
12 | /** |
||
13 | * @var int |
||
14 | */ |
||
15 | private $staffId; |
||
16 | |||
17 | /** |
||
18 | * @var string |
||
19 | */ |
||
20 | private $email; |
||
21 | |||
22 | /** |
||
23 | * @var string |
||
24 | */ |
||
25 | private $fullName; |
||
26 | |||
27 | /** |
||
28 | * @var string |
||
29 | */ |
||
30 | private $signature; |
||
31 | |||
32 | /** |
||
33 | * @return int |
||
34 | */ |
||
35 | public function getStaffId() |
||
39 | |||
40 | /** |
||
41 | * @param int $staffId |
||
42 | * @return $this |
||
43 | */ |
||
44 | public function setStaffId($staffId) |
||
50 | |||
51 | /** |
||
52 | * @return string |
||
53 | */ |
||
54 | public function getEmail() |
||
58 | |||
59 | /** |
||
60 | * @param string $email |
||
61 | */ |
||
62 | public function setEmail($email) |
||
66 | |||
67 | /** |
||
68 | * @return string |
||
69 | */ |
||
70 | public function getFullName() |
||
74 | |||
75 | /** |
||
76 | * @param string $fullName |
||
77 | */ |
||
78 | public function setFullName($fullName) |
||
82 | |||
83 | /** |
||
84 | * @return string |
||
85 | */ |
||
86 | public function getSignature() |
||
90 | |||
91 | /** |
||
92 | * @param string $signature |
||
93 | */ |
||
94 | public function setSignature($signature) |
||
98 | } |
||
99 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.