vragovR /
omnidesk-bundle
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 91 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 38 | public function getConfigTreeBuilder() |
||
| 39 | { |
||
| 40 | $treeBuilder = new TreeBuilder(); |
||
| 41 | |||
| 42 | $rootNode = $treeBuilder->root('params'); |
||
| 43 | |||
| 44 | $rootNode |
||
| 45 | ->children() |
||
| 46 | ->scalarNode('page') |
||
| 47 | ->defaultNull() |
||
| 48 | ->end() |
||
| 49 | ->scalarNode('limit') |
||
| 50 | ->defaultNull() |
||
| 51 | ->end() |
||
| 52 | ->scalarNode('user_id') |
||
| 53 | ->defaultNull() |
||
| 54 | ->end() |
||
| 55 | ->scalarNode('user_email') |
||
| 56 | ->defaultNull() |
||
| 57 | ->end() |
||
| 58 | ->scalarNode('user_phone') |
||
| 59 | ->defaultNull() |
||
| 60 | ->end() |
||
| 61 | ->scalarNode('subject') |
||
| 62 | ->defaultNull() |
||
| 63 | ->end() |
||
| 64 | ->scalarNode('staff_id') |
||
| 65 | ->defaultNull() |
||
| 66 | ->end() |
||
| 67 | ->scalarNode('group_id') |
||
| 68 | ->defaultNull() |
||
| 69 | ->end() |
||
| 70 | ->scalarNode('channel') |
||
| 71 | ->defaultNull() |
||
| 72 | ->validate() |
||
| 73 | ->ifNotInArray([ |
||
| 74 | null, |
||
| 75 | Cases::CHANNEL_CHAT, |
||
| 76 | Cases::CHANNEL_EMAIL, |
||
| 77 | Cases::CHANNEL_FACEBOOK, |
||
| 78 | Cases::CHANNEL_IDEA, |
||
| 79 | Cases::CHANNEL_TWITTER, |
||
| 80 | ]) |
||
| 81 | ->thenInvalid(self::MESSAGE_CHANNEL_INVALID_TYPE) |
||
| 82 | ->end() |
||
| 83 | ->end() |
||
| 84 | ->scalarNode('priority') |
||
| 85 | ->validate() |
||
| 86 | ->ifNotInArray([ |
||
| 87 | null, |
||
| 88 | Cases::PRIORITY_LOW, |
||
| 89 | Cases::PRIORITY_NORMAL, |
||
| 90 | Cases::PRIORITY_HIGH, |
||
| 91 | Cases::PRIORITY_CRITICAL, |
||
| 92 | ]) |
||
| 93 | ->thenInvalid(self::MESSAGE_PRIORITY_INVALID_TYPE) |
||
| 94 | ->end() |
||
| 95 | ->end() |
||
| 96 | ->scalarNode('status') |
||
| 97 | ->validate() |
||
| 98 | ->ifNotInArray([ |
||
| 99 | null, |
||
| 100 | Cases::STATUS_OPEN, |
||
| 101 | Cases::STATUS_WAITING, |
||
| 102 | Cases::STATUS_CLOSED, |
||
| 103 | ]) |
||
| 104 | ->thenInvalid(self::MESSAGE_STATUS_INVALID_TYPE) |
||
| 105 | ->end() |
||
| 106 | ->end() |
||
| 107 | ->arrayNode('custom_fields') |
||
| 108 | ->prototype('scalar') |
||
| 109 | ->end() |
||
| 110 | ->end() |
||
| 111 | ->arrayNode('labels') |
||
| 112 | ->end() |
||
| 113 | ->scalarNode('sort') |
||
| 114 | ->validate() |
||
| 115 | ->ifNotInArray([ |
||
| 116 | null, |
||
| 117 | ListCasesRequest::SORT_CREATED_AT_ASC, |
||
| 118 | ListCasesRequest::SORT_CREATED_AT_DESC, |
||
| 119 | ListCasesRequest::SORT_UPDATED_AT_ASC, |
||
| 120 | ListCasesRequest::SORT_UPDATED_AT_DESC, |
||
| 121 | ]) |
||
| 122 | ->thenInvalid(self::MESSAGE_SORT_INVALID_TYPE) |
||
| 123 | ->end() |
||
| 124 | ->end() |
||
| 125 | ->end(); |
||
| 126 | |||
| 127 | return $treeBuilder; |
||
| 128 | } |
||
| 129 | } |
||
| 130 |
