SlowQueryServiceProvider::setupEvents() - Code Metrics - vormkracht10/laravel-slow-query - Measure and Improve Code Quality continuously with Scrutinizer

SlowQueryServiceProvider::setupEvents() A
last analyzed 2020-02-23 11:02 UTC

↳ Parent: SlowQueryServiceProvider

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0
cc	2
nc	1
nop	1

<?php

namespace Vormkracht10\SlowQuery;

use Illuminate\Database\Events\QueryExecuted;
use Illuminate\Support\Facades\Config;
use Illuminate\Support\Facades\Notification;
use Illuminate\Support\ServiceProvider;
use Vormkracht10\SlowQuery\Events\QueryExecutedSlowly;
use Vormkracht10\SlowQuery\Notifications\SlowQueryDetected;

class SlowQueryServiceProvider extends ServiceProvider
{
    /**
     * Bootstrap the application services.
     */
    public function boot()
    {
        $this->publishes([
            __DIR__ . '/../config/slow-query.php' => config_path('slow-query.php'),
        ], 'config');

        $this->setupEvents($this->app->events);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function register()
    {
        $this->mergeConfigFrom(__DIR__ . '/../config/slow-query.php', 'slow-query');
    }

    public function setupEvents($events)
    {
        $events->listen(QueryExecuted::class, function (QueryExecuted $query) {
            if ($this->slowQueryCheck($query)) {
                event(new QueryExecutedSlowly($query));
            }
        });

        $events->listen(QueryExecutedSlowly::class, function (QueryExecutedSlowly $event) {
            $provider = Config::get('slow-query.notifications.default');
            $channel = Config::get('slow-query.notifications.' . $provider . '.channel');

            Notification::route($provider, $channel)
                ->notify(new SlowQueryDetected($event->query));
        });
    }

    public function slowQueryCheck(QueryExecuted $query)
    {
        return $query->time >= Config::get('slow-query.treshold_in_ms');
    }
}


1			<?php
2
3			namespace Vormkracht10\SlowQuery;
4
5			use Illuminate\Database\Events\QueryExecuted;
6			use Illuminate\Support\Facades\Config;
7			use Illuminate\Support\Facades\Notification;
8			use Illuminate\Support\ServiceProvider;
9			use Vormkracht10\SlowQuery\Events\QueryExecutedSlowly;
10			use Vormkracht10\SlowQuery\Notifications\SlowQueryDetected;
11
12			class SlowQueryServiceProvider extends ServiceProvider
13			{
14			/**
15			* Bootstrap the application services.
16			*/
17			public function boot()
18			{
19			$this->publishes([
20			__DIR__ . '/../config/slow-query.php' => config_path('slow-query.php'),
21			], 'config');
22
23			$this->setupEvents($this->app->events);
			0 ignored issues – show Bug introduced 2020-02-22 09:57 UTC by Report Bug Copy Issue Report Accessing `events` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
24			}
25
26			public function register()
27			{
28			$this->mergeConfigFrom(__DIR__ . '/../config/slow-query.php', 'slow-query');
29			}
30
31			public function setupEvents($events)
32			{
33			$events->listen(QueryExecuted::class, function (QueryExecuted $query) {
34			if ($this->slowQueryCheck($query)) {
35			event(new QueryExecutedSlowly($query));
36			}
37			});
38
39			$events->listen(QueryExecutedSlowly::class, function (QueryExecutedSlowly $event) {
40			$provider = Config::get('slow-query.notifications.default');
41			$channel = Config::get('slow-query.notifications.' . $provider . '.channel');
42
43			Notification::route($provider, $channel)
44			->notify(new SlowQueryDetected($event->query));
45			});
46			}
47
48			public function slowQueryCheck(QueryExecuted $query)
49			{
50			return $query->time >= Config::get('slow-query.treshold_in_ms');
51			}
52			}
53

vormkracht10 / laravel-slow-query

SlowQueryServiceProvider::setupEvents() A last analyzed 2020-02-23 11:02 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

SlowQueryServiceProvider::setupEvents() A
last analyzed 2020-02-23 11:02 UTC