Swift_Attachment::fromPath() - Code Metrics - Inspection of "[+]: use "Swift::strtolowerWithStaticCache()" for..." - voku/swiftmailer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 5.x ( 801190...049872 )

by Lars

created 2016-05-28 11:14 UTC

Swift_Attachment::fromPath() A

↳ Parent: Swift_Attachment

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	4
c	0
b	0
f	0
nc	1
nop	2
dl	0
loc	7
ccs	0
cts	0
cp	0
crap	2
rs	9.4285

<?php

/*
 * This file is part of SwiftMailer.
 * (c) 2004-2009 Chris Corbyn
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

/**
 * Attachment class for attaching files to a {@link Swift_Mime_Message}.
 *
 * @author Chris Corbyn
 */
class Swift_Attachment extends Swift_Mime_Attachment
namespace YourVendor;

class YourClass { }
{
    /**
     * Create a new Attachment.
     *
     * Details may be optionally provided to the constructor.
     *
     * @param string|Swift_OutputByteStream $data
     * @param string                        $filename
     * @param string                        $contentType
     */
    public function __construct($data = null, $filename = null, $contentType = null)
    {
        call_user_func_array(
            array($this, 'Swift_Mime_Attachment::__construct'),
            Swift_DependencyContainer::getInstance()->createDependenciesFor('mime.attachment')
        );

        $this->setBody($data);
        $this->setFilename($filename);
        if ($contentType) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->setContentType($contentType);
        }
    }

    /**
     * Create a new Attachment.
     *
     * @param string|Swift_OutputByteStream $data
     * @param string                        $filename
     * @param string                        $contentType
     *
     * @return Swift_Mime_Attachment
     */
    public static function newInstance($data = null, $filename = null, $contentType = null)
    {
        return new self($data, $filename, $contentType);
    }

    /**
     * Create a new Attachment from a filesystem path.
     *
     * @param string $path
     * @param string $contentType optional
     *
     * @return Swift_Mime_Attachment
     */
    public static function fromPath($path, $contentType = null)
    {
        return self::newInstance()->setFile(
            new Swift_ByteStream_FileByteStream($path),
            $contentType
        );
    }
}


1		<?php
2
3		/*
4		* This file is part of SwiftMailer.
5		* (c) 2004-2009 Chris Corbyn
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		/**
12		* Attachment class for attaching files to a {@link Swift_Mime_Message}.
13		*
14		* @author Chris Corbyn
15		*/
16		class Swift_Attachment extends Swift_Mime_Attachment
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-22 11:38 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
17		{
18		/**
19		* Create a new Attachment.
20		*
21		* Details may be optionally provided to the constructor.
22		*
23		* @param string\|Swift_OutputByteStream $data
24		* @param string $filename
25		* @param string $contentType
26		*/
27	6	public function __construct($data = null, $filename = null, $contentType = null)
28		{
29		call_user_func_array(
30	6	array($this, 'Swift_Mime_Attachment::__construct'),
31	6	Swift_DependencyContainer::getInstance()->createDependenciesFor('mime.attachment')
32		);
33
34		$this->setBody($data);
35		$this->setFilename($filename);
36		if ($contentType) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-22 11:38 UTC by Report Bug Copy Issue Report The expression `$contentType` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
37		$this->setContentType($contentType);
38		}
39		}
40
41		/**
42		* Create a new Attachment.
43		*
44		* @param string\|Swift_OutputByteStream $data
45		* @param string $filename
46		* @param string $contentType
47		*
48		* @return Swift_Mime_Attachment
49		*/
50	6	public static function newInstance($data = null, $filename = null, $contentType = null)
51		{
52	6	return new self($data, $filename, $contentType);
53		}
54
55		/**
56		* Create a new Attachment from a filesystem path.
57		*
58		* @param string $path
59		* @param string $contentType optional
60		*
61		* @return Swift_Mime_Attachment
62		*/
63		public static function fromPath($path, $contentType = null)
64		{
65		return self::newInstance()->setFile(
66		new Swift_ByteStream_FileByteStream($path),
67		$contentType
68		);
69		}
70		}
71

voku / swiftmailer

Push — 5.x ( 801190...049872 )

Swift_Attachment::fromPath() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like