SimpleHtmlDomBlank - Code Metrics - Inspection of "[*]: add one more test" - voku/simple_html_dom - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 68d119...ebc63c )

by Lars

created 2019-05-20 07:56 UTC

SimpleHtmlDomBlank A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	358
Duplicated Lines	2.79 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

27.69%

Importance

Changes

Metric	Value
wmc	32
lcom	0
cbo	3
dl	10
loc	358
ccs	18
cts	65
cp	0.2769
rs	9.84
c	0
b	0
f	0

31 Methods

Rating	Name	Duplication	Size	Complexity
A	getIterator()	0	4	1
A	childNodes()	0	4	1
A	find()	0	4	1
A	findOne()	0	4	1
A	findMulti()	0	4	1
A	firstChild()	0	4	1
A	getAllAttributes()	0	4	1
A	getAttribute()	0	4	1
A	getElementById()	0	4	1
A	getElementsById()	0	4	1
A	getElementByClass()	0	4	1
A	getElementByTagName()	0	4	1
A	getElementsByTagName()	0	4	1
A	getHtmlDomParser()	0	4	1
A	getNode()	0	4	1
A	hasAttribute()	0	4	1
A	html()	0	4	1
A	lastChild()	0	4	1
A	nextSibling()	0	4	1
A	parentNode()	0	4	1
A	isRemoved()	0	4	1
A	previousSibling()	0	4	1
A	setAttribute()	0	4	1
A	val()	0	4	1
A	removeAttribute()	0	4	1
A	text()	0	4	1
A	replaceNodeWithString()	0	4	1
A	replaceChildWithString()	0	4	1
A	replaceTextWithString()	0	4	1
A	innerHtml()	0	4	1
A	__call()	10	10	2

How to fix Duplicated Code

<?php

declare(strict_types=1);

namespace voku\helper;

/** @noinspection PhpHierarchyChecksInspection */
class SimpleHtmlDomBlank extends AbstractSimpleHtmlDom implements \IteratorAggregate, SimpleHtmlDomInterface
{
    /**
     * @var null
     */
    protected $node;

    /**
     * Retrieve an external iterator.
     *
     * @see  http://php.net/manual/en/iteratoraggregate.getiterator.php
     *
     * @return SimpleHtmlDomNodeInterface
     *                           <p>
     *                              An instance of an object implementing <b>Iterator</b> or
     *                              <b>Traversable</b>
     *                           </p>
     */
    public function getIterator(): SimpleHtmlDomNodeInterface
    {
        return new SimpleHtmlDomNodeBlank();
    }

    /**
     * Returns children of node.
     *
     * @param int $idx
     *
     * @return null
     */
    public function childNodes(int $idx = -1)
    {
        return null;
    }

    /**
     * Find list of nodes with a CSS selector.
     *
     * @param string   $selector
     * @param int|null $idx
     *
     * @return SimpleHtmlDomNodeInterface
     */
    public function find(string $selector, $idx = null)
    {
        return new SimpleHtmlDomNodeBlank();
    }

    /**
     * Find one node with a CSS selector.
     *
     * @param string $selector
     *
     * @return SimpleHtmlDomInterface
     */
    public function findOne(string $selector): SimpleHtmlDomInterface
    {
        return new static();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Find nodes with a CSS selector.
     *
     * @param string $selector
     *
     * @return SimpleHtmlDomNodeInterface
     */
    public function findMulti(string $selector): SimpleHtmlDomNodeInterface
    {
        return new SimpleHtmlDomNodeBlank();
    }

    /**
     * Returns the first child of node.
     *
     * @return null
     */
    public function firstChild()
    {
        return null;
    }

    /**
     * Returns an array of attributes.
     *
     * @return null
     */
    public function getAllAttributes()
    {
        return null;
    }

    /**
     * Return attribute value.
     *
     * @param string $name
     *
     * @return string
     */
    public function getAttribute(string $name): string
    {
        return '';
    }

    /**
     * Return element by #id.
     *
     * @param string $id
     *
     * @return SimpleHtmlDomInterface
     */
    public function getElementById(string $id): SimpleHtmlDomInterface
    {
        return new static();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Returns elements by #id.
     *
     * @param string   $id
     * @param int|null $idx
     *
     * @return SimpleHtmlDomNodeInterface
     */
    public function getElementsById(string $id, $idx = null)
    {
        return new SimpleHtmlDomNodeBlank();
    }

    /**
     * Return elements by .class.
     *
     * @param string $class
     *
     * @return SimpleHtmlDomNodeInterface
     */
    public function getElementByClass(string $class): SimpleHtmlDomNodeInterface
    {
        return new SimpleHtmlDomNodeBlank();
    }

    /**
     * Return element by tag name.
     *
     * @param string $name
     *
     * @return SimpleHtmlDomInterface
     */
    public function getElementByTagName(string $name): SimpleHtmlDomInterface
    {
        return new static();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Returns elements by tag name.
     *
     * @param string   $name
     * @param int|null $idx
     *
     * @return SimpleHtmlDomNodeInterface
     */
    public function getElementsByTagName(string $name, $idx = null)
    {
        return new SimpleHtmlDomNodeBlank();
    }

    /**
     * Create a new "HtmlDomParser"-object from the current context.
     *
     * @return HtmlDomParser
     */
    public function getHtmlDomParser(): HtmlDomParser
    {
        return new HtmlDomParser($this);
    }

    /**
     * @return \DOMNode
     */
    public function getNode(): \DOMNode
    {
        return new \DOMNode();
    }

    /**
     * Determine if an attribute exists on the element.
     *
     * @param string $name
     *
     * @return bool
     */
    public function hasAttribute(string $name): bool
    {
        return false;
    }

    /**
     * Get dom node's outer html.
     *
     * @param bool $multiDecodeNewHtmlEntity
     *
     * @return string
     */
    public function html(bool $multiDecodeNewHtmlEntity = false): string
    {
        return '';
    }

    /**
     * Get dom node's inner html.
     *
     * @param bool $multiDecodeNewHtmlEntity
     *
     * @return string
     */
    public function innerHtml(bool $multiDecodeNewHtmlEntity = false): string
    {
        return '';
    }

    /**
     * Returns the last child of node.
     *
     * @return null
     */
    public function lastChild()
    {
        return null;
    }

    /**
     * Returns the next sibling of node.
     *
     * @return null
     */
    public function nextSibling()
    {
        return null;
    }

    /**
     * Returns the parent of node.
     *
     * @return SimpleHtmlDomInterface
     */
    public function parentNode(): SimpleHtmlDomInterface
    {
        return new static();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Nodes can get partially destroyed in which they're still an
     * actual DOM node (such as \DOMElement) but almost their entire
     * body is gone, including the `nodeType` attribute.
     *
     * @return bool true if node has been destroyed
     */
    public function isRemoved(): bool
    {
        return true;
    }

    /**
     * Returns the previous sibling of node.
     *
     * @return null
     */
    public function previousSibling()
    {
        return null;
    }

    /**
     * Set attribute value.
     *
     * @param string      $name       <p>The name of the html-attribute.</p>
     * @param string|null $value      <p>Set to NULL or empty string, to remove the attribute.</p>
     * @param bool        $strict     </p>
     *                                $value must be NULL, to remove the attribute,
     *                                so that you can set an empty string as attribute-value e.g. autofocus=""
     *                                </p>
     *
     * @return SimpleHtmlDomInterface
     */
    public function setAttribute(string $name, $value = null, bool $strict = false): SimpleHtmlDomInterface
    {
        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param string|string[]|null $value <p>
     *                                    null === get the current input value
     *                                    text === set a new input value
     *                                    </p>
     *
     * @return string|string[]|null
     */
    public function val($value = null)
    {
        return null;
    }

    /**
     * Remove attribute.
     *
     * @param string $name <p>The name of the html-attribute.</p>
     *
     * @return SimpleHtmlDomInterface
     */
    public function removeAttribute(string $name): SimpleHtmlDomInterface
    {
        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Get dom node's plain text.
     *
     * @return string
     */
    public function text(): string
    {
        return '';
    }

    /**
     * @param string $name
     * @param array  $arguments
     *
     * @throws \BadMethodCallException
     *
     * @return SimpleHtmlDomInterface|string|null
     */
    public function __call($name, $arguments)

    {
        $name = \strtolower($name);

        if (isset(self::$functionAliases[$name])) {
            return \call_user_func_array([$this, self::$functionAliases[$name]], $arguments);
        }

        throw new \BadMethodCallException('Method does not exist');
    }

    protected function replaceNodeWithString(string $string): SimpleHtmlDomInterface
    {
        return new static();
    }

    protected function replaceChildWithString(string $string): SimpleHtmlDomInterface
    {
        return new static();
    }

    protected function replaceTextWithString($string): SimpleHtmlDomInterface
    {
        return new static();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace voku\helper;
6
7			/** @noinspection PhpHierarchyChecksInspection */
8			class SimpleHtmlDomBlank extends AbstractSimpleHtmlDom implements \IteratorAggregate, SimpleHtmlDomInterface
9			{
10			/**
11			* @var null
12			*/
13			protected $node;
14
15			/**
16			* Retrieve an external iterator.
17			*
18			* @see http://php.net/manual/en/iteratoraggregate.getiterator.php
19			*
20			* @return SimpleHtmlDomNodeInterface
21			* <p>
22			* An instance of an object implementing <b>Iterator</b> or
23			* <b>Traversable</b>
24			* </p>
25			*/
26	1		public function getIterator(): SimpleHtmlDomNodeInterface
27			{
28	1		return new SimpleHtmlDomNodeBlank();
29			}
30
31			/**
32			* Returns children of node.
33			*
34			* @param int $idx
35			*
36			* @return null
37			*/
38			public function childNodes(int $idx = -1)
39			{
40			return null;
41			}
42
43			/**
44			* Find list of nodes with a CSS selector.
45			*
46			* @param string $selector
47			* @param int\|null $idx
48			*
49			* @return SimpleHtmlDomNodeInterface
50			*/
51			public function find(string $selector, $idx = null)
52			{
53			return new SimpleHtmlDomNodeBlank();
54			}
55
56			/**
57			* Find one node with a CSS selector.
58			*
59			* @param string $selector
60			*
61			* @return SimpleHtmlDomInterface
62			*/
63			public function findOne(string $selector): SimpleHtmlDomInterface
64			{
65			return new static();
			0 ignored issues – show Bug Best Practice introduced 2019-04-25 23:06 UTC by Report Bug Copy Issue Report The return type of `return new static();` (`voku\helper\SimpleHtmlDomBlank`) is incompatible with the return type declared by the interface `voku\helper\SimpleHtmlDomInterface::findOne` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
66			}
67
68			/**
69			* Find nodes with a CSS selector.
70			*
71			* @param string $selector
72			*
73			* @return SimpleHtmlDomNodeInterface
74			*/
75			public function findMulti(string $selector): SimpleHtmlDomNodeInterface
76			{
77			return new SimpleHtmlDomNodeBlank();
78			}
79
80			/**
81			* Returns the first child of node.
82			*
83			* @return null
84			*/
85			public function firstChild()
86			{
87			return null;
88			}
89
90			/**
91			* Returns an array of attributes.
92			*
93			* @return null
94			*/
95			public function getAllAttributes()
96			{
97			return null;
98			}
99
100			/**
101			* Return attribute value.
102			*
103			* @param string $name
104			*
105			* @return string
106			*/
107	2		public function getAttribute(string $name): string
108			{
109	2		return '';
110			}
111
112			/**
113			* Return element by #id.
114			*
115			* @param string $id
116			*
117			* @return SimpleHtmlDomInterface
118			*/
119			public function getElementById(string $id): SimpleHtmlDomInterface
120			{
121			return new static();
			0 ignored issues – show Bug Best Practice introduced 2019-04-25 23:06 UTC by Report Bug Copy Issue Report The return type of `return new static();` (`voku\helper\SimpleHtmlDomBlank`) is incompatible with the return type declared by the interface `voku\helper\SimpleHtmlDomInterface::getElementById` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
122			}
123
124			/**
125			* Returns elements by #id.
126			*
127			* @param string $id
128			* @param int\|null $idx
129			*
130			* @return SimpleHtmlDomNodeInterface
131			*/
132			public function getElementsById(string $id, $idx = null)
133			{
134			return new SimpleHtmlDomNodeBlank();
135			}
136
137			/**
138			* Return elements by .class.
139			*
140			* @param string $class
141			*
142			* @return SimpleHtmlDomNodeInterface
143			*/
144			public function getElementByClass(string $class): SimpleHtmlDomNodeInterface
145			{
146			return new SimpleHtmlDomNodeBlank();
147			}
148
149			/**
150			* Return element by tag name.
151			*
152			* @param string $name
153			*
154			* @return SimpleHtmlDomInterface
155			*/
156			public function getElementByTagName(string $name): SimpleHtmlDomInterface
157			{
158			return new static();
			0 ignored issues – show Bug Best Practice introduced 2019-04-25 23:06 UTC by Report Bug Copy Issue Report The return type of `return new static();` (`voku\helper\SimpleHtmlDomBlank`) is incompatible with the return type declared by the interface `voku\helper\SimpleHtmlDo...ce::getElementByTagName` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
159			}
160
161			/**
162			* Returns elements by tag name.
163			*
164			* @param string $name
165			* @param int\|null $idx
166			*
167			* @return SimpleHtmlDomNodeInterface
168			*/
169			public function getElementsByTagName(string $name, $idx = null)
170			{
171			return new SimpleHtmlDomNodeBlank();
172			}
173
174			/**
175			* Create a new "HtmlDomParser"-object from the current context.
176			*
177			* @return HtmlDomParser
178			*/
179			public function getHtmlDomParser(): HtmlDomParser
180			{
181			return new HtmlDomParser($this);
182			}
183
184			/**
185			* @return \DOMNode
186			*/
187			public function getNode(): \DOMNode
188			{
189			return new \DOMNode();
190			}
191
192			/**
193			* Determine if an attribute exists on the element.
194			*
195			* @param string $name
196			*
197			* @return bool
198			*/
199			public function hasAttribute(string $name): bool
200			{
201			return false;
202			}
203
204			/**
205			* Get dom node's outer html.
206			*
207			* @param bool $multiDecodeNewHtmlEntity
208			*
209			* @return string
210			*/
211	1		public function html(bool $multiDecodeNewHtmlEntity = false): string
212			{
213	1		return '';
214			}
215
216			/**
217			* Get dom node's inner html.
218			*
219			* @param bool $multiDecodeNewHtmlEntity
220			*
221			* @return string
222			*/
223	1		public function innerHtml(bool $multiDecodeNewHtmlEntity = false): string
224			{
225	1		return '';
226			}
227
228			/**
229			* Returns the last child of node.
230			*
231			* @return null
232			*/
233			public function lastChild()
234			{
235			return null;
236			}
237
238			/**
239			* Returns the next sibling of node.
240			*
241			* @return null
242			*/
243			public function nextSibling()
244			{
245			return null;
246			}
247
248			/**
249			* Returns the parent of node.
250			*
251			* @return SimpleHtmlDomInterface
252			*/
253			public function parentNode(): SimpleHtmlDomInterface
254			{
255			return new static();
			0 ignored issues – show Bug Best Practice introduced 2019-04-25 23:06 UTC by Report Bug Copy Issue Report The return type of `return new static();` (`voku\helper\SimpleHtmlDomBlank`) is incompatible with the return type declared by the interface `voku\helper\SimpleHtmlDomInterface::parentNode` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
256			}
257
258			/**
259			* Nodes can get partially destroyed in which they're still an
260			* actual DOM node (such as \DOMElement) but almost their entire
261			* body is gone, including the `nodeType` attribute.
262			*
263			* @return bool true if node has been destroyed
264			*/
265			public function isRemoved(): bool
266			{
267			return true;
268			}
269
270			/**
271			* Returns the previous sibling of node.
272			*
273			* @return null
274			*/
275			public function previousSibling()
276			{
277			return null;
278			}
279
280			/**
281			* Set attribute value.
282			*
283			* @param string $name <p>The name of the html-attribute.</p>
284			* @param string\|null $value <p>Set to NULL or empty string, to remove the attribute.</p>
285			* @param bool $strict </p>
286			* $value must be NULL, to remove the attribute,
287			* so that you can set an empty string as attribute-value e.g. autofocus=""
288			* </p>
289			*
290			* @return SimpleHtmlDomInterface
291			*/
292	1		public function setAttribute(string $name, $value = null, bool $strict = false): SimpleHtmlDomInterface
293			{
294	1		return $this;
			0 ignored issues – show Bug Best Practice introduced 2019-04-25 23:06 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`voku\helper\SimpleHtmlDomBlank`) is incompatible with the return type declared by the interface `voku\helper\SimpleHtmlDomInterface::setAttribute` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
295			}
296
297			/**
298			* @param string\|string[]\|null $value <p>
299			* null === get the current input value
300			* text === set a new input value
301			* </p>
302			*
303			* @return string\|string[]\|null
304			*/
305			public function val($value = null)
306			{
307			return null;
308			}
309
310			/**
311			* Remove attribute.
312			*
313			* @param string $name <p>The name of the html-attribute.</p>
314			*
315			* @return SimpleHtmlDomInterface
316			*/
317			public function removeAttribute(string $name): SimpleHtmlDomInterface
318			{
319			return $this;
			0 ignored issues – show Bug Best Practice introduced 2019-04-25 23:06 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`voku\helper\SimpleHtmlDomBlank`) is incompatible with the return type declared by the interface `voku\helper\SimpleHtmlDo...erface::removeAttribute` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
320			}
321
322			/**
323			* Get dom node's plain text.
324			*
325			* @return string
326			*/
327	3		public function text(): string
328			{
329	3		return '';
330			}
331
332			/**
333			* @param string $name
334			* @param array $arguments
335			*
336			* @throws \BadMethodCallException
337			*
338			* @return SimpleHtmlDomInterface\|string\|null
339			*/
340	1	View Code Duplication	public function __call($name, $arguments)
			0 ignored issues – show Duplication introduced 2019-04-25 23:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
341			{
342	1		$name = \strtolower($name);
343
344	1		if (isset(self::$functionAliases[$name])) {
345	1		return \call_user_func_array([$this, self::$functionAliases[$name]], $arguments);
346			}
347
348			throw new \BadMethodCallException('Method does not exist');
349			}
350
351			protected function replaceNodeWithString(string $string): SimpleHtmlDomInterface
352			{
353			return new static();
354			}
355
356	2		protected function replaceChildWithString(string $string): SimpleHtmlDomInterface
357			{
358	2		return new static();
359			}
360
361			protected function replaceTextWithString($string): SimpleHtmlDomInterface
362			{
363			return new static();
364			}
365			}
366

voku / simple_html_dom

Push — master ( 68d119...ebc63c )

SimpleHtmlDomBlank A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

31 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like