Completed
Push — master ( bdf6e4...92eb65 )
by Lars
01:56
created
src/voku/db/Debug.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -133,9 +133,9 @@  discard block
 block discarded – undo
133 133
     $this->logger(
134 134
         array(
135 135
             'error',
136
-            '<strong>' . date(
136
+            '<strong>'.date(
137 137
                 'd. m. Y G:i:s'
138
-            ) . ' (' . $fileInfo['file'] . ' line: ' . $fileInfo['line'] . ') (sql-error):</strong> ' . $error . '<br>',
138
+            ).' ('.$fileInfo['file'].' line: '.$fileInfo['line'].') (sql-error):</strong> '.$error.'<br>',
139 139
         )
140 140
     );
141 141
 
@@ -148,11 +148,11 @@  discard block
 block discarded – undo
148 148
         $box_bg = $this->css_mysql_box_bg;
149 149
 
150 150
         echo '
151
-        <div class="OBJ-mysql-box" style="border:' . $box_border . '; background:' . $box_bg . '; padding:10px; margin:10px;">
151
+        <div class="OBJ-mysql-box" style="border:' . $box_border.'; background:'.$box_bg.'; padding:10px; margin:10px;">
152 152
           <b style="font-size:14px;">MYSQL Error:</b>
153 153
           <code style="display:block;">
154
-            file / line: ' . $fileInfo['file'] . ' / ' . $fileInfo['line'] . '
155
-            ' . $error . '
154
+            file / line: ' . $fileInfo['file'].' / '.$fileInfo['line'].'
155
+            ' . $error.'
156 156
           </code>
157 157
         </div>
158 158
         ';
@@ -293,21 +293,21 @@  discard block
 block discarded – undo
293 293
     // get extra info
294 294
     $infoExtra = \mysqli_info($this->_db->getLink());
295 295
     if ($infoExtra) {
296
-      $infoExtra = ' | info => ' . $infoExtra;
296
+      $infoExtra = ' | info => '.$infoExtra;
297 297
     }
298 298
 
299 299
     //
300 300
     // logging
301 301
     //
302 302
 
303
-    $info = 'time => ' . round($duration, 5) . ' | results => ' . (int)$results . $infoExtra . ' | SQL => ' . UTF8::htmlentities($sql);
303
+    $info = 'time => '.round($duration, 5).' | results => '.(int)$results.$infoExtra.' | SQL => '.UTF8::htmlentities($sql);
304 304
 
305 305
     $fileInfo = $this->getFileAndLineFromSql();
306 306
 
307 307
     return $this->logger(
308 308
         array(
309 309
             $logLevel,
310
-            '<strong>' . date('d. m. Y G:i:s') . ' (' . $fileInfo['file'] . ' line: ' . $fileInfo['line'] . '):</strong> ' . $info . '<br>',
310
+            '<strong>'.date('d. m. Y G:i:s').' ('.$fileInfo['file'].' line: '.$fileInfo['line'].'):</strong> '.$info.'<br>',
311 311
             'sql',
312 312
         )
313 313
     );
@@ -373,21 +373,21 @@  discard block
 block discarded – undo
373 373
         $this->logger(
374 374
             array(
375 375
                 'debug',
376
-                $subject . ' | ' . $htmlBody,
376
+                $subject.' | '.$htmlBody,
377 377
             )
378 378
         );
379 379
       } elseif ($priority > 3) {
380 380
         $this->logger(
381 381
             array(
382 382
                 'error',
383
-                $subject . ' | ' . $htmlBody,
383
+                $subject.' | '.$htmlBody,
384 384
             )
385 385
         );
386 386
       } elseif ($priority < 3) {
387 387
         $this->logger(
388 388
             array(
389 389
                 'info',
390
-                $subject . ' | ' . $htmlBody,
390
+                $subject.' | '.$htmlBody,
391 391
             )
392 392
         );
393 393
       }
Please login to merge, or discard this patch.
src/voku/db/Helper.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -120,23 +120,23 @@  discard block
 block discarded – undo
120 120
 
121 121
     $whereSQL = $dbConnection->_parseArrayPair($whereArray, 'AND');
122 122
     if ($whereSQL) {
123
-      $whereSQL = 'AND ' . $whereSQL;
123
+      $whereSQL = 'AND '.$whereSQL;
124 124
     }
125 125
 
126 126
     if ($databaseName) {
127
-      $databaseName = $dbConnection->quote_string(trim($databaseName)) . '.';
127
+      $databaseName = $dbConnection->quote_string(trim($databaseName)).'.';
128 128
     }
129 129
 
130 130
     // get the row
131
-    $query = 'SELECT ' . $dbConnection->quote_string($searchFieldName) . ', ' . $dbConnection->quote_string($idFieldName) . ' 
132
-      FROM ' . $databaseName . $dbConnection->quote_string($table) . '
131
+    $query = 'SELECT '.$dbConnection->quote_string($searchFieldName).', '.$dbConnection->quote_string($idFieldName).' 
132
+      FROM ' . $databaseName.$dbConnection->quote_string($table).'
133 133
       WHERE 1 = 1
134
-      ' . $whereSQL . '
134
+      ' . $whereSQL.'
135 135
     ';
136 136
 
137 137
     if ($useCache === true) {
138 138
       $cache = new Cache(null, null, false, $useCache);
139
-      $cacheKey = 'sql-phonetic-search-' . md5($query);
139
+      $cacheKey = 'sql-phonetic-search-'.md5($query);
140 140
 
141 141
       if (
142 142
           $cache->getCacheIsReady() === true
@@ -266,10 +266,10 @@  discard block
 block discarded – undo
266 266
     }
267 267
 
268 268
     if ($databaseName) {
269
-      $databaseName = $dbConnection->quote_string(trim($databaseName)) . '.';
269
+      $databaseName = $dbConnection->quote_string(trim($databaseName)).'.';
270 270
     }
271 271
 
272
-    $sql = 'SHOW COLUMNS FROM ' . $databaseName . $dbConnection->escape($table);
272
+    $sql = 'SHOW COLUMNS FROM '.$databaseName.$dbConnection->escape($table);
273 273
     $result = $dbConnection->query($sql);
274 274
 
275 275
     if ($result && $result->num_rows > 0) {
@@ -315,17 +315,17 @@  discard block
 block discarded – undo
315 315
 
316 316
     $whereSQL = $dbConnection->_parseArrayPair($whereArray, 'AND');
317 317
     if ($whereSQL) {
318
-      $whereSQL = 'AND ' . $whereSQL;
318
+      $whereSQL = 'AND '.$whereSQL;
319 319
     }
320 320
 
321 321
     if ($databaseName) {
322
-      $databaseName = $dbConnection->quote_string(trim($databaseName)) . '.';
322
+      $databaseName = $dbConnection->quote_string(trim($databaseName)).'.';
323 323
     }
324 324
 
325 325
     // get the row
326
-    $query = 'SELECT * FROM ' . $databaseName . $dbConnection->quote_string($table) . '
326
+    $query = 'SELECT * FROM '.$databaseName.$dbConnection->quote_string($table).'
327 327
       WHERE 1 = 1
328
-      ' . $whereSQL . '
328
+      ' . $whereSQL.'
329 329
     ';
330 330
     $result = $dbConnection->query($query);
331 331
 
@@ -345,11 +345,11 @@  discard block
 block discarded – undo
345 345
 
346 346
           if (!in_array($fieldName, $ignoreArray, true)) {
347 347
             if (array_key_exists($fieldName, $updateArray)) {
348
-              $insert_keys .= ',' . $fieldName;
348
+              $insert_keys .= ','.$fieldName;
349 349
               $insert_values .= ',?';
350 350
               $bindings[] = $updateArray[$fieldName]; // INFO: do not escape non selected data
351 351
             } else {
352
-              $insert_keys .= ',' . $fieldName;
352
+              $insert_keys .= ','.$fieldName;
353 353
               $insert_values .= ',?';
354 354
               $bindings[] = $value; // INFO: do not escape non selected data
355 355
             }
@@ -360,10 +360,10 @@  discard block
 block discarded – undo
360 360
         $insert_values = ltrim($insert_values, ',');
361 361
 
362 362
         // insert the "copied" row
363
-        $new_query = 'INSERT INTO ' . $databaseName . $dbConnection->quote_string($table) . ' 
364
-          (' . $insert_keys . ')
363
+        $new_query = 'INSERT INTO '.$databaseName.$dbConnection->quote_string($table).' 
364
+          (' . $insert_keys.')
365 365
           VALUES 
366
-          (' . $insert_values . ')
366
+          (' . $insert_values.')
367 367
         ';
368 368
         return $dbConnection->query($new_query, $bindings);
369 369
       }
Please login to merge, or discard this patch.
src/voku/db/Prepare.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
     foreach ($this->_boundParams as $param) {
83 83
       $arguments[0] .= $param['type'];
84
-      $arguments[] =& $param['value'];
84
+      $arguments[] = & $param['value'];
85 85
     }
86 86
 
87 87
     return $arguments;
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     $value = $this->_db->escape($value);
105 105
 
106 106
     if ($type === 's') {
107
-      $valueForSqlWithBoundParameters = "'" . $value . "'";
107
+      $valueForSqlWithBoundParameters = "'".$value."'";
108 108
     } elseif ($type === 'i') {
109 109
       $valueForSqlWithBoundParameters = (int)$value;
110 110
     } elseif ($type === 'd') {
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
       $trace = debug_backtrace();
186 186
     }
187 187
 
188
-    $args =& $trace[0]['args'];
188
+    $args = & $trace[0]['args'];
189 189
     $types = str_split($types);
190 190
 
191 191
     $args_count = count($args) - 1;
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 
200 200
     $arg = 1;
201 201
     foreach ($types as $typeInner) {
202
-      $val =& $args[$arg];
202
+      $val = & $args[$arg];
203 203
       $this->_boundParams[] = array(
204 204
           'type'  => $typeInner,
205 205
           'value' => &$val,
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
     $bool = parent::prepare($query);
336 336
 
337 337
     if ($bool === false) {
338
-      $this->_debug->displayError('Can not prepare query: ' . $query . ' | ' . $this->error, false);
338
+      $this->_debug->displayError('Can not prepare query: '.$query.' | '.$this->error, false);
339 339
     }
340 340
 
341 341
     return $bool;
@@ -423,11 +423,11 @@  discard block
 block discarded – undo
423 423
 
424 424
       // exit if we have more then 3 "DB server has gone away"-errors
425 425
       if ($RECONNECT_COUNTER > 3) {
426
-        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMsg . ":\n<br />" . $sql, 5);
426
+        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMsg.":\n<br />".$sql, 5);
427 427
         throw new DBGoneAwayException($errorMsg);
428 428
       }
429 429
 
430
-      $this->_debug->mailToAdmin('DB-Error', $errorMsg . ":\n<br />" . $sql);
430
+      $this->_debug->mailToAdmin('DB-Error', $errorMsg.":\n<br />".$sql);
431 431
 
432 432
       // reconnect
433 433
       $RECONNECT_COUNTER++;
@@ -437,10 +437,10 @@  discard block
 block discarded – undo
437 437
       return $this->execute();
438 438
     }
439 439
 
440
-    $this->_debug->mailToAdmin('SQL-Error', $errorMsg . ":\n<br />" . $sql);
440
+    $this->_debug->mailToAdmin('SQL-Error', $errorMsg.":\n<br />".$sql);
441 441
 
442 442
     // this query returned an error, we must display it (only for dev) !!!
443
-    $this->_debug->displayError($errorMsg . ' | ' . $sql);
443
+    $this->_debug->displayError($errorMsg.' | '.$sql);
444 444
 
445 445
     return false;
446 446
   }
Please login to merge, or discard this patch.
src/voku/db/Result.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -622,7 +622,7 @@  discard block
 block discarded – undo
622 622
   {
623 623
     if ($as_array) {
624 624
       return array_map(
625
-          function ($object) {
625
+          function($object) {
626 626
             return (array)$object;
627 627
           },
628 628
           \mysqli_fetch_fields($this->_result)
@@ -734,7 +734,7 @@  discard block
 block discarded – undo
734 734
     }
735 735
 
736 736
     return array_map(
737
-        function ($values) use ($keys) {
737
+        function($values) use ($keys) {
738 738
           return array_combine($keys, $values);
739 739
         }, $rows
740 740
     );
Please login to merge, or discard this patch.
src/voku/db/DB.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -416,9 +416,9 @@  discard block
 block discarded – undo
416 416
         }
417 417
 
418 418
         if ($_connector === 'NOT IN' || $_connector === 'IN') {
419
-          $_value = '(' . implode(',', $_value) . ')';
419
+          $_value = '('.implode(',', $_value).')';
420 420
         } elseif ($_connector === 'NOT BETWEEN' || $_connector === 'BETWEEN') {
421
-          $_value = '(' . implode(' AND ', $_value) . ')';
421
+          $_value = '('.implode(' AND ', $_value).')';
422 422
         }
423 423
 
424 424
       } else {
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
           $_glueHelperInner = 'AND ('; // inner-loop "OR"-query glue
464 464
         }
465 465
 
466
-        $sql .= ' ' . $_glueHelperInner . ' ' . $quoteString . ' ' . $_connector . ' ' . $valueInner . " \n";
466
+        $sql .= ' '.$_glueHelperInner.' '.$quoteString.' '.$_connector.' '.$valueInner." \n";
467 467
         $tmpCounter++;
468 468
       }
469 469
 
@@ -637,7 +637,7 @@  discard block
 block discarded – undo
637 637
       );
638 638
 
639 639
     } catch (\Exception $e) {
640
-      $error = 'Error connecting to mysql server: ' . $e->getMessage();
640
+      $error = 'Error connecting to mysql server: '.$e->getMessage();
641 641
       $this->_debug->displayError($error, false);
642 642
       throw new DBConnectException($error, 100, $e);
643 643
     }
@@ -645,7 +645,7 @@  discard block
 block discarded – undo
645 645
 
646 646
     $errno = mysqli_connect_errno();
647 647
     if (!$this->connected || $errno) {
648
-      $error = 'Error connecting to mysql server: ' . \mysqli_connect_error() . ' (' . $errno . ')';
648
+      $error = 'Error connecting to mysql server: '.\mysqli_connect_error().' ('.$errno.')';
649 649
       $this->_debug->displayError($error, false);
650 650
       throw new DBConnectException($error, 101);
651 651
     }
@@ -686,10 +686,10 @@  discard block
 block discarded – undo
686 686
     }
687 687
 
688 688
     if ($databaseName) {
689
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
689
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
690 690
     }
691 691
 
692
-    $sql = 'DELETE FROM ' . $databaseName . $this->quote_string($table) . " WHERE ($WHERE);";
692
+    $sql = 'DELETE FROM '.$databaseName.$this->quote_string($table)." WHERE ($WHERE);";
693 693
 
694 694
     return $this->query($sql);
695 695
   }
@@ -881,7 +881,7 @@  discard block
 block discarded – undo
881 881
 
882 882
     if ($useCache === true) {
883 883
       $cache = new Cache(null, null, false, $useCache);
884
-      $cacheKey = 'sql-' . md5($query);
884
+      $cacheKey = 'sql-'.md5($query);
885 885
 
886 886
       if (
887 887
           $cache->getCacheIsReady() === true
@@ -989,7 +989,7 @@  discard block
 block discarded – undo
989 989
     static $firstInstance = null;
990 990
 
991 991
     if (
992
-        $hostname . $username . $password . $database . $port . $charset == ''
992
+        $hostname.$username.$password.$database.$port.$charset == ''
993 993
         &&
994 994
         null !== $firstInstance
995 995
     ) {
@@ -999,7 +999,7 @@  discard block
 block discarded – undo
999 999
     $extra_config_string = '';
1000 1000
     if (is_array($extra_config) === true) {
1001 1001
       foreach ($extra_config as $extra_config_key => $extra_config_value) {
1002
-        $extra_config_string .= $extra_config_key . (string)$extra_config_value;
1002
+        $extra_config_string .= $extra_config_key.(string)$extra_config_value;
1003 1003
       }
1004 1004
     } else {
1005 1005
       // only for backward compatibility
@@ -1007,7 +1007,7 @@  discard block
 block discarded – undo
1007 1007
     }
1008 1008
 
1009 1009
     $connection = md5(
1010
-        $hostname . $username . $password . $database . $port . $charset . (int)$exit_on_error . (int)$echo_on_error . $logger_class_name . $logger_level . $extra_config_string
1010
+        $hostname.$username.$password.$database.$port.$charset.(int)$exit_on_error.(int)$echo_on_error.$logger_class_name.$logger_level.$extra_config_string
1011 1011
     );
1012 1012
 
1013 1013
     if (!isset($instance[$connection])) {
@@ -1094,10 +1094,10 @@  discard block
 block discarded – undo
1094 1094
     $SET = $this->_parseArrayPair($data);
1095 1095
 
1096 1096
     if ($databaseName) {
1097
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1097
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1098 1098
     }
1099 1099
 
1100
-    $sql = 'INSERT INTO ' . $databaseName . $this->quote_string($table) . " SET $SET;";
1100
+    $sql = 'INSERT INTO '.$databaseName.$this->quote_string($table)." SET $SET;";
1101 1101
 
1102 1102
     return $this->query($sql);
1103 1103
   }
@@ -1419,11 +1419,11 @@  discard block
 block discarded – undo
1419 1419
 
1420 1420
       // exit if we have more then 3 "DB server has gone away"-errors
1421 1421
       if ($RECONNECT_COUNTER > 3) {
1422
-        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMessage . '(' . $errorNumber. ') ' . ":\n<br />" . $sql, 5);
1422
+        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMessage.'('.$errorNumber.') '.":\n<br />".$sql, 5);
1423 1423
         throw new DBGoneAwayException($errorMessage);
1424 1424
       }
1425 1425
 
1426
-      $this->_debug->mailToAdmin('DB-Error', $errorMessage . '(' . $errorNumber. ') ' . ":\n<br />" . $sql);
1426
+      $this->_debug->mailToAdmin('DB-Error', $errorMessage.'('.$errorNumber.') '.":\n<br />".$sql);
1427 1427
 
1428 1428
       // reconnect
1429 1429
       $RECONNECT_COUNTER++;
@@ -1437,10 +1437,10 @@  discard block
 block discarded – undo
1437 1437
       return false;
1438 1438
     }
1439 1439
 
1440
-    $this->_debug->mailToAdmin('SQL-Error', $errorMessage . '(' . $errorNumber. ') ' . ":\n<br />" . $sql);
1440
+    $this->_debug->mailToAdmin('SQL-Error', $errorMessage.'('.$errorNumber.') '.":\n<br />".$sql);
1441 1441
 
1442 1442
     // this query returned an error, we must display it (only for dev) !!!
1443
-    $this->_debug->displayError($errorMessage . '(' . $errorNumber. ') ' . ' | ' . $sql);
1443
+    $this->_debug->displayError($errorMessage.'('.$errorNumber.') '.' | '.$sql);
1444 1444
 
1445 1445
     return false;
1446 1446
   }
@@ -1463,7 +1463,7 @@  discard block
 block discarded – undo
1463 1463
         )
1464 1464
     );
1465 1465
 
1466
-    return '`' . $str . '`';
1466
+    return '`'.$str.'`';
1467 1467
   }
1468 1468
 
1469 1469
   /**
@@ -1534,10 +1534,10 @@  discard block
 block discarded – undo
1534 1534
     $values = implode(',', $data);
1535 1535
 
1536 1536
     if ($databaseName) {
1537
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1537
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1538 1538
     }
1539 1539
 
1540
-    $sql = 'REPLACE INTO ' . $databaseName . $this->quote_string($table) . " ($columns) VALUES ($values);";
1540
+    $sql = 'REPLACE INTO '.$databaseName.$this->quote_string($table)." ($columns) VALUES ($values);";
1541 1541
 
1542 1542
     return $this->query($sql);
1543 1543
   }
@@ -1661,7 +1661,7 @@  discard block
 block discarded – undo
1661 1661
     $var = $this->escape($var, false, false, null);
1662 1662
 
1663 1663
     if (is_string($var)) {
1664
-      $var = "'" . trim($var, "'") . "'";
1664
+      $var = "'".trim($var, "'")."'";
1665 1665
     }
1666 1666
 
1667 1667
     return $var;
@@ -1698,10 +1698,10 @@  discard block
 block discarded – undo
1698 1698
     }
1699 1699
 
1700 1700
     if ($databaseName) {
1701
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1701
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1702 1702
     }
1703 1703
 
1704
-    $sql = 'SELECT * FROM ' . $databaseName . $this->quote_string($table) . " WHERE ($WHERE);";
1704
+    $sql = 'SELECT * FROM '.$databaseName.$this->quote_string($table)." WHERE ($WHERE);";
1705 1705
 
1706 1706
     return $this->query($sql);
1707 1707
   }
@@ -1728,10 +1728,10 @@  discard block
 block discarded – undo
1728 1728
     $return = mysqli_set_charset($this->link, $charset);
1729 1729
     /** @noinspection PhpUsageOfSilenceOperatorInspection */
1730 1730
     /** @noinspection UsageOfSilenceOperatorInspection */
1731
-    @\mysqli_query($this->link, 'SET CHARACTER SET ' . $charset);
1731
+    @\mysqli_query($this->link, 'SET CHARACTER SET '.$charset);
1732 1732
     /** @noinspection PhpUsageOfSilenceOperatorInspection */
1733 1733
     /** @noinspection UsageOfSilenceOperatorInspection */
1734
-    @\mysqli_query($this->link, "SET NAMES '" . $charset . "'");
1734
+    @\mysqli_query($this->link, "SET NAMES '".$charset."'");
1735 1735
 
1736 1736
     return $return;
1737 1737
   }
@@ -1877,10 +1877,10 @@  discard block
 block discarded – undo
1877 1877
     }
1878 1878
 
1879 1879
     if ($databaseName) {
1880
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1880
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1881 1881
     }
1882 1882
 
1883
-    $sql = 'UPDATE ' . $databaseName . $this->quote_string($table) . " SET $SET WHERE ($WHERE);";
1883
+    $sql = 'UPDATE '.$databaseName.$this->quote_string($table)." SET $SET WHERE ($WHERE);";
1884 1884
 
1885 1885
     return $this->query($sql);
1886 1886
   }
Please login to merge, or discard this patch.