Completed
Pull Request — master (#24)
by Lars
09:07
created
src/voku/db/Debug.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -133,9 +133,9 @@  discard block
 block discarded – undo
133 133
     $this->logger(
134 134
         array(
135 135
             'error',
136
-            '<strong>' . date(
136
+            '<strong>'.date(
137 137
                 'd. m. Y G:i:s'
138
-            ) . ' (' . $fileInfo['file'] . ' line: ' . $fileInfo['line'] . ') (sql-error):</strong> ' . $error . '<br>',
138
+            ).' ('.$fileInfo['file'].' line: '.$fileInfo['line'].') (sql-error):</strong> '.$error.'<br>',
139 139
         )
140 140
     );
141 141
 
@@ -148,11 +148,11 @@  discard block
 block discarded – undo
148 148
         $box_bg = $this->css_mysql_box_bg;
149 149
 
150 150
         echo '
151
-        <div class="OBJ-mysql-box" style="border:' . $box_border . '; background:' . $box_bg . '; padding:10px; margin:10px;">
151
+        <div class="OBJ-mysql-box" style="border:' . $box_border.'; background:'.$box_bg.'; padding:10px; margin:10px;">
152 152
           <b style="font-size:14px;">MYSQL Error:</b>
153 153
           <code style="display:block;">
154
-            file / line: ' . $fileInfo['file'] . ' / ' . $fileInfo['line'] . '
155
-            ' . $error . '
154
+            file / line: ' . $fileInfo['file'].' / '.$fileInfo['line'].'
155
+            ' . $error.'
156 156
           </code>
157 157
         </div>
158 158
         ';
@@ -293,21 +293,21 @@  discard block
 block discarded – undo
293 293
     // get extra info
294 294
     $infoExtra = \mysqli_info($this->_db->getLink());
295 295
     if ($infoExtra) {
296
-      $infoExtra = ' | info => ' . $infoExtra;
296
+      $infoExtra = ' | info => '.$infoExtra;
297 297
     }
298 298
 
299 299
     //
300 300
     // logging
301 301
     //
302 302
 
303
-    $info = 'time => ' . round($duration, 5) . ' | results => ' . (int)$results . $infoExtra . ' | SQL => ' . UTF8::htmlentities($sql);
303
+    $info = 'time => '.round($duration, 5).' | results => '.(int)$results.$infoExtra.' | SQL => '.UTF8::htmlentities($sql);
304 304
 
305 305
     $fileInfo = $this->getFileAndLineFromSql();
306 306
 
307 307
     return $this->logger(
308 308
         array(
309 309
             $logLevel,
310
-            '<strong>' . date('d. m. Y G:i:s') . ' (' . $fileInfo['file'] . ' line: ' . $fileInfo['line'] . '):</strong> ' . $info . '<br>',
310
+            '<strong>'.date('d. m. Y G:i:s').' ('.$fileInfo['file'].' line: '.$fileInfo['line'].'):</strong> '.$info.'<br>',
311 311
             'sql',
312 312
         )
313 313
     );
@@ -373,21 +373,21 @@  discard block
 block discarded – undo
373 373
         $this->logger(
374 374
             array(
375 375
                 'debug',
376
-                $subject . ' | ' . $htmlBody,
376
+                $subject.' | '.$htmlBody,
377 377
             )
378 378
         );
379 379
       } elseif ($priority > 3) {
380 380
         $this->logger(
381 381
             array(
382 382
                 'error',
383
-                $subject . ' | ' . $htmlBody,
383
+                $subject.' | '.$htmlBody,
384 384
             )
385 385
         );
386 386
       } elseif ($priority < 3) {
387 387
         $this->logger(
388 388
             array(
389 389
                 'info',
390
-                $subject . ' | ' . $htmlBody,
390
+                $subject.' | '.$htmlBody,
391 391
             )
392 392
         );
393 393
       }
Please login to merge, or discard this patch.
src/voku/db/Helper.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -120,23 +120,23 @@  discard block
 block discarded – undo
120 120
 
121 121
     $whereSQL = $dbConnection->_parseArrayPair($whereArray, 'AND');
122 122
     if ($whereSQL) {
123
-      $whereSQL = 'AND ' . $whereSQL;
123
+      $whereSQL = 'AND '.$whereSQL;
124 124
     }
125 125
 
126 126
     if ($databaseName) {
127
-      $databaseName = $dbConnection->quote_string(trim($databaseName)) . '.';
127
+      $databaseName = $dbConnection->quote_string(trim($databaseName)).'.';
128 128
     }
129 129
 
130 130
     // get the row
131
-    $query = 'SELECT ' . $dbConnection->quote_string($searchFieldName) . ', ' . $dbConnection->quote_string($idFieldName) . ' 
132
-      FROM ' . $databaseName . $dbConnection->quote_string($table) . '
131
+    $query = 'SELECT '.$dbConnection->quote_string($searchFieldName).', '.$dbConnection->quote_string($idFieldName).' 
132
+      FROM ' . $databaseName.$dbConnection->quote_string($table).'
133 133
       WHERE 1 = 1
134
-      ' . $whereSQL . '
134
+      ' . $whereSQL.'
135 135
     ';
136 136
 
137 137
     if ($useCache === true) {
138 138
       $cache = new Cache(null, null, false, $useCache);
139
-      $cacheKey = 'sql-phonetic-search-' . md5($query);
139
+      $cacheKey = 'sql-phonetic-search-'.md5($query);
140 140
 
141 141
       if (
142 142
           $cache->getCacheIsReady() === true
@@ -266,10 +266,10 @@  discard block
 block discarded – undo
266 266
     }
267 267
 
268 268
     if ($databaseName) {
269
-      $databaseName = $dbConnection->quote_string(trim($databaseName)) . '.';
269
+      $databaseName = $dbConnection->quote_string(trim($databaseName)).'.';
270 270
     }
271 271
 
272
-    $sql = 'SHOW COLUMNS FROM ' . $databaseName . $dbConnection->escape($table);
272
+    $sql = 'SHOW COLUMNS FROM '.$databaseName.$dbConnection->escape($table);
273 273
     $result = $dbConnection->query($sql);
274 274
 
275 275
     if ($result && $result->num_rows > 0) {
@@ -315,17 +315,17 @@  discard block
 block discarded – undo
315 315
 
316 316
     $whereSQL = $dbConnection->_parseArrayPair($whereArray, 'AND');
317 317
     if ($whereSQL) {
318
-      $whereSQL = 'AND ' . $whereSQL;
318
+      $whereSQL = 'AND '.$whereSQL;
319 319
     }
320 320
 
321 321
     if ($databaseName) {
322
-      $databaseName = $dbConnection->quote_string(trim($databaseName)) . '.';
322
+      $databaseName = $dbConnection->quote_string(trim($databaseName)).'.';
323 323
     }
324 324
 
325 325
     // get the row
326
-    $query = 'SELECT * FROM ' . $databaseName . $dbConnection->quote_string($table) . '
326
+    $query = 'SELECT * FROM '.$databaseName.$dbConnection->quote_string($table).'
327 327
       WHERE 1 = 1
328
-      ' . $whereSQL . '
328
+      ' . $whereSQL.'
329 329
     ';
330 330
     $result = $dbConnection->query($query);
331 331
 
@@ -345,11 +345,11 @@  discard block
 block discarded – undo
345 345
 
346 346
           if (!in_array($fieldName, $ignoreArray, true)) {
347 347
             if (array_key_exists($fieldName, $updateArray)) {
348
-              $insert_keys .= ',' . $fieldName;
348
+              $insert_keys .= ','.$fieldName;
349 349
               $insert_values .= ',?';
350 350
               $bindings[] = $updateArray[$fieldName]; // INFO: do not escape non selected data
351 351
             } else {
352
-              $insert_keys .= ',' . $fieldName;
352
+              $insert_keys .= ','.$fieldName;
353 353
               $insert_values .= ',?';
354 354
               $bindings[] = $value; // INFO: do not escape non selected data
355 355
             }
@@ -360,10 +360,10 @@  discard block
 block discarded – undo
360 360
         $insert_values = ltrim($insert_values, ',');
361 361
 
362 362
         // insert the "copied" row
363
-        $new_query = 'INSERT INTO ' . $databaseName . $dbConnection->quote_string($table) . ' 
364
-          (' . $insert_keys . ')
363
+        $new_query = 'INSERT INTO '.$databaseName.$dbConnection->quote_string($table).' 
364
+          (' . $insert_keys.')
365 365
           VALUES 
366
-          (' . $insert_values . ')
366
+          (' . $insert_values.')
367 367
         ';
368 368
         return $dbConnection->query($new_query, $bindings);
369 369
       }
Please login to merge, or discard this patch.
src/voku/db/Prepare.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
     foreach ($this->_boundParams as $param) {
83 83
       $arguments[0] .= $param['type'];
84
-      $arguments[] =& $param['value'];
84
+      $arguments[] = & $param['value'];
85 85
     }
86 86
 
87 87
     return $arguments;
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     $value = $this->_db->escape($value);
105 105
 
106 106
     if ($type === 's') {
107
-      $valueForSqlWithBoundParameters = "'" . $value . "'";
107
+      $valueForSqlWithBoundParameters = "'".$value."'";
108 108
     } elseif ($type === 'i') {
109 109
       $valueForSqlWithBoundParameters = (int)$value;
110 110
     } elseif ($type === 'd') {
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
       $trace = debug_backtrace();
186 186
     }
187 187
 
188
-    $args =& $trace[0]['args'];
188
+    $args = & $trace[0]['args'];
189 189
     $types = str_split($types);
190 190
 
191 191
     $args_count = count($args) - 1;
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 
200 200
     $arg = 1;
201 201
     foreach ($types as $typeInner) {
202
-      $val =& $args[$arg];
202
+      $val = & $args[$arg];
203 203
       $this->_boundParams[] = array(
204 204
           'type'  => $typeInner,
205 205
           'value' => &$val,
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
     $bool = parent::prepare($query);
336 336
 
337 337
     if ($bool === false) {
338
-      $this->_debug->displayError('Can not prepare query: ' . $query . ' | ' . $this->error, false);
338
+      $this->_debug->displayError('Can not prepare query: '.$query.' | '.$this->error, false);
339 339
     }
340 340
 
341 341
     return $bool;
@@ -423,11 +423,11 @@  discard block
 block discarded – undo
423 423
 
424 424
       // exit if we have more then 3 "DB server has gone away"-errors
425 425
       if ($RECONNECT_COUNTER > 3) {
426
-        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMsg . ":\n<br />" . $sql, 5);
426
+        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMsg.":\n<br />".$sql, 5);
427 427
         throw new DBGoneAwayException($errorMsg);
428 428
       }
429 429
 
430
-      $this->_debug->mailToAdmin('DB-Error', $errorMsg . ":\n<br />" . $sql);
430
+      $this->_debug->mailToAdmin('DB-Error', $errorMsg.":\n<br />".$sql);
431 431
 
432 432
       // reconnect
433 433
       $RECONNECT_COUNTER++;
@@ -437,10 +437,10 @@  discard block
 block discarded – undo
437 437
       return $this->execute();
438 438
     }
439 439
 
440
-    $this->_debug->mailToAdmin('SQL-Error', $errorMsg . ":\n<br />" . $sql);
440
+    $this->_debug->mailToAdmin('SQL-Error', $errorMsg.":\n<br />".$sql);
441 441
 
442 442
     // this query returned an error, we must display it (only for dev) !!!
443
-    $this->_debug->displayError($errorMsg . ' | ' . $sql);
443
+    $this->_debug->displayError($errorMsg.' | '.$sql);
444 444
 
445 445
     return false;
446 446
   }
Please login to merge, or discard this patch.
src/voku/db/DB.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -410,9 +410,9 @@  discard block
 block discarded – undo
410 410
         }
411 411
 
412 412
         if ($_connector === 'NOT IN' || $_connector === 'IN') {
413
-          $_value = '(' . implode(',', $_value) . ')';
413
+          $_value = '('.implode(',', $_value).')';
414 414
         } elseif ($_connector === 'NOT BETWEEN' || $_connector === 'BETWEEN') {
415
-          $_value = '(' . implode(' AND ', $_value) . ')';
415
+          $_value = '('.implode(' AND ', $_value).')';
416 416
         }
417 417
 
418 418
       } else {
@@ -457,7 +457,7 @@  discard block
 block discarded – undo
457 457
           $_glueHelperInner = 'AND ('; // inner-loop "OR"-query glue
458 458
         }
459 459
 
460
-        $sql .= ' ' . $_glueHelperInner . ' ' . $quoteString . ' ' . $_connector . ' ' . $valueInner . " \n";
460
+        $sql .= ' '.$_glueHelperInner.' '.$quoteString.' '.$_connector.' '.$valueInner." \n";
461 461
         $tmpCounter++;
462 462
       }
463 463
 
@@ -631,7 +631,7 @@  discard block
 block discarded – undo
631 631
       );
632 632
 
633 633
     } catch (\Exception $e) {
634
-      $error = 'Error connecting to mysql server: ' . $e->getMessage();
634
+      $error = 'Error connecting to mysql server: '.$e->getMessage();
635 635
       $this->_debug->displayError($error, false);
636 636
       throw new DBConnectException($error, 100, $e);
637 637
     }
@@ -639,7 +639,7 @@  discard block
 block discarded – undo
639 639
 
640 640
     $errno = mysqli_connect_errno();
641 641
     if (!$this->connected || $errno) {
642
-      $error = 'Error connecting to mysql server: ' . \mysqli_connect_error() . ' (' . $errno . ')';
642
+      $error = 'Error connecting to mysql server: '.\mysqli_connect_error().' ('.$errno.')';
643 643
       $this->_debug->displayError($error, false);
644 644
       /** @noinspection ThrowRawExceptionInspection */
645 645
       throw new DBConnectException($error, 101);
@@ -681,10 +681,10 @@  discard block
 block discarded – undo
681 681
     }
682 682
 
683 683
     if ($databaseName) {
684
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
684
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
685 685
     }
686 686
 
687
-    $sql = 'DELETE FROM ' . $databaseName . $this->quote_string($table) . " WHERE ($WHERE);";
687
+    $sql = 'DELETE FROM '.$databaseName.$this->quote_string($table)." WHERE ($WHERE);";
688 688
 
689 689
     return $this->query($sql);
690 690
   }
@@ -876,7 +876,7 @@  discard block
 block discarded – undo
876 876
 
877 877
     if ($useCache === true) {
878 878
       $cache = new Cache(null, null, false, $useCache);
879
-      $cacheKey = 'sql-' . md5($query);
879
+      $cacheKey = 'sql-'.md5($query);
880 880
 
881 881
       if (
882 882
           $cache->getCacheIsReady() === true
@@ -983,7 +983,7 @@  discard block
 block discarded – undo
983 983
     static $firstInstance = null;
984 984
 
985 985
     if (
986
-        $hostname . $username . $password . $database . $port . $charset == ''
986
+        $hostname.$username.$password.$database.$port.$charset == ''
987 987
         &&
988 988
         null !== $firstInstance
989 989
     ) {
@@ -993,7 +993,7 @@  discard block
 block discarded – undo
993 993
     $extra_config_string = '';
994 994
     if (is_array($extra_config) === true) {
995 995
       foreach ($extra_config as $extra_config_key => $extra_config_value) {
996
-        $extra_config_string .= $extra_config_key . (string)$extra_config_value;
996
+        $extra_config_string .= $extra_config_key.(string)$extra_config_value;
997 997
       }
998 998
     } else {
999 999
       // only for backward compatibility
@@ -1001,7 +1001,7 @@  discard block
 block discarded – undo
1001 1001
     }
1002 1002
 
1003 1003
     $connection = md5(
1004
-        $hostname . $username . $password . $database . $port . $charset . (int)$exit_on_error . (int)$echo_on_error . $logger_class_name . $logger_level . $extra_config_string
1004
+        $hostname.$username.$password.$database.$port.$charset.(int)$exit_on_error.(int)$echo_on_error.$logger_class_name.$logger_level.$extra_config_string
1005 1005
     );
1006 1006
 
1007 1007
     if (!isset($instance[$connection])) {
@@ -1088,10 +1088,10 @@  discard block
 block discarded – undo
1088 1088
     $SET = $this->_parseArrayPair($data);
1089 1089
 
1090 1090
     if ($databaseName) {
1091
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1091
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1092 1092
     }
1093 1093
 
1094
-    $sql = 'INSERT INTO ' . $databaseName . $this->quote_string($table) . " SET $SET;";
1094
+    $sql = 'INSERT INTO '.$databaseName.$this->quote_string($table)." SET $SET;";
1095 1095
 
1096 1096
     return $this->query($sql);
1097 1097
   }
@@ -1417,11 +1417,11 @@  discard block
 block discarded – undo
1417 1417
 
1418 1418
       // exit if we have more then 3 "DB server has gone away"-errors
1419 1419
       if ($RECONNECT_COUNTER > 3) {
1420
-        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMessage . '(' . $errorNumber. ') ' . ":\n<br />" . $sql, 5);
1420
+        $this->_debug->mailToAdmin('DB-Fatal-Error', $errorMessage.'('.$errorNumber.') '.":\n<br />".$sql, 5);
1421 1421
         throw new DBGoneAwayException($errorMessage);
1422 1422
       }
1423 1423
 
1424
-      $this->_debug->mailToAdmin('DB-Error', $errorMessage . '(' . $errorNumber. ') ' . ":\n<br />" . $sql);
1424
+      $this->_debug->mailToAdmin('DB-Error', $errorMessage.'('.$errorNumber.') '.":\n<br />".$sql);
1425 1425
 
1426 1426
       // reconnect
1427 1427
       $RECONNECT_COUNTER++;
@@ -1435,10 +1435,10 @@  discard block
 block discarded – undo
1435 1435
       return false;
1436 1436
     }
1437 1437
 
1438
-    $this->_debug->mailToAdmin('SQL-Error', $errorMessage . '(' . $errorNumber. ') ' . ":\n<br />" . $sql);
1438
+    $this->_debug->mailToAdmin('SQL-Error', $errorMessage.'('.$errorNumber.') '.":\n<br />".$sql);
1439 1439
 
1440 1440
     // this query returned an error, we must display it (only for dev) !!!
1441
-    $this->_debug->displayError($errorMessage . '(' . $errorNumber. ') ' . ' | ' . $sql);
1441
+    $this->_debug->displayError($errorMessage.'('.$errorNumber.') '.' | '.$sql);
1442 1442
 
1443 1443
     return false;
1444 1444
   }
@@ -1461,7 +1461,7 @@  discard block
 block discarded – undo
1461 1461
         )
1462 1462
     );
1463 1463
 
1464
-    return '`' . $str . '`';
1464
+    return '`'.$str.'`';
1465 1465
   }
1466 1466
 
1467 1467
   /**
@@ -1532,10 +1532,10 @@  discard block
 block discarded – undo
1532 1532
     $values = implode(',', $data);
1533 1533
 
1534 1534
     if ($databaseName) {
1535
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1535
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1536 1536
     }
1537 1537
 
1538
-    $sql = 'REPLACE INTO ' . $databaseName . $this->quote_string($table) . " ($columns) VALUES ($values);";
1538
+    $sql = 'REPLACE INTO '.$databaseName.$this->quote_string($table)." ($columns) VALUES ($values);";
1539 1539
 
1540 1540
     return $this->query($sql);
1541 1541
   }
@@ -1659,7 +1659,7 @@  discard block
 block discarded – undo
1659 1659
     $var = $this->escape($var, false, false, null);
1660 1660
 
1661 1661
     if (is_string($var)) {
1662
-      $var = "'" . trim($var, "'") . "'";
1662
+      $var = "'".trim($var, "'")."'";
1663 1663
     }
1664 1664
 
1665 1665
     return $var;
@@ -1696,10 +1696,10 @@  discard block
 block discarded – undo
1696 1696
     }
1697 1697
 
1698 1698
     if ($databaseName) {
1699
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1699
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1700 1700
     }
1701 1701
 
1702
-    $sql = 'SELECT * FROM ' . $databaseName . $this->quote_string($table) . " WHERE ($WHERE);";
1702
+    $sql = 'SELECT * FROM '.$databaseName.$this->quote_string($table)." WHERE ($WHERE);";
1703 1703
 
1704 1704
     return $this->query($sql);
1705 1705
   }
@@ -1726,10 +1726,10 @@  discard block
 block discarded – undo
1726 1726
     $return = mysqli_set_charset($this->link, $charset);
1727 1727
     /** @noinspection PhpUsageOfSilenceOperatorInspection */
1728 1728
     /** @noinspection UsageOfSilenceOperatorInspection */
1729
-    @\mysqli_query($this->link, 'SET CHARACTER SET ' . $charset);
1729
+    @\mysqli_query($this->link, 'SET CHARACTER SET '.$charset);
1730 1730
     /** @noinspection PhpUsageOfSilenceOperatorInspection */
1731 1731
     /** @noinspection UsageOfSilenceOperatorInspection */
1732
-    @\mysqli_query($this->link, "SET NAMES '" . $charset . "'");
1732
+    @\mysqli_query($this->link, "SET NAMES '".$charset."'");
1733 1733
 
1734 1734
     return $return;
1735 1735
   }
@@ -1875,10 +1875,10 @@  discard block
 block discarded – undo
1875 1875
     }
1876 1876
 
1877 1877
     if ($databaseName) {
1878
-      $databaseName = $this->quote_string(trim($databaseName)) . '.';
1878
+      $databaseName = $this->quote_string(trim($databaseName)).'.';
1879 1879
     }
1880 1880
 
1881
-    $sql = 'UPDATE ' . $databaseName . $this->quote_string($table) . " SET $SET WHERE ($WHERE);";
1881
+    $sql = 'UPDATE '.$databaseName.$this->quote_string($table)." SET $SET WHERE ($WHERE);";
1882 1882
 
1883 1883
     return $this->query($sql);
1884 1884
   }
Please login to merge, or discard this patch.
src/voku/db/Result.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -622,7 +622,7 @@  discard block
 block discarded – undo
622 622
   {
623 623
     if ($as_array) {
624 624
       return array_map(
625
-          function ($object) {
625
+          function($object) {
626 626
             return (array)$object;
627 627
           },
628 628
           \mysqli_fetch_fields($this->_result)
@@ -734,7 +734,7 @@  discard block
 block discarded – undo
734 734
     }
735 735
 
736 736
     return array_map(
737
-        function ($values) use ($keys) {
737
+        function($values) use ($keys) {
738 738
           return array_combine($keys, $values);
739 739
         }, $rows
740 740
     );
Please login to merge, or discard this patch.