Complex classes like Debug often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Debug, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class Debug |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * @var array |
||
| 19 | */ |
||
| 20 | private $_errors = []; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * @var bool |
||
| 24 | */ |
||
| 25 | private $exit_on_error = true; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * echo the error if "checkForDev()" returns true |
||
| 29 | * |
||
| 30 | * @var bool |
||
| 31 | */ |
||
| 32 | private $echo_on_error = true; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @var string |
||
| 36 | */ |
||
| 37 | private $css_mysql_box_border = '3px solid red'; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @var string |
||
| 41 | */ |
||
| 42 | private $css_mysql_box_bg = '#FFCCCC'; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var string |
||
| 46 | */ |
||
| 47 | private $logger_class_name; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var DB |
||
| 51 | */ |
||
| 52 | private $_db; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var string |
||
| 56 | * |
||
| 57 | * 'TRACE', 'DEBUG', 'INFO', 'WARN', 'ERROR', 'FATAL' |
||
| 58 | */ |
||
| 59 | private $logger_level; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Debug constructor. |
||
| 63 | * |
||
| 64 | * @param DB $db |
||
| 65 | */ |
||
| 66 | 65 | public function __construct(DB $db) |
|
| 70 | |||
| 71 | /** |
||
| 72 | * Check is the current user is a developer. |
||
| 73 | * |
||
| 74 | * INFO: |
||
| 75 | * By default we will return "true" if the remote-ip-address is localhost or |
||
| 76 | * if the script is called via CLI. But you can also overwrite this method or |
||
| 77 | * you can implement a global "checkForDev()"-function. |
||
| 78 | * |
||
| 79 | * @return bool |
||
| 80 | */ |
||
| 81 | 46 | public function checkForDev(): bool |
|
| 111 | |||
| 112 | /** |
||
| 113 | * Clear the errors in "$this->_errors". |
||
| 114 | * |
||
| 115 | * @return bool |
||
| 116 | */ |
||
| 117 | 12 | public function clearErrors(): bool |
|
| 123 | |||
| 124 | /** |
||
| 125 | * Display SQL-Errors or throw Exceptions (for dev). |
||
| 126 | * |
||
| 127 | * @param string $error <p>The error message.</p> |
||
| 128 | * @param null|boolean $force_exception_after_error <p> |
||
| 129 | * If you use default "null" here, then the behavior depends |
||
| 130 | * on "$this->exit_on_error (default: true)". |
||
| 131 | * </p> |
||
| 132 | * |
||
| 133 | * @throws QueryException |
||
| 134 | */ |
||
| 135 | 46 | public function displayError($error, $force_exception_after_error = null) |
|
| 136 | { |
||
| 137 | 46 | $fileInfo = $this->getFileAndLineFromSql(); |
|
| 138 | |||
| 139 | 46 | $this->logger( |
|
| 140 | [ |
||
| 141 | 46 | 'error', |
|
| 142 | 46 | '<strong>' . \date( |
|
| 143 | 46 | 'd. m. Y G:i:s' |
|
| 144 | 46 | ) . ' (' . $fileInfo['file'] . ' line: ' . $fileInfo['line'] . ') (sql-error):</strong> ' . $error . '<br>', |
|
| 145 | ] |
||
| 146 | ); |
||
| 147 | |||
| 148 | 46 | $this->_errors[] = $error; |
|
| 149 | |||
| 150 | 46 | if ($this->checkForDev() === true) { |
|
| 151 | 46 | if ($this->echo_on_error) { |
|
| 152 | 12 | $box_border = $this->css_mysql_box_border; |
|
| 153 | 12 | $box_bg = $this->css_mysql_box_bg; |
|
| 154 | |||
| 155 | echo ' |
||
| 156 | 12 | <div class="OBJ-mysql-box" style="border:' . $box_border . '; background:' . $box_bg . '; padding:10px; margin:10px;"> |
|
| 157 | <b style="font-size:14px;">MYSQL Error:</b> |
||
| 158 | <code style="display:block;"> |
||
| 159 | 12 | file / line: ' . $fileInfo['file'] . ' / ' . $fileInfo['line'] . ' |
|
| 160 | 12 | ' . $error . ' |
|
| 161 | </code> |
||
| 162 | </div> |
||
| 163 | '; |
||
| 164 | } |
||
| 165 | } |
||
| 166 | |||
| 167 | if ( |
||
| 168 | 46 | $force_exception_after_error === true |
|
| 169 | || |
||
| 170 | ( |
||
| 171 | 46 | $force_exception_after_error === null |
|
| 172 | && |
||
| 173 | 46 | $this->exit_on_error === true |
|
| 174 | ) |
||
| 175 | ) { |
||
| 176 | throw new QueryException($error); |
||
| 177 | } |
||
| 178 | 46 | } |
|
| 179 | |||
| 180 | /** |
||
| 181 | * Get errors from "$this->_errors". |
||
| 182 | * |
||
| 183 | * @return array |
||
| 184 | */ |
||
| 185 | 8 | public function getErrors(): array |
|
| 189 | |||
| 190 | /** |
||
| 191 | * Try to get the file & line from the current sql-query. |
||
| 192 | * |
||
| 193 | * @return array will return array['file'] and array['line'] |
||
| 194 | */ |
||
| 195 | 46 | private function getFileAndLineFromSql(): array |
|
| 234 | |||
| 235 | /** |
||
| 236 | * @return string |
||
| 237 | */ |
||
| 238 | public function getLoggerClassName(): string |
||
| 242 | |||
| 243 | /** |
||
| 244 | * @return string |
||
| 245 | */ |
||
| 246 | public function getLoggerLevel(): string |
||
| 250 | |||
| 251 | /** |
||
| 252 | * @return boolean |
||
| 253 | */ |
||
| 254 | public function isEchoOnError(): bool |
||
| 258 | |||
| 259 | /** |
||
| 260 | * @return boolean |
||
| 261 | */ |
||
| 262 | public function isExitOnError(): bool |
||
| 266 | |||
| 267 | /** |
||
| 268 | * Log the current query via "$this->logger". |
||
| 269 | * |
||
| 270 | * @param string $sql sql-query |
||
| 271 | * @param int $duration |
||
| 272 | * @param int $results field_count | insert_id | affected_rows |
||
| 273 | * @param bool $sql_error |
||
| 274 | * |
||
| 275 | * @return mixed <p>Will return false, if no logging was used.</p> |
||
| 276 | */ |
||
| 277 | 131 | public function logQuery($sql, $duration, $results, $sql_error = false) |
|
| 322 | |||
| 323 | /** |
||
| 324 | * Wrapper-Function for a "Logger"-Class. |
||
| 325 | * |
||
| 326 | * INFO: |
||
| 327 | * The "Logger"-ClassName is set by "$this->logger_class_name",<br /> |
||
| 328 | * the "Logger"-Method is the [0] element from the "$log"-parameter,<br /> |
||
| 329 | * the text you want to log is the [1] element and<br /> |
||
| 330 | * the type you want to log is the next [2] element. |
||
| 331 | * |
||
| 332 | * @param string[] $log [method, text, type]<br />e.g.: array('error', 'this is a error', 'sql') |
||
| 333 | * |
||
| 334 | * @return mixed <p>Will return false, if no logging was used.</p> |
||
| 335 | */ |
||
| 336 | 48 | public function logger(array $log) |
|
| 365 | |||
| 366 | /** |
||
| 367 | * Send a error mail to the admin / dev. |
||
| 368 | * |
||
| 369 | * @param string $subject |
||
| 370 | * @param string $htmlBody |
||
| 371 | * @param int $priority |
||
| 372 | */ |
||
| 373 | 28 | public function mailToAdmin($subject, $htmlBody, $priority = 3) |
|
| 404 | |||
| 405 | /** |
||
| 406 | * @param boolean $echo_on_error |
||
| 407 | */ |
||
| 408 | 65 | public function setEchoOnError($echo_on_error) |
|
| 412 | |||
| 413 | /** |
||
| 414 | * @param boolean $exit_on_error |
||
| 415 | */ |
||
| 416 | 65 | public function setExitOnError($exit_on_error) |
|
| 420 | |||
| 421 | /** |
||
| 422 | * @param string $logger_class_name |
||
| 423 | */ |
||
| 424 | 65 | public function setLoggerClassName($logger_class_name) |
|
| 428 | |||
| 429 | /** |
||
| 430 | * @param string $logger_level |
||
| 431 | */ |
||
| 432 | 65 | public function setLoggerLevel($logger_level) |
|
| 436 | |||
| 437 | } |
||
| 438 |