Completed
Push — master ( 14f1c2...1cc6cb )
by Lars
02:38
created
src/voku/db/DB.php 1 patch
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -295,12 +295,12 @@  discard block
 block discarded – undo
295 295
           $this->socket
296 296
       );
297 297
     } catch (\Exception $e) {
298
-      $this->_displayError('Error connecting to mysql server: ' . $e->getMessage(), true);
298
+      $this->_displayError('Error connecting to mysql server: '.$e->getMessage(), true);
299 299
     }
300 300
     mysqli_report(MYSQLI_REPORT_OFF);
301 301
 
302 302
     if (!$this->link) {
303
-      $this->_displayError('Error connecting to mysql server: ' . mysqli_connect_error(), true);
303
+      $this->_displayError('Error connecting to mysql server: '.mysqli_connect_error(), true);
304 304
     } else {
305 305
       $this->set_charset($this->charset);
306 306
       $this->connected = true;
@@ -334,9 +334,9 @@  discard block
 block discarded – undo
334 334
     $this->logger(
335 335
         array(
336 336
             'error',
337
-            '<strong>' . date(
337
+            '<strong>'.date(
338 338
                 'd. m. Y G:i:s'
339
-            ) . ' (' . $fileInfo['file'] . ' line: ' . $fileInfo['line'] . ') (sql-error):</strong> ' . $error . '<br>',
339
+            ).' ('.$fileInfo['file'].' line: '.$fileInfo['line'].') (sql-error):</strong> '.$error.'<br>',
340 340
         )
341 341
     );
342 342
 
@@ -349,11 +349,11 @@  discard block
 block discarded – undo
349 349
         $box_bg = $this->css_mysql_box_bg;
350 350
 
351 351
         echo '
352
-        <div class="OBJ-mysql-box" style="border:' . $box_border . '; background:' . $box_bg . '; padding:10px; margin:10px;">
352
+        <div class="OBJ-mysql-box" style="border:' . $box_border.'; background:'.$box_bg.'; padding:10px; margin:10px;">
353 353
           <b style="font-size:14px;">MYSQL Error:</b>
354 354
           <code style="display:block;">
355
-            file / line: ' . $fileInfo['file'] . ' / ' . $fileInfo['line'] . '
356
-            ' . $error . '
355
+            file / line: ' . $fileInfo['file'].' / '.$fileInfo['line'].'
356
+            ' . $error.'
357 357
           </code>
358 358
         </div>
359 359
         ';
@@ -566,7 +566,7 @@  discard block
 block discarded – undo
566 566
     static $firstInstance = null;
567 567
 
568 568
     if (
569
-        $hostname . $username . $password . $database . $port . $charset == ''
569
+        $hostname.$username.$password.$database.$port.$charset == ''
570 570
         &&
571 571
         null !== $firstInstance
572 572
     ) {
@@ -574,7 +574,7 @@  discard block
 block discarded – undo
574 574
     }
575 575
 
576 576
     $connection = md5(
577
-        $hostname . $username . $password . $database . $port . $charset . (int)$exit_on_error . (int)$echo_on_error . $logger_class_name . $logger_level . (int)$session_to_db
577
+        $hostname.$username.$password.$database.$port.$charset.(int)$exit_on_error.(int)$echo_on_error.$logger_class_name.$logger_level.(int)$session_to_db
578 578
     );
579 579
 
580 580
     if (!isset($instance[$connection])) {
@@ -751,7 +751,7 @@  discard block
 block discarded – undo
751 751
       // "string"
752 752
 
753 753
       if (!in_array($var, $this->mysqlDefaultTimeFunctions, true)) {
754
-        $var = "'" . trim($this->escape(trim(trim((string)$var), "'")), "'") . "'";
754
+        $var = "'".trim($this->escape(trim(trim((string)$var), "'")), "'")."'";
755 755
       }
756 756
 
757 757
     } elseif (is_float($var)) {
@@ -771,7 +771,7 @@  discard block
 block discarded – undo
771 771
       // "DateTime"-object
772 772
 
773 773
       try {
774
-        $var = "'" . $this->escape($var->format('Y-m-d H:i:s'), false, false) . "'";
774
+        $var = "'".$this->escape($var->format('Y-m-d H:i:s'), false, false)."'";
775 775
       } catch (\Exception $e) {
776 776
         $var = null;
777 777
       }
@@ -780,7 +780,7 @@  discard block
 block discarded – undo
780 780
 
781 781
       // fallback ...
782 782
 
783
-      $var = "'" . trim($this->escape(trim(trim((string)$var), "'")), "'") . "'";
783
+      $var = "'".trim($this->escape(trim(trim((string)$var), "'")), "'")."'";
784 784
 
785 785
     }
786 786
 
@@ -896,13 +896,13 @@  discard block
 block discarded – undo
896 896
       return false;
897 897
     }
898 898
 
899
-    $info = 'time => ' . round($duration, 5) . ' - ' . 'results => ' . $results . ' - ' . 'SQL => ' . UTF8::htmlentities($sql);
899
+    $info = 'time => '.round($duration, 5).' - '.'results => '.$results.' - '.'SQL => '.UTF8::htmlentities($sql);
900 900
     $fileInfo = $this->getFileAndLineFromSql();
901 901
 
902 902
     $this->logger(
903 903
         array(
904 904
             'debug',
905
-            '<strong>' . date('d. m. Y G:i:s') . ' (' . $fileInfo['file'] . ' line: ' . $fileInfo['line'] . '):</strong> ' . $info . '<br>',
905
+            '<strong>'.date('d. m. Y G:i:s').' ('.$fileInfo['file'].' line: '.$fileInfo['line'].'):</strong> '.$info.'<br>',
906 906
             'sql',
907 907
         )
908 908
     );
@@ -946,10 +946,10 @@  discard block
 block discarded – undo
946 946
 
947 947
       // exit if we have more then 3 "DB server has gone away"-errors
948 948
       if ($reconnectCounter > 3) {
949
-        $this->mailToAdmin('SQL-Fatal-Error', $errorMsg . ":\n<br />" . $sql, 5);
949
+        $this->mailToAdmin('SQL-Fatal-Error', $errorMsg.":\n<br />".$sql, 5);
950 950
         throw new \Exception($errorMsg);
951 951
       } else {
952
-        $this->mailToAdmin('SQL-Error', $errorMsg . ":\n<br />" . $sql);
952
+        $this->mailToAdmin('SQL-Error', $errorMsg.":\n<br />".$sql);
953 953
 
954 954
         // reconnect
955 955
         $reconnectCounter++;
@@ -959,10 +959,10 @@  discard block
 block discarded – undo
959 959
         $this->query($sql, $sqlParams);
960 960
       }
961 961
     } else {
962
-      $this->mailToAdmin('SQL-Warning', $errorMsg . ":\n<br />" . $sql);
962
+      $this->mailToAdmin('SQL-Warning', $errorMsg.":\n<br />".$sql);
963 963
 
964 964
       // this query returned an error, we must display it (only for dev) !!!
965
-      $this->_displayError($errorMsg . ' | ' . $sql);
965
+      $this->_displayError($errorMsg.' | '.$sql);
966 966
     }
967 967
   }
968 968
 
@@ -983,21 +983,21 @@  discard block
 block discarded – undo
983 983
         $this->logger(
984 984
             array(
985 985
                 'debug',
986
-                $subject . ' | ' . $htmlBody,
986
+                $subject.' | '.$htmlBody,
987 987
             )
988 988
         );
989 989
       } elseif ($priority > 3) {
990 990
         $this->logger(
991 991
             array(
992 992
                 'error',
993
-                $subject . ' | ' . $htmlBody,
993
+                $subject.' | '.$htmlBody,
994 994
             )
995 995
         );
996 996
       } elseif ($priority < 3) {
997 997
         $this->logger(
998 998
             array(
999 999
                 'info',
1000
-                $subject . ' | ' . $htmlBody,
1000
+                $subject.' | '.$htmlBody,
1001 1001
             )
1002 1002
         );
1003 1003
       }
@@ -1068,7 +1068,7 @@  discard block
 block discarded – undo
1068 1068
 
1069 1069
     if ($useCache === true) {
1070 1070
       $cache = new Cache(null, null, false, $useCache);
1071
-      $cacheKey = 'sql-' . md5($query);
1071
+      $cacheKey = 'sql-'.md5($query);
1072 1072
 
1073 1073
       if (
1074 1074
           $cache->getCacheIsReady() === true
@@ -1130,9 +1130,9 @@  discard block
 block discarded – undo
1130 1130
 
1131 1131
     $return = mysqli_set_charset($this->link, $charset);
1132 1132
     /** @noinspection PhpUsageOfSilenceOperatorInspection */
1133
-    @mysqli_query($this->link, 'SET CHARACTER SET ' . $charset);
1133
+    @mysqli_query($this->link, 'SET CHARACTER SET '.$charset);
1134 1134
     /** @noinspection PhpUsageOfSilenceOperatorInspection */
1135
-    @mysqli_query($this->link, "SET NAMES '" . ($charset == 'utf8' ? 'utf8mb4' : $charset) . "'");
1135
+    @mysqli_query($this->link, "SET NAMES '".($charset == 'utf8' ? 'utf8mb4' : $charset)."'");
1136 1136
 
1137 1137
     return $return;
1138 1138
   }
@@ -1223,10 +1223,10 @@  discard block
 block discarded – undo
1223 1223
 
1224 1224
       if ($this->checkForDev() === true) {
1225 1225
         echo "Info: maybe you have to increase your 'max_allowed_packet = 30M' in the config: 'my.conf' \n<br />";
1226
-        echo 'Error:' . $errorMsg;
1226
+        echo 'Error:'.$errorMsg;
1227 1227
       }
1228 1228
 
1229
-      $this->mailToAdmin('SQL-Error in mysqli_multi_query', $errorMsg . ":\n<br />" . $sql);
1229
+      $this->mailToAdmin('SQL-Error in mysqli_multi_query', $errorMsg.":\n<br />".$sql);
1230 1230
     }
1231 1231
 
1232 1232
     // return the result only if there was a "SELECT"-query
@@ -1263,7 +1263,7 @@  discard block
 block discarded – undo
1263 1263
 
1264 1264
       return false;
1265 1265
     } elseif (mysqli_connect_errno()) {
1266
-      $this->_displayError('Error connecting to mysql server: ' . mysqli_connect_error(), true);
1266
+      $this->_displayError('Error connecting to mysql server: '.mysqli_connect_error(), true);
1267 1267
 
1268 1268
       return false;
1269 1269
     } else {
@@ -1372,7 +1372,7 @@  discard block
 block discarded – undo
1372 1372
 
1373 1373
     $SET = $this->_parseArrayPair($data);
1374 1374
 
1375
-    $sql = 'INSERT INTO ' . $this->quote_string($table) . " SET $SET;";
1375
+    $sql = 'INSERT INTO '.$this->quote_string($table)." SET $SET;";
1376 1376
 
1377 1377
     return $this->query($sql);
1378 1378
   }
@@ -1466,7 +1466,7 @@  discard block
 block discarded – undo
1466 1466
             /** @noinspection AlterInForeachInspection */
1467 1467
             $_value[$oldKey] = $this->secure($oldValue);
1468 1468
           }
1469
-          $_value = '(' . implode(',', $_value) . ')';
1469
+          $_value = '('.implode(',', $_value).')';
1470 1470
         } elseif (
1471 1471
             is_array($_value)
1472 1472
             &&
@@ -1480,13 +1480,13 @@  discard block
 block discarded – undo
1480 1480
             /** @noinspection AlterInForeachInspection */
1481 1481
             $_value[$oldKey] = $this->secure($oldValue);
1482 1482
           }
1483
-          $_value = '(' . implode(' AND ', $_value) . ')';
1483
+          $_value = '('.implode(' AND ', $_value).')';
1484 1484
         } else {
1485 1485
           $_value = $this->secure($_value);
1486 1486
         }
1487 1487
 
1488 1488
         $quoteString = $this->quote_string(trim(str_ireplace($_connector, '', $_key)));
1489
-        $pairs[] = ' ' . $quoteString . ' ' . $_connector . ' ' . $_value . " \n";
1489
+        $pairs[] = ' '.$quoteString.' '.$_connector.' '.$_value." \n";
1490 1490
       }
1491 1491
 
1492 1492
       $sql = implode($glue, $pairs);
@@ -1504,7 +1504,7 @@  discard block
 block discarded – undo
1504 1504
    */
1505 1505
   public function quote_string($str)
1506 1506
   {
1507
-    return '`' . $this->escape($str, false, false) . '`';
1507
+    return '`'.$this->escape($str, false, false).'`';
1508 1508
   }
1509 1509
 
1510 1510
   /**
@@ -1558,7 +1558,7 @@  discard block
 block discarded – undo
1558 1558
     }
1559 1559
     $values = implode(',', $data);
1560 1560
 
1561
-    $sql = 'REPLACE INTO ' . $this->quote_string($table) . " ($columns) VALUES ($values);";
1561
+    $sql = 'REPLACE INTO '.$this->quote_string($table)." ($columns) VALUES ($values);";
1562 1562
 
1563 1563
     return $this->query($sql);
1564 1564
   }
@@ -1598,7 +1598,7 @@  discard block
 block discarded – undo
1598 1598
       $WHERE = '';
1599 1599
     }
1600 1600
 
1601
-    $sql = 'UPDATE ' . $this->quote_string($table) . " SET $SET WHERE ($WHERE);";
1601
+    $sql = 'UPDATE '.$this->quote_string($table)." SET $SET WHERE ($WHERE);";
1602 1602
 
1603 1603
     return $this->query($sql);
1604 1604
   }
@@ -1630,7 +1630,7 @@  discard block
 block discarded – undo
1630 1630
       $WHERE = '';
1631 1631
     }
1632 1632
 
1633
-    $sql = 'DELETE FROM ' . $this->quote_string($table) . " WHERE ($WHERE);";
1633
+    $sql = 'DELETE FROM '.$this->quote_string($table)." WHERE ($WHERE);";
1634 1634
 
1635 1635
     return $this->query($sql);
1636 1636
   }
@@ -1660,7 +1660,7 @@  discard block
 block discarded – undo
1660 1660
       $WHERE = '';
1661 1661
     }
1662 1662
 
1663
-    $sql = 'SELECT * FROM ' . $this->quote_string($table) . " WHERE ($WHERE);";
1663
+    $sql = 'SELECT * FROM '.$this->quote_string($table)." WHERE ($WHERE);";
1664 1664
 
1665 1665
     return $this->query($sql);
1666 1666
   }
Please login to merge, or discard this patch.
src/voku/db/Helper.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
     $dbFields = array();
36 36
     $db = DB::getInstance();
37 37
 
38
-    $sql = "SHOW COLUMNS FROM `" . $db->escape($table) . "`";
38
+    $sql = "SHOW COLUMNS FROM `".$db->escape($table)."`";
39 39
     $result = $db->query($sql);
40 40
 
41 41
     if ($result && $result->num_rows > 0) {
@@ -71,13 +71,13 @@  discard block
 block discarded – undo
71 71
     $table = $db->escape($table);
72 72
 
73 73
     foreach ($whereArray as $key => $value) {
74
-      $whereSQL = ' AND ' . $db->escape($key) . ' = ' . $db->escape($value);
74
+      $whereSQL = ' AND '.$db->escape($key).' = '.$db->escape($value);
75 75
     }
76 76
 
77 77
     // get the row
78
-    $query = "SELECT * FROM " . $table . "
78
+    $query = "SELECT * FROM ".$table."
79 79
       WHERE 1 = 1
80
-      " . $whereSQL . "
80
+      " . $whereSQL."
81 81
     ";
82 82
     $result = $db->query($query);
83 83
 
@@ -97,13 +97,13 @@  discard block
 block discarded – undo
97 97
             if (array_key_exists($fieldName, $updateArray)) {
98 98
 
99 99
               if ($updateArray[$fieldName] || $updateArray[$fieldName] == 0) {
100
-                $insert_keys .= ',' . $fieldName;
100
+                $insert_keys .= ','.$fieldName;
101 101
                 $insert_values .= ',?';
102 102
                 $bindings[] = $updateArray[$fieldName];
103 103
               }
104 104
 
105 105
             } else {
106
-              $insert_keys .= ',' . $fieldName;
106
+              $insert_keys .= ','.$fieldName;
107 107
               $insert_values .= ',?';
108 108
               $bindings[] = $value;
109 109
             }
@@ -111,8 +111,8 @@  discard block
 block discarded – undo
111 111
         }
112 112
 
113 113
         // insert the "copied" row
114
-        $new_query = "INSERT INTO `" . $table . "` (" . ltrim($insert_keys, ',') . ")
115
-          VALUES (" . ltrim($insert_values, ',') . ")
114
+        $new_query = "INSERT INTO `".$table."` (".ltrim($insert_keys, ',').")
115
+          VALUES (" . ltrim($insert_values, ',').")
116 116
         ";
117 117
         $return = $db->query($new_query, $bindings);
118 118
       }
Please login to merge, or discard this patch.