Purl\Parser

Complexity

Total Complexity

11

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

96.3%

Importance

Changes	10
Bugs	0	Features	3

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
C	parseUrl()	0	27	7
A	doParseUrl()	0	17	2

<?php

/*
 * This file is part of the Purl package, a project by Jonathan H. Wage.
 *
 * (c) 2013 Jonathan H. Wage
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Purl;

use Pdp\Parser as PslParser;

/**
 * Parser class.
 *
 * @author      Jonathan H. Wage <jonwage@gmail.com>
 */
class Parser implements ParserInterface
{

    /**
     * @var PslParser Public Suffix List parser
     */
    private static $pslParser = null;

    private static $defaultParts = array(
        'scheme'             => null,
        'host'               => null,
        'port'               => null,
        'user'               => null,
        'pass'               => null,
        'path'               => null,
        'query'              => null,
        'fragment'           => null,
        'publicSuffix'       => null,
        'registerableDomain' => null,
        'subdomain'          => null,
        'canonical'          => null,
        'resource'           => null
    );

    /**
     * Public constructor
     *
     * @param PslParser $pslParser Public Suffix List parser
     */
    public function __construct(PslParser $pslParser)
    {
        if (self::$pslParser === null) {
            self::$pslParser = $pslParser;
        }
    }

    /**
     * @inheritDoc
     */
    public function parseUrl($url)
    {
        $url = (string) $url;

        $parsedUrl = $this->doParseUrl($url);

        if ($parsedUrl === false) {
            throw new \InvalidArgumentException(sprintf('Invalid url %s', $url));
        }

        $parsedUrl = array_merge(self::$defaultParts, $parsedUrl);

        if (isset($parsedUrl['host'])) {
            $parsedUrl['publicSuffix'] = self::$pslParser->getPublicSuffix($parsedUrl['host']);
            $parsedUrl['registerableDomain'] = self::$pslParser->getRegistrableDomain($parsedUrl['host']);
            $parsedUrl['subdomain'] = self::$pslParser->getSubdomain($parsedUrl['host']);
            $parsedUrl['canonical'] = implode('.', array_reverse(explode('.', $parsedUrl['host']))).(isset($parsedUrl['path']) ? $parsedUrl['path'] : '').(isset($parsedUrl['query']) ? '?'.$parsedUrl['query'] : '');

            $parsedUrl['resource'] = isset($parsedUrl['path']) ? $parsedUrl['path'] : '';

            if (isset($parsedUrl['query'])) {
                $parsedUrl['resource'] .= '?'.$parsedUrl['query'];
            }
        }

        return $parsedUrl;
    }

    /**
     * @param string $url
     *
     * @return array $parsedUrl
     */
    protected function doParseUrl($url)
    {
        // If there's a single leading forward slash, use parse_url()
        // Expected matches:
        //
        // "/one/two"   YES
        // "/"          YES PLEASE
        // "//"         NO
        // "//one/two"  NO
        // ""           HELL NO
        if (preg_match('#^[\/]([^\/]|$)#', $url) === 1) {
            return parse_url($url);

The expression parse_url($url); of type array<string,string>|false adds false to the return on line 104 which is incompatible with the return type documented by Purl\Parser::doParseUrl of type array. It seems like you forgot to handle an error condition.

        } else {
            // Otherwise use the PSL parser
            return self::$pslParser->parseUrl($url)->toArray();
        }
    }
}