voku\helper\UTF8::substr_count()

Complexity

Conditions	12
Paths	66

Size

Total Lines	56
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	22
CRAP Score	12

Importance

Changes

0

<?php
  public static function substr_count($haystack, $needle, $offset = 0, $length = null, $encoding = 'UTF-8', $cleanUtf8 = false)
  {
    // init
    $haystack = (string)$haystack;
    $needle = (string)$needle;

    if (!isset($haystack[0], $needle[0])) {
      return false;
    }

    if ($offset || $length) {

The expression $length of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

      $offset = (int)$offset;
      $length = (int)$length;

      if (
          $length + $offset <= 0
          &&
          Bootup::is_php('7.1') === false
      ) {
        return false;
      }

      $haystack = self::substr($haystack, $offset, $length, $encoding);
    }

    if ($encoding !== 'UTF-8') {
      $encoding = self::normalize_encoding($encoding, 'UTF-8');
    }

    if ($cleanUtf8 === true) {
      // "\mb_strpos" and "\iconv_strpos" returns wrong position,
      // if invalid characters are found in $haystack before $needle
      $needle = self::clean($needle);
      $haystack = self::clean($haystack);

It seems like $haystack defined by self::clean($haystack) on line 6191 can also be of type false; however, voku\helper\UTF8::clean() does only seem to accept string, did you maybe forget to handle an error condition?

    }

    if (!isset(self::$SUPPORT['already_checked_via_portable_utf8'])) {
      self::checkForSupport();
    }

    if (
        $encoding !== 'UTF-8'
        &&
        self::$SUPPORT['mbstring'] === false
    ) {
      trigger_error('UTF8::substr_count() without mbstring cannot handle "' . $encoding . '" encoding', E_USER_WARNING);
    }

    if (self::$SUPPORT['mbstring'] === true) {
      return \mb_substr_count($haystack, $needle, $encoding);
    }

    preg_match_all('/' . preg_quote($needle, '/') . '/us', $haystack, $matches, PREG_SET_ORDER);

    return count($matches);
  }