SimpleAcl\Rule

Complexity

Total Complexity

43

Size/Duplication

Total Lines	341
Duplicated Lines	0 %

Coupling/Cohesion

Components	4
Dependencies	3

Test Coverage

Coverage

99.09%

Importance

Changes	22
Bugs	2	Features	10

22 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	resetAggregate()	0	14	3
A	getResourceAggregate()	0	4	1
A	setResourceAggregate()	0	4	1
A	getRoleAggregate()	0	4	1
A	setRoleAggregate()	0	4	1
A	getId()	0	4	1
A	setId()	0	8	2
B	getAction()	0	24	5
A	setAction()	0	4	1
D	isAllowed()	0	37	9
A	isRuleMatched()	0	4	1
A	getName()	0	4	1
A	setName()	0	4	1
A	getRole()	0	4	1
A	setRole()	0	4	1
A	getResource()	0	4	1
A	setResource()	0	4	1
B	match()	0	20	7
A	getPriority()	0	4	1
A	setPriority()	0	4	1
A	generateId()	0	6	1

<?php
namespace SimpleAcl;

use RecursiveIteratorIterator;
use SimpleAcl\Resource;
use SimpleAcl\Resource\ResourceAggregateInterface;
use SimpleAcl\Role;
use SimpleAcl\Role\RoleAggregateInterface;

/**
 * Used to connects Role and Resources together.
 *
 * @package SimpleAcl
 */
class Rule
{
  /**
   * Holds rule id.
   *
   * @var mixed
   */
  public $id;

  /**
   * Rule priority affect the order the rule is applied.
   *
   * @var int
   */
  protected $priority = 0;

  /**
   * Hold name of rule.
   *
   * @var string
   */
  protected $name;

  /**
   * Action used when determining is rule allow access to its Resource and Role.
   *
   * @var mixed
   */
  protected $action = false;

  /**
   * @var Role
   */
  protected $role;

  /**
   * @var Resource
   */
  protected $resource;

  /**
   * @var RoleAggregateInterface
   */
  protected $roleAggregate;

  /**
   * @var ResourceAggregateInterface
   */
  protected $resourceAggregate;

  /**
   * Create Rule with given name.
   *
   * @param $name
   */
  public function __construct($name)
  {
    $this->setId();
    $this->setName($name);
  }

  /**
   * Set aggregate objects.
   *
   * @param $roleAggregate
   * @param $resourceAggregate
   */
  public function resetAggregate($roleAggregate, $resourceAggregate)
  {
    if ($roleAggregate instanceof RoleAggregateInterface) {
      $this->setRoleAggregate($roleAggregate);
    } else {
      $this->roleAggregate = null;
    }

    if ($resourceAggregate instanceof ResourceAggregateInterface) {
      $this->setResourceAggregate($resourceAggregate);
    } else {
      $this->resourceAggregate = null;
    }
  }

  /**
   * @return ResourceAggregateInterface
   */
  public function getResourceAggregate()
  {
    return $this->resourceAggregate;
  }

  /**
   * @param ResourceAggregateInterface $resourceAggregate
   */
  public function setResourceAggregate(ResourceAggregateInterface $resourceAggregate)
  {
    $this->resourceAggregate = $resourceAggregate;
  }

  /**
   * @return RoleAggregateInterface
   */
  public function getRoleAggregate()
  {
    return $this->roleAggregate;
  }

  /**
   * @param RoleAggregateInterface $roleAggregate
   */
  public function setRoleAggregate(RoleAggregateInterface $roleAggregate)
  {
    $this->roleAggregate = $roleAggregate;
  }

  /**
   * @return mixed
   */
  public function getId()
  {
    return $this->id;
  }

  /**
   * @param mixed $id
   */
  public function setId($id = null)
  {
    if (null === $id) {
      $id = $this->generateId();
    }

    $this->id = $id;
  }

  /**
   * @param RuleResult|null $ruleResult
   *
   * @return bool|null
   */
  public function getAction(RuleResult $ruleResult = null)
  {
    $actionResult = $this->action;

    if (
        !is_callable($actionResult)
        ||
        null === $ruleResult
    ) {
      if (null !== $actionResult) {
        return (bool)$actionResult;
      } else {
        return null;
      }
    }

    $actionResult = call_user_func($this->action, $ruleResult);

    if (null !== $actionResult) {
      return (bool)$actionResult;
    } else {
      return null;
    }
  }

  /**
   * @param mixed $action
   */
  public function setAction($action)
  {
    $this->action = $action;
  }

  /**
   * Check owing Role & Resource and match its with $roleName & $resourceName;
   * if match was found depending on action allow or deny access to $resourceName for $roleName.
   *
   * @param        $needRuleName
   * @param string $needRoleName
   * @param string $needResourceName
   *
   * @return RuleResult|null null is returned if there is no matched Role & Resource in this rule.
   *                         RuleResult otherwise.
   */
  public function isAllowed($needRuleName, $needRoleName, $needResourceName)
  {
    if ($this->isRuleMatched($needRuleName)) {

      if (null !== $this->role) {
        $roles = iterator_to_array($this->role);
      } else {
        $roles = array(null);
      }

      if (null !== $this->resource) {
        $resources = iterator_to_array($this->getResource());
      } else {
        $resources = array(null);
      }

      $rolesDepth = 0;
      $resourceDepth = 0;
      
      foreach ($roles as $role) {
        $roleDepth = $role ? $rolesDepth++ : 0;

        foreach ($resources as $resource) {
          $resourceDepth = $resource ? $resourceDepth++ : 0;

          $depth = $roleDepth + $resourceDepth;
          $result = $this->match($role, $resource, $needRoleName, $needResourceName, -$depth);

Are you sure the assignment to $result is correct as $this->match($role, $resource, $needRoleName, $needResourceName, -$depth) (which targets SimpleAcl\Rule::match()) seems to always return null.

          if ($result) {
            return $result;
          }
        }
      }
    }

    return null;
  }

  /**
   * Check if rule can be used.
   *
   * @param $neeRuleName
   *
   * @return bool
   */
  protected function isRuleMatched($neeRuleName)
  {
    return $this->getName() === $neeRuleName;
  }

  /**
   * @return string
   */
  public function getName()
  {
    return $this->name;
  }

  /**
   * @param string $name
   */
  public function setName($name)
  {
    $this->name = $name;
  }

  /**
   * @return Role
   */
  public function getRole()
  {
    return $this->role;
  }

  /**
   * @param Role|null $role
   */
  public function setRole(Role $role = null)
  {
    $this->role = $role;
  }

  /**
   * @return \SimpleAcl\Resource
   */
  public function getResource()
  {
    return $this->resource;
  }

  /**
   * @param \SimpleAcl\Resource $resource
   */
  public function setResource(\SimpleAcl\Resource $resource = null)
  {
    $this->resource = $resource;
  }

  /**
   * Check if $role and $resource match to need role and resource.
   *
   * @param Role|null                $role
   * @param \SimpleAcl\Resource $resource
   * @param string                   $needRoleName
   * @param string                   $needResourceName
   * @param                          $priority
   *
   * @return RuleResult|null
   */
  protected function match(Role $role = null, \SimpleAcl\Resource $resource = null, $needRoleName, $needResourceName, $priority)
  {
    if (
        (
            null === $role
            ||
            ($role && $role->getName() === $needRoleName)
        )
        &&
        (
            null === $resource
            ||
            ($resource && $resource->getName() === $needResourceName)
        )
    ) {
      return new RuleResult($this, $priority, $needRoleName, $needResourceName);
    }

    return null;
  }

  /**
   * @return int
   */
  public function getPriority()
  {
    return $this->priority;
  }

  /**
   * @param int $priority
   */
  public function setPriority($priority)
  {
    $this->priority = $priority;
  }

  /**
   * Creates an id for rule.
   *
   * @return string
   */
  protected function generateId()
  {
    static $idCountRuleSimpleAcl = 1;

    return $idCountRuleSimpleAcl++;
  }
}