Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 30 | abstract class AbstractCollection extends Arrayy implements CollectionInterface |
||
| 31 | { |
||
| 32 | /** |
||
| 33 | * @var array |
||
| 34 | * @psalm-var array<T> |
||
| 35 | */ |
||
| 36 | protected $array = []; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var ArrayyRewindableGenerator|null |
||
| 40 | * @psalm-var \Arrayy\ArrayyRewindableGenerator<TKey,T>|null |
||
| 41 | */ |
||
| 42 | protected $generator; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var bool |
||
| 46 | */ |
||
| 47 | protected $checkPropertyTypes = true; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var bool |
||
| 51 | */ |
||
| 52 | protected $checkPropertiesMismatch = false; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var bool |
||
| 56 | */ |
||
| 57 | protected $checkForMissingPropertiesInConstructor = true; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * Constructs a collection object of the specified type, optionally with the |
||
| 61 | * specified data. |
||
| 62 | * |
||
| 63 | * @param mixed $data |
||
| 64 | * <p> |
||
| 65 | * The initial items to store in the collection. |
||
| 66 | * </p> |
||
| 67 | * @param string $iteratorClass optional <p> |
||
| 68 | * You can overwrite the ArrayyIterator, but mostly you don't |
||
| 69 | * need this option. |
||
| 70 | * </p> |
||
| 71 | * @param bool $checkPropertiesInConstructor optional <p> |
||
| 72 | * You need to extend the "Arrayy"-class and you need to set |
||
| 73 | * the $checkPropertiesMismatchInConstructor class property |
||
| 74 | * to |
||
| 75 | * true, otherwise this option didn't not work anyway. |
||
| 76 | * </p> |
||
| 77 | * |
||
| 78 | * @psalm-param array<TKey,T>|\Arrayy\Arrayy<TKey,T>|\Closure():array<TKey,T>|mixed $data |
||
| 79 | * @psalm-param class-string<\Arrayy\ArrayyIterator> $iteratorClass |
||
| 80 | */ |
||
| 81 | 94 | public function __construct( |
|
| 109 | |||
| 110 | /** |
||
| 111 | * Append a (key) + value to the current array. |
||
| 112 | * |
||
| 113 | * @param mixed $value |
||
| 114 | * @param mixed $key |
||
| 115 | * |
||
| 116 | * @return $this |
||
| 117 | * <p>(Mutable) Return this CollectionInterface object, with the appended values.</p> |
||
| 118 | * |
||
| 119 | * @psalm-param T|array<TKey,T>|static<TKey,T> $value |
||
| 120 | * @psalm-param TKey|null $key |
||
| 121 | * @psalm-return static<TKey,T> |
||
| 122 | */ |
||
| 123 | 6 | View Code Duplication | public function append($value, $key = null): Arrayy |
| 142 | |||
| 143 | /** |
||
| 144 | * {@inheritdoc} |
||
| 145 | */ |
||
| 146 | 2 | public function offsetSet($offset, $value) |
|
| 147 | { |
||
| 148 | if ( |
||
| 149 | 2 | $value instanceof self |
|
| 150 | && |
||
| 151 | 2 | !$value instanceof TypeInterface |
|
| 152 | ) { |
||
| 153 | foreach ($value as $valueTmp) { |
||
| 154 | parent::offsetSet($offset, $valueTmp); |
||
| 155 | } |
||
| 156 | |||
| 157 | return; |
||
| 158 | } |
||
| 159 | |||
| 160 | 2 | parent::offsetSet($offset, $value); |
|
| 161 | 1 | } |
|
| 162 | |||
| 163 | /** |
||
| 164 | * Prepend a (key) + value to the current array. |
||
| 165 | * |
||
| 166 | * @param mixed $value |
||
| 167 | * @param mixed $key |
||
| 168 | * |
||
| 169 | * @return $this |
||
| 170 | * <p>(Mutable) Return this CollectionInterface object, with the prepended value.</p> |
||
| 171 | * |
||
| 172 | * @psalm-param T|array<TKey,T>|static<TKey,T> $value |
||
| 173 | * @psalm-param TKey|null $key |
||
| 174 | * @psalm-return static<TKey,T> |
||
| 175 | */ |
||
| 176 | 3 | View Code Duplication | public function prepend($value, $key = null): Arrayy |
| 195 | |||
| 196 | /** |
||
| 197 | * {@inheritdoc} |
||
| 198 | */ |
||
| 199 | 1 | public function column(string $keyOrPropertyOrMethod): array |
|
| 210 | |||
| 211 | /** |
||
| 212 | * {@inheritdoc} |
||
| 213 | */ |
||
| 214 | 7 | public function getCollection(): array |
|
| 218 | |||
| 219 | /** |
||
| 220 | * {@inheritdoc} |
||
| 221 | */ |
||
| 222 | abstract public function getType(); |
||
| 223 | |||
| 224 | /** |
||
| 225 | * Merge current items and items of given collections into a new one. |
||
| 226 | * |
||
| 227 | * @param CollectionInterface|static ...$collections |
||
| 228 | * <p>The collections to merge.</p> |
||
| 229 | * |
||
| 230 | *@throws \InvalidArgumentException if any of the given collections are not of the same type |
||
| 231 | * |
||
| 232 | * @return $this |
||
| 233 | * |
||
| 234 | * @psalm-param CollectionInterface<TKey,T> ...$collections |
||
| 235 | * @psalm-return static<TKey,T> |
||
| 236 | */ |
||
| 237 | 1 | public function merge(CollectionInterface ...$collections): self |
|
| 247 | |||
| 248 | /** |
||
| 249 | * Creates an CollectionInterface object. |
||
| 250 | * |
||
| 251 | * @param mixed $data |
||
| 252 | * @param string $iteratorClass |
||
| 253 | * @param bool $checkPropertiesInConstructor |
||
| 254 | * |
||
| 255 | * @return static |
||
| 256 | * <p>(Immutable) Returns an new instance of the CollectionInterface object.</p> |
||
| 257 | * |
||
| 258 | * @template TKeyCreate as int|string |
||
| 259 | * @template TCreate |
||
| 260 | * @psalm-param array<TKeyCreate,TCreate> $data |
||
| 261 | * @psalm-param class-string<\Arrayy\ArrayyIterator> $iteratorClass |
||
| 262 | * @psalm-return static<TKeyCreate,TCreate> |
||
| 263 | * @psalm-mutation-free |
||
| 264 | */ |
||
| 265 | 24 | public static function create( |
|
| 276 | |||
| 277 | /** |
||
| 278 | * @param string $json |
||
| 279 | * |
||
| 280 | * @return static |
||
| 281 | * <p>(Immutable) Returns an new instance of the CollectionInterface object.</p> |
||
| 282 | * |
||
| 283 | * @psalm-return static<mixed,T> |
||
| 284 | * |
||
| 285 | * @psalm-mutation-free |
||
| 286 | */ |
||
| 287 | 7 | public static function createFromJsonMapper(string $json) |
|
| 323 | |||
| 324 | /** |
||
| 325 | * Internal mechanic of set method. |
||
| 326 | * |
||
| 327 | * @param int|string|null $key |
||
| 328 | * @param mixed $value |
||
| 329 | * @param bool $checkProperties |
||
| 330 | * |
||
| 331 | * @return bool |
||
| 332 | */ |
||
| 333 | 88 | protected function internalSet( |
|
| 360 | |||
| 361 | /** |
||
| 362 | * @param string|string[]|TypeCheckArray|TypeCheckInterface[]|null $type |
||
| 363 | * |
||
| 364 | * @return TypeCheckArray |
||
| 365 | * |
||
| 366 | * @psalm-param null|string|string[]|class-string|class-string[]|TypeCheckArray<array-key,TypeCheckInterface>|array<array-key,TypeCheckInterface>|mixed $type |
||
| 367 | * @psalm-return TypeCheckArray<array-key,TypeCheckInterface> |
||
| 368 | */ |
||
| 369 | 94 | protected static function convertIntoTypeCheckArray($type): TypeCheckArray |
|
| 387 | } |
||
| 388 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..