Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
30 | abstract class AbstractCollection extends Arrayy implements CollectionInterface |
||
31 | { |
||
32 | /** |
||
33 | * @var array |
||
34 | * @psalm-var array<T> |
||
35 | */ |
||
36 | protected $array = []; |
||
37 | |||
38 | /** |
||
39 | * @var ArrayyRewindableGenerator|null |
||
40 | * @psalm-var \Arrayy\ArrayyRewindableGenerator<TKey,T>|null |
||
41 | */ |
||
42 | protected $generator; |
||
43 | |||
44 | /** |
||
45 | * @var bool |
||
46 | */ |
||
47 | protected $checkPropertyTypes = true; |
||
48 | |||
49 | /** |
||
50 | * @var bool |
||
51 | */ |
||
52 | protected $checkPropertiesMismatch = false; |
||
53 | |||
54 | /** |
||
55 | * @var bool |
||
56 | */ |
||
57 | protected $checkForMissingPropertiesInConstructor = true; |
||
58 | |||
59 | /** |
||
60 | * Constructs a collection object of the specified type, optionally with the |
||
61 | * specified data. |
||
62 | * |
||
63 | * @param mixed $data |
||
64 | * <p> |
||
65 | * The initial items to store in the collection. |
||
66 | * </p> |
||
67 | * @param string $iteratorClass optional <p> |
||
68 | * You can overwrite the ArrayyIterator, but mostly you don't |
||
69 | * need this option. |
||
70 | * </p> |
||
71 | * @param bool $checkPropertiesInConstructor optional <p> |
||
72 | * You need to extend the "Arrayy"-class and you need to set |
||
73 | * the $checkPropertiesMismatchInConstructor class property |
||
74 | * to |
||
75 | * true, otherwise this option didn't not work anyway. |
||
76 | * </p> |
||
77 | * |
||
78 | * @psalm-param array<TKey,T>|\Arrayy\Arrayy<TKey,T>|\Closure():array<TKey,T>|mixed $data |
||
79 | * @psalm-param class-string<\Arrayy\ArrayyIterator> $iteratorClass |
||
80 | */ |
||
81 | 73 | public function __construct( |
|
82 | $data = [], |
||
83 | string $iteratorClass = ArrayyIterator::class, |
||
84 | bool $checkPropertiesInConstructor = true |
||
85 | ) { |
||
86 | 73 | $type = $this->getType(); |
|
87 | |||
88 | 73 | $type = self::convertIntoTypeCheckArray($type); |
|
89 | |||
90 | 73 | $this->properties = $type; |
|
|
|||
91 | |||
92 | // cast into array, if needed |
||
93 | if ( |
||
94 | 73 | !\is_array($data) |
|
95 | && |
||
96 | 73 | !($data instanceof \Traversable) |
|
97 | && |
||
98 | 73 | !($data instanceof \Closure) |
|
99 | ) { |
||
100 | 1 | $data = [$data]; |
|
101 | } |
||
102 | |||
103 | 73 | parent::__construct( |
|
104 | 73 | $data, |
|
105 | $iteratorClass, |
||
106 | $checkPropertiesInConstructor |
||
107 | ); |
||
108 | 61 | } |
|
109 | |||
110 | /** |
||
111 | * Append a (key) + value to the current array. |
||
112 | * |
||
113 | * @param mixed $value |
||
114 | * @param mixed $key |
||
115 | * |
||
116 | * @return $this |
||
117 | * <p>(Mutable) Return this CollectionInterface object, with the appended values.</p> |
||
118 | * |
||
119 | * @psalm-param T|array<TKey,T>|static<TKey,T> $value |
||
120 | * @psalm-param TKey|null $key |
||
121 | * @psalm-return static<TKey,T> |
||
122 | */ |
||
123 | 4 | View Code Duplication | public function append($value, $key = null): Arrayy |
142 | |||
143 | /** |
||
144 | * {@inheritdoc} |
||
145 | */ |
||
146 | 1 | public function offsetSet($offset, $value) |
|
162 | |||
163 | /** |
||
164 | * Prepend a (key) + value to the current array. |
||
165 | * |
||
166 | * @param mixed $value |
||
167 | * @param mixed $key |
||
168 | * |
||
169 | * @return $this |
||
170 | * <p>(Mutable) Return this CollectionInterface object, with the prepended value.</p> |
||
171 | * |
||
172 | * @psalm-param T|array<TKey,T>|static<TKey,T> $value |
||
173 | * @psalm-param TKey|null $key |
||
174 | * @psalm-return static<TKey,T> |
||
175 | */ |
||
176 | 3 | View Code Duplication | public function prepend($value, $key = null): Arrayy |
195 | |||
196 | /** |
||
197 | * {@inheritdoc} |
||
198 | */ |
||
199 | 1 | public function column(string $keyOrPropertyOrMethod): array |
|
210 | |||
211 | /** |
||
212 | * {@inheritdoc} |
||
213 | */ |
||
214 | 6 | public function getCollection(): array |
|
218 | |||
219 | /** |
||
220 | * {@inheritdoc} |
||
221 | */ |
||
222 | abstract public function getType(); |
||
223 | |||
224 | /** |
||
225 | * Merge current items and items of given collections into a new one. |
||
226 | * |
||
227 | * @param CollectionInterface|static ...$collections |
||
228 | * <p>The collections to merge.</p> |
||
229 | * |
||
230 | *@throws \InvalidArgumentException if any of the given collections are not of the same type |
||
231 | * |
||
232 | * @return $this |
||
233 | * |
||
234 | * @psalm-param CollectionInterface<TKey,T> ...$collections |
||
235 | * @psalm-return static<TKey,T> |
||
236 | */ |
||
237 | 1 | public function merge(CollectionInterface ...$collections): self |
|
247 | |||
248 | /** |
||
249 | * Creates an CollectionInterface object. |
||
250 | * |
||
251 | * @param mixed $data |
||
252 | * @param string $iteratorClass |
||
253 | * @param bool $checkPropertiesInConstructor |
||
254 | * |
||
255 | * @return static |
||
256 | * <p>(Immutable) Returns an new instance of the CollectionInterface object.</p> |
||
257 | * |
||
258 | * @template TKeyCreate as int|string |
||
259 | * @template TCreate |
||
260 | * @psalm-param array<TKeyCreate,TCreate> $data |
||
261 | * @psalm-param class-string<\Arrayy\ArrayyIterator> $iteratorClass |
||
262 | * @psalm-return static<TKeyCreate,TCreate> |
||
263 | * @psalm-mutation-free |
||
264 | */ |
||
265 | 16 | public static function create( |
|
266 | $data = [], |
||
267 | string $iteratorClass = ArrayyIterator::class, |
||
268 | bool $checkPropertiesInConstructor = true |
||
269 | ) { |
||
270 | 16 | return new static( |
|
271 | 16 | $data, |
|
272 | $iteratorClass, |
||
273 | $checkPropertiesInConstructor |
||
274 | ); |
||
275 | } |
||
276 | |||
277 | /** |
||
278 | * Internal mechanic of set method. |
||
279 | * |
||
280 | * @param int|string|null $key |
||
281 | * @param mixed $value |
||
282 | * @param bool $checkProperties |
||
283 | * |
||
284 | * @return bool |
||
285 | */ |
||
286 | 71 | protected function internalSet( |
|
287 | $key, |
||
288 | &$value, |
||
289 | bool $checkProperties = true |
||
290 | ): bool { |
||
291 | if ( |
||
292 | 71 | $value instanceof self |
|
293 | && |
||
294 | 71 | !$value instanceof TypeInterface |
|
295 | ) { |
||
296 | foreach ($value as $valueTmp) { |
||
297 | parent::internalSet( |
||
298 | $key, |
||
299 | $valueTmp, |
||
300 | $checkProperties |
||
301 | ); |
||
302 | } |
||
303 | |||
304 | return true; |
||
305 | } |
||
306 | |||
307 | 71 | return parent::internalSet( |
|
308 | 71 | $key, |
|
309 | $value, |
||
310 | $checkProperties |
||
311 | ); |
||
312 | } |
||
313 | |||
314 | /** |
||
315 | * @param string|string[]|TypeCheckArray|TypeCheckInterface[]|null $type |
||
316 | * |
||
317 | * @return TypeCheckArray |
||
318 | * |
||
319 | * @psalm-param null|string|string[]|class-string|class-string[]|TypeCheckArray<array-key,TypeCheckInterface>|array<array-key,TypeCheckInterface>|mixed $type |
||
320 | * @psalm-return TypeCheckArray<array-key,TypeCheckInterface> |
||
321 | */ |
||
322 | 73 | protected static function convertIntoTypeCheckArray($type): TypeCheckArray |
|
339 | } |
||
340 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..