Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 30 | abstract class AbstractCollection extends Arrayy implements CollectionInterface |
||
| 31 | { |
||
| 32 | /** |
||
| 33 | * @var array |
||
| 34 | * @phpstan-var array<T> |
||
| 35 | */ |
||
| 36 | protected $array = []; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var ArrayyRewindableGenerator|null |
||
| 40 | * @phpstan-var \Arrayy\ArrayyRewindableGenerator<TKey,T>|null |
||
| 41 | */ |
||
| 42 | protected $generator; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var bool |
||
| 46 | */ |
||
| 47 | protected $checkPropertyTypes = true; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var bool |
||
| 51 | */ |
||
| 52 | protected $checkPropertiesMismatch = false; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var bool |
||
| 56 | */ |
||
| 57 | protected $checkForMissingPropertiesInConstructor = true; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * Constructs a collection object of the specified type, optionally with the |
||
| 61 | * specified data. |
||
| 62 | * |
||
| 63 | * @param mixed $data |
||
| 64 | * <p> |
||
| 65 | * The initial items to store in the collection. |
||
| 66 | * </p> |
||
| 67 | * @param string $iteratorClass optional <p> |
||
| 68 | * You can overwrite the ArrayyIterator, but mostly you don't |
||
| 69 | * need this option. |
||
| 70 | * </p> |
||
| 71 | * @param bool $checkPropertiesInConstructor optional <p> |
||
| 72 | * You need to extend the "Arrayy"-class and you need to set |
||
| 73 | * the $checkPropertiesMismatchInConstructor class property |
||
| 74 | * to |
||
| 75 | * true, otherwise this option didn't not work anyway. |
||
| 76 | * </p> |
||
| 77 | * |
||
| 78 | * @phpstan-param array<TKey,T>|\Arrayy\Arrayy<TKey,T>|\Closure():array<TKey,T>|mixed $data |
||
| 79 | * @phpstan-param class-string<\Arrayy\ArrayyIterator> $iteratorClass |
||
| 80 | */ |
||
| 81 | 99 | public function __construct( |
|
| 109 | |||
| 110 | /** |
||
| 111 | * Append a (key) + value to the current array. |
||
| 112 | * |
||
| 113 | * @param mixed $value |
||
| 114 | * @param mixed $key |
||
| 115 | * |
||
| 116 | * @return $this |
||
| 117 | * <p>(Mutable) Return this CollectionInterface object, with the appended values.</p> |
||
| 118 | * |
||
| 119 | * @phpstan-param T|static $value |
||
| 120 | * @phpstan-param TKey|null $key |
||
| 121 | * @phpstan-return static<TKey,T> |
||
| 122 | */ |
||
| 123 | 6 | View Code Duplication | public function append($value, $key = null): Arrayy |
| 143 | |||
| 144 | /** |
||
| 145 | * {@inheritdoc} |
||
| 146 | */ |
||
| 147 | 2 | public function offsetSet($offset, $value) |
|
| 163 | |||
| 164 | /** |
||
| 165 | * Prepend a (key) + value to the current array. |
||
| 166 | * |
||
| 167 | * @param mixed $value |
||
| 168 | * @param mixed $key |
||
| 169 | * |
||
| 170 | * @return $this |
||
| 171 | * <p>(Mutable) Return this CollectionInterface object, with the prepended value.</p> |
||
| 172 | * |
||
| 173 | * @phpstan-param T|static $value |
||
| 174 | * @phpstan-param TKey|null $key |
||
| 175 | * @phpstan-return static<TKey,T> |
||
| 176 | */ |
||
| 177 | 3 | View Code Duplication | public function prepend($value, $key = null): Arrayy |
| 197 | |||
| 198 | /** |
||
| 199 | * {@inheritdoc} |
||
| 200 | */ |
||
| 201 | 1 | public function column(string $keyOrPropertyOrMethod): array |
|
| 212 | |||
| 213 | /** |
||
| 214 | * {@inheritdoc} |
||
| 215 | */ |
||
| 216 | 7 | public function getCollection(): array |
|
| 220 | |||
| 221 | /** |
||
| 222 | * {@inheritdoc} |
||
| 223 | */ |
||
| 224 | abstract public function getType(); |
||
| 225 | |||
| 226 | /** |
||
| 227 | * Merge current items and items of given collections into a new one. |
||
| 228 | * |
||
| 229 | * @param CollectionInterface|static ...$collections |
||
| 230 | * <p>The collections to merge.</p> |
||
| 231 | * |
||
| 232 | *@throws \InvalidArgumentException if any of the given collections are not of the same type |
||
| 233 | * |
||
| 234 | * @return $this |
||
| 235 | * |
||
| 236 | * @phpstan-param CollectionInterface<TKey,T> ...$collections |
||
| 237 | * @phpstan-return static<TKey,T> |
||
| 238 | */ |
||
| 239 | 1 | public function merge(CollectionInterface ...$collections): self |
|
| 249 | |||
| 250 | /** |
||
| 251 | * Creates an CollectionInterface object. |
||
| 252 | * |
||
| 253 | * @param mixed $data |
||
| 254 | * @param string $iteratorClass |
||
| 255 | * @param bool $checkPropertiesInConstructor |
||
| 256 | * |
||
| 257 | * @return static |
||
| 258 | * <p>(Immutable) Returns an new instance of the CollectionInterface object.</p> |
||
| 259 | * |
||
| 260 | * @template TKeyCreate as int|string |
||
| 261 | * @template TCreate |
||
| 262 | * @phpstan-param array<TKeyCreate,TCreate> $data |
||
| 263 | * @phpstan-param class-string<\Arrayy\ArrayyIterator> $iteratorClass |
||
| 264 | * @phpstan-return static<TKeyCreate,TCreate> |
||
| 265 | * @psalm-mutation-free |
||
| 266 | */ |
||
| 267 | 25 | public static function create( |
|
| 278 | |||
| 279 | /** |
||
| 280 | * @param string $json |
||
| 281 | * |
||
| 282 | * @return static |
||
| 283 | * <p>(Immutable) Returns an new instance of the CollectionInterface object.</p> |
||
| 284 | * |
||
| 285 | * @phpstan-return static<int,T> |
||
| 286 | * |
||
| 287 | * @psalm-mutation-free |
||
| 288 | */ |
||
| 289 | 7 | public static function createFromJsonMapper(string $json) |
|
| 325 | |||
| 326 | /** |
||
| 327 | * Internal mechanic of set method. |
||
| 328 | * |
||
| 329 | * @param int|string|null $key |
||
| 330 | * @param mixed $value |
||
| 331 | * @param bool $checkProperties |
||
| 332 | * |
||
| 333 | * @return bool |
||
| 334 | */ |
||
| 335 | 93 | protected function internalSet( |
|
| 362 | |||
| 363 | /** |
||
| 364 | * @param string|string[]|TypeCheckArray|TypeCheckInterface[]|null $type |
||
| 365 | * |
||
| 366 | * @return TypeCheckArray |
||
| 367 | * |
||
| 368 | * @phpstan-param null|string|string[]|class-string|class-string[]|TypeCheckArray<array-key,TypeCheckInterface>|array<array-key,TypeCheckInterface>|mixed $type |
||
| 369 | * @phpstan-return TypeCheckArray<array-key,TypeCheckInterface> |
||
| 370 | */ |
||
| 371 | 99 | protected static function convertIntoTypeCheckArray($type): TypeCheckArray |
|
| 389 | } |
||
| 390 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..