VojtaSvoboda\WebArtisan\Classes\CommandRunner

Complexity

Total Complexity

14

Size/Duplication

Total Lines	129
Duplicated Lines	31.78 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	run()	13	13	2
A	runForPlugin()	15	15	2
A	runQueued()	13	13	2
C	check()	0	27	7

<?php namespace VojtaSvoboda\WebArtisan\Classes;

use Artisan;
use Config;
use VojtaSvoboda\WebArtisan\Models\Settings;

class CommandRunner
{
    /** @var array $allowedCommands List of allowed commands loaded from Config. */
    protected $allowedCommands;

    /** @var array $allowedPluginCommands List of allowed plugin commands. */
    protected $allowedPluginCommands;

    /** @var Settings $settings */
    protected $settings;

    /**
     * CommandRunner constructor.
     *
     * @param Settings $settings
     */
    public function __construct(Settings $settings)
    {
        $this->settings = $settings;
        $this->allowedCommands = Config::get('vojtasvoboda.webartisan::allowedCommands');
        $this->allowedPluginCommands = Config::get('vojtasvoboda.webartisan::allowedPluginCommands');
    }

    /**
     * Run command and return true if Ok or string with error.
     *
     * @param string $command
     * @param string $hash
     *
     * @return bool|string
     */
    public function run($command, $hash)

This method seems to be duplicated in your project.

    {
        // check command and hash
        $check = $this->check($command, $hash);
        if ($check !== true) {
            return $check;
        }

        // run command
        Artisan::call($command);

        return true;
    }

    /**
     * Run plugin command and return true if Ok or string with error.
     *
     * @param $command
     * @param $plugin
     * @param $hash
     *
     * @return bool|string
     */
    public function runForPlugin($command, $plugin, $hash)

This method seems to be duplicated in your project.

    {
        // check command, plugin and hash
        $check = $this->check($command, $hash, $plugin);
        if ($check !== true) {
            return $check;
        }

        // run command
        Artisan::call($command, [
            'name' => $plugin,
        ]);

        return true;
    }

    /**
     * Run queued command and return true if Ok or string with error.
     *
     * @param string $command
     * @param string $hash
     *
     * @return bool|string
     */
    public function runQueued($command, $hash)

This method seems to be duplicated in your project.

    {
        // check command and hash
        $check = $this->check($command, $hash);
        if ($check !== true) {
            return $check;
        }

        // run queued command
        Artisan::queue($command);

        return true;
    }

    /**
     * Check command and hash.
     *
     * @param string $command Command identifier.
     * @param string $hash Security hash.
     * @param string $plugin Plugin identifier (optional).
     *
     * @return bool|string
     */
    public function check($command, $hash, $plugin = null)
    {
        // check commands whitelist
        if ($plugin === null && !in_array($command, $this->allowedCommands)) {
            return 'This command is not allowed.';
        }

        // check plugin commands whitelist
        if ($plugin !== null && !in_array($command, $this->allowedPluginCommands)) {
            return 'This command is not allowed.';
        }

        // get hash
        $localHash = $this->settings->get('hash');

        // if hash not set
        if (strlen($localHash) < 16) {
            return 'You have to set controll hash at backend settings and it should be at least 16 characters length.';
        }

        // if hash doesn't match
        if ($hash != $localHash) {
            return 'Wrong control hash. Check backend settings.';
        }

        return true;
    }
}