Reviews::onRun() - Code Metrics - Inspection of "Add categories" - vojtasvoboda/oc-reviews-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Vojta

created 2016-12-30 14:37 UTC

Reviews::onRun() A

↳ Parent: Reviews

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	2
eloc	6
nc	2
nop	0

<?php namespace VojtaSvoboda\Reviews\Components;

use App;
use Cms\Classes\ComponentBase;
use VojtaSvoboda\Reviews\Facades\ReviewsFacade;
use VojtaSvoboda\Reviews\Models\Category;

class Reviews extends ComponentBase
{
    private $reviews;

    public function componentDetails()
    {
        return [
            'name' => 'Reviews',
            'description' => 'Show reviews on your page.'
        ];
    }

    public function defineProperties()
    {
        return [
            'categoryFilter' => [
                'title' => 'Category identifier',
                'description' => 'Show only reviews from some category by slug',
                'type' => 'string',
                'default' => '{{ :category }}',
            ],
        ];
    }

    public function onRun()
    {
        // category filter
        $category = null;
        if ($categorySlug = $this->property('categoryFilter')) {
            $category = $this->getCategory($categorySlug);
        }
        $this->page['category'] = $category;
        $this->page['reviews'] = $this->reviews($category);
    }

    /**
     * Get reviews.
     *
     * @param Category $category Filter by category.
     *
     * @return mixed
     */
    public function reviews($category = null)
    {
        if ($this->reviews === null) {
            $this->reviews = $this->getFacade()->getApprovedReviews($category);
        }

        return $this->reviews;
    }

    /**
     * Get category by slug.
     *
     * @param $category
     *
     * @return mixed
     */
    public function getCategory($category)
    {
        return Category::where('slug', $category)->first();
    }

    /**
     * Get Facade.
     *
     * @return ReviewsFacade
     */
    private function getFacade()
    {
        return App::make('vojtasvoboda.reviews.facade');
    }
}


1			<?php namespace VojtaSvoboda\Reviews\Components;
2
3			use App;
4			use Cms\Classes\ComponentBase;
5			use VojtaSvoboda\Reviews\Facades\ReviewsFacade;
6			use VojtaSvoboda\Reviews\Models\Category;
7
8			class Reviews extends ComponentBase
9			{
10			private $reviews;
11
12			public function componentDetails()
13			{
14			return [
15			'name' => 'Reviews',
16			'description' => 'Show reviews on your page.'
17			];
18			}
19
20			public function defineProperties()
21			{
22			return [
23			'categoryFilter' => [
24			'title' => 'Category identifier',
25			'description' => 'Show only reviews from some category by slug',
26			'type' => 'string',
27			'default' => '{{ :category }}',
28			],
29			];
30			}
31
32			public function onRun()
33			{
34			// category filter
35			$category = null;
36			if ($categorySlug = $this->property('categoryFilter')) {
37			$category = $this->getCategory($categorySlug);
38			}
39			$this->page['category'] = $category;
40			$this->page['reviews'] = $this->reviews($category);
41			}
42
43			/**
44			* Get reviews.
45			*
46			* @param Category $category Filter by category.
47			*
48			* @return mixed
49			*/
50			public function reviews($category = null)
51			{
52			if ($this->reviews === null) {
53			$this->reviews = $this->getFacade()->getApprovedReviews($category);
54			}
55
56			return $this->reviews;
57			}
58
59			/**
60			* Get category by slug.
61			*
62			* @param $category
63			*
64			* @return mixed
65			*/
66			public function getCategory($category)
67			{
68			return Category::where('slug', $category)->first();
69			}
70
71			/**
72			* Get Facade.
73			*
74			* @return ReviewsFacade
75			*/
76			private function getFacade()
77			{
78			return App::make('vojtasvoboda.reviews.facade');
79			}
80			}
81

vojtasvoboda / oc-reviews-plugin

Pull Request — master (#2)

Reviews::onRun() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like