ReservationForm::onRun() - Code Metrics - Inspection of "Feature/Day of week and work time" - vojtasvoboda/oc-reservations-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

unknown

created 2017-05-08 19:49 UTC

ReservationForm::onRun() B

↳ Parent: ReservationForm

Complexity

Conditions	6
Paths	18

Size

Total Lines	62
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	62
rs	8.6652
cc	6
eloc	40
nc	18
nop	0

How to fix Long Method

<?php namespace VojtaSvoboda\Reservations\Components;

use App;
use Cms\Classes\ComponentBase;
use Exception;
use Flash;
use Illuminate\Support\Facades\Log;
use Input;
use Lang;
use October\Rain\Exception\ApplicationException;
use October\Rain\Exception\ValidationException;
use Redirect;
use Session;
use VojtaSvoboda\Reservations\Facades\ReservationsFacade;
use VojtaSvoboda\Reservations\Models\Settings;
use Config;

/**
 * Reservation Form component.
 *
 * @package VojtaSvoboda\Reservations\Components
 */
class ReservationForm extends ComponentBase
{
    const PATH_PICKADATE_COMPRESSED = '/plugins/vojtasvoboda/reservations/assets/vendor/pickadate/lib/compressed/';

    public function componentDetails()
	{
		return [
			'name' => 'vojtasvoboda.reservations::lang.reservationform.name',
			'description' => 'vojtasvoboda.reservations::lang.reservationform.description',
		];
	}

    /**
     * AJAX form submit handler.
     */
    public function onSubmit()
    {
        // check CSRF token
        if (Session::token() != Input::get('_token')) {
            throw new ApplicationException(Lang::get('vojtasvoboda.reservations::lang.errors.session_expired'));
        }

        $data = Input::all();
        $this->getFacade()->storeReservation($data);
    }

    /**
     * Fallback for non-ajax POST request.
     */
	public function onRun()
	{
        $facade = $this->getFacade();

		$error = false;
		if (Input::get($this->alias . '-submit')) {

            // check CSRF token
            if (Session::token() != Input::get('_token')) {
                $error = Lang::get('vojtasvoboda.reservations::lang.errors.session_expired');
            } else {
                try {
                    $data = Input::all();
                    $facade->storeReservation($data);
                    $msg = Lang::get('vojtasvoboda.reservations::lang.reservationform.success');
                    Flash::success($msg);

                    return Redirect::to($this->page->url . '#' . $this->alias, 303);

                } catch(ValidationException $e) {
                    $error = $e->getMessage();

                } catch(ApplicationException $e) {
                    $error = $e->getMessage();

                } catch(Exception $e) {
                    Log::error($e->getMessage());
                    $error = Lang::get('vojtasvoboda.reservations::lang.errors.exception');
                }
            }
		}

		// inject assets
        $this->injectAssets();

		// load booked dates and their time slots
        $dates = $this->getReservedDates();

        // template data
		$this->page['sent'] = Flash::check();
		$this->page['post'] = post();
		$this->page['error'] = $error;
        $this->page['dates'] = json_encode($dates);
        $this->page['settings'] = [
            'formats_date'         => Settings::get(
                'formats_date',
                Config::get('vojtasvoboda.reservations::config.formats.date', 'd/m/Y')
            ),
            'formats_time'         => Settings::get(
                'formats_time',
                Config::get('vojtasvoboda.reservations::config.formats.time', 'H:i')
            ),
            'reservation_interval' => Settings::get(
                'reservation_interval',
                Config::get('vojtasvoboda.reservations::config.reservation.interval', 15)
            ),
            'first_weekday'        => (int)Settings::get('first_weekday', false),
            'work_time_from'       => Settings::get('work_time_from', '10:00'),
            'work_time_to'         => Settings::get('work_time_to', '18:00'),
            'work_days'            => Settings::get('work_days', ['monday','tuesday','wednesday','thursday','friday']),
        ];
	}

    /**
     * Get reservation facade.
     *
     * @return ReservationsFacade
     */
	protected function getFacade()
    {
        return App::make(ReservationsFacade::class);
    }

    /**
     * Get reserved dates.
     *
     * @return array
     */
    protected function getReservedDates()
    {
        return $this->getFacade()->getReservedDates();
    }

    /**
     * Inject components assets.
     */
    protected function injectAssets()
    {
        $this->addCss(self::PATH_PICKADATE_COMPRESSED.'themes/classic.css');
        $this->addCss(self::PATH_PICKADATE_COMPRESSED.'themes/classic.date.css');
        $this->addCss(self::PATH_PICKADATE_COMPRESSED.'themes/classic.time.css');
        $this->addJs(self::PATH_PICKADATE_COMPRESSED.'picker.js');
        $this->addJs(self::PATH_PICKADATE_COMPRESSED.'picker.date.js');
        $this->addJs(self::PATH_PICKADATE_COMPRESSED.'picker.time.js');

        switch (Lang::getLocale()) {
            case 'cs':
                $pickerTranslate = 'cs_CZ';
                break;
            case 'es':
                $pickerTranslate = 'es_ES';
                break;
            case 'ru':
                $pickerTranslate = 'ru_RU';
                break;
        }

        if (isset($pickerTranslate)) {
            $this->addJs(self::PATH_PICKADATE_COMPRESSED.'translations/'.$pickerTranslate.'.js');
        }

        $this->addJs('/plugins/vojtasvoboda/reservations/assets/js/reservationform.js');
    }
}


1			<?php namespace VojtaSvoboda\Reservations\Components;
2
3			use App;
4			use Cms\Classes\ComponentBase;
5			use Exception;
6			use Flash;
7			use Illuminate\Support\Facades\Log;
8			use Input;
9			use Lang;
10			use October\Rain\Exception\ApplicationException;
11			use October\Rain\Exception\ValidationException;
12			use Redirect;
13			use Session;
14			use VojtaSvoboda\Reservations\Facades\ReservationsFacade;
15			use VojtaSvoboda\Reservations\Models\Settings;
16			use Config;
17
18			/**
19			* Reservation Form component.
20			*
21			* @package VojtaSvoboda\Reservations\Components
22			*/
23			class ReservationForm extends ComponentBase
24			{
25			const PATH_PICKADATE_COMPRESSED = '/plugins/vojtasvoboda/reservations/assets/vendor/pickadate/lib/compressed/';
26
27			public function componentDetails()
28			{
29			return [
30			'name' => 'vojtasvoboda.reservations::lang.reservationform.name',
31			'description' => 'vojtasvoboda.reservations::lang.reservationform.description',
32			];
33			}
34
35			/**
36			* AJAX form submit handler.
37			*/
38			public function onSubmit()
39			{
40			// check CSRF token
41			if (Session::token() != Input::get('_token')) {
42			throw new ApplicationException(Lang::get('vojtasvoboda.reservations::lang.errors.session_expired'));
43			}
44
45			$data = Input::all();
46			$this->getFacade()->storeReservation($data);
47			}
48
49			/**
50			* Fallback for non-ajax POST request.
51			*/
52			public function onRun()
53			{
54			$facade = $this->getFacade();
55
56			$error = false;
57			if (Input::get($this->alias . '-submit')) {
58
59			// check CSRF token
60			if (Session::token() != Input::get('_token')) {
61			$error = Lang::get('vojtasvoboda.reservations::lang.errors.session_expired');
62			} else {
63			try {
64			$data = Input::all();
65			$facade->storeReservation($data);
66			$msg = Lang::get('vojtasvoboda.reservations::lang.reservationform.success');
67			Flash::success($msg);
68
69			return Redirect::to($this->page->url . '#' . $this->alias, 303);
70
71			} catch(ValidationException $e) {
72			$error = $e->getMessage();
73
74			} catch(ApplicationException $e) {
75			$error = $e->getMessage();
76
77			} catch(Exception $e) {
78			Log::error($e->getMessage());
79			$error = Lang::get('vojtasvoboda.reservations::lang.errors.exception');
80			}
81			}
82			}
83
84			// inject assets
85			$this->injectAssets();
86
87			// load booked dates and their time slots
88			$dates = $this->getReservedDates();
89
90			// template data
91			$this->page['sent'] = Flash::check();
92			$this->page['post'] = post();
93			$this->page['error'] = $error;
94			$this->page['dates'] = json_encode($dates);
95			$this->page['settings'] = [
96			'formats_date' => Settings::get(
97			'formats_date',
98			Config::get('vojtasvoboda.reservations::config.formats.date', 'd/m/Y')
99			),
100			'formats_time' => Settings::get(
101			'formats_time',
102			Config::get('vojtasvoboda.reservations::config.formats.time', 'H:i')
103			),
104			'reservation_interval' => Settings::get(
105			'reservation_interval',
106			Config::get('vojtasvoboda.reservations::config.reservation.interval', 15)
107			),
108			'first_weekday' => (int)Settings::get('first_weekday', false),
109			'work_time_from' => Settings::get('work_time_from', '10:00'),
110			'work_time_to' => Settings::get('work_time_to', '18:00'),
111			'work_days' => Settings::get('work_days', ['monday','tuesday','wednesday','thursday','friday']),
112			];
113			}
114
115			/**
116			* Get reservation facade.
117			*
118			* @return ReservationsFacade
119			*/
120			protected function getFacade()
121			{
122			return App::make(ReservationsFacade::class);
123			}
124
125			/**
126			* Get reserved dates.
127			*
128			* @return array
129			*/
130			protected function getReservedDates()
131			{
132			return $this->getFacade()->getReservedDates();
133			}
134
135			/**
136			* Inject components assets.
137			*/
138			protected function injectAssets()
139			{
140			$this->addCss(self::PATH_PICKADATE_COMPRESSED.'themes/classic.css');
141			$this->addCss(self::PATH_PICKADATE_COMPRESSED.'themes/classic.date.css');
142			$this->addCss(self::PATH_PICKADATE_COMPRESSED.'themes/classic.time.css');
143			$this->addJs(self::PATH_PICKADATE_COMPRESSED.'picker.js');
144			$this->addJs(self::PATH_PICKADATE_COMPRESSED.'picker.date.js');
145			$this->addJs(self::PATH_PICKADATE_COMPRESSED.'picker.time.js');
146
147			switch (Lang::getLocale()) {
148			case 'cs':
149			$pickerTranslate = 'cs_CZ';
150			break;
151			case 'es':
152			$pickerTranslate = 'es_ES';
153			break;
154			case 'ru':
155			$pickerTranslate = 'ru_RU';
156			break;
157			}
158
159			if (isset($pickerTranslate)) {
160			$this->addJs(self::PATH_PICKADATE_COMPRESSED.'translations/'.$pickerTranslate.'.js');
161			}
162
163			$this->addJs('/plugins/vojtasvoboda/reservations/assets/js/reservationform.js');
164			}
165			}
166

vojtasvoboda / oc-reservations-plugin

Pull Request — master (#18)

ReservationForm::onRun() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like