VojtaSvoboda\Reservations\Controllers\Reservations

Complexity

Total Complexity

20

Size/Duplication

Total Lines	130
Duplicated Lines	12.31 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
A	index()	0	6	1
A	listOverrideColumnValue()	0	14	4
B	index_onBulkAction()	0	19	6
A	isReturning()	0	7	1
A	getStateColor()	8	8	3
A	getStateName()	8	8	3

<?php namespace VojtaSvoboda\Reservations\Controllers;

use App;
use Backend\Classes\Controller;
use BackendMenu;
use Flash;
use Lang;
use VojtaSvoboda\Reservations\Facades\ReservationsFacade;
use VojtaSvoboda\Reservations\Models\Status;

class Reservations extends Controller
{
    public $implement = [
        'Backend\Behaviors\ListController',
        'Backend\Behaviors\FormController',
        'Backend\Behaviors\ImportExportController',
    ];

    public $listConfig = 'config_list.yaml';
    public $formConfig = 'config_form.yaml';
    public $importExportConfig = 'config_import_export.yaml';

    private $stateColors;
    private $stateNames;

    public $requiredPermissions = [
        'vojtasvoboda.reservations.reservations',
    ];

    public function __construct()
    {
        parent::__construct();

        $action = $this->action == 'export' ? 'export' : 'reservations';
        BackendMenu::setContext('VojtaSvoboda.Reservations', 'reservations', $action);
    }

    public function index()
    {
        $this->addJs('/plugins/vojtasvoboda/reservations/assets/js/bulk-actions.js');

        $this->asExtension('ListController')->index();
    }

    /**
     * Override displaying reservation status.
     *
     * @param $record
     * @param $columnName
     * @param null $definition
     *
     * @return string
     */
    public function listOverrideColumnValue($record, $columnName, $definition = null)
    {
        $statusStyle = "display:inline-block;width:13px;height:14px;position:relative;top:2px;margin-right:4px;color:#fff;font-size:11px;padding-left:3px;";

        if ($columnName == 'status_id') {
            $color = $this->getStateColor($record->status_id);

Are you sure the assignment to $color is correct as $this->getStateColor($record->status_id) (which targets VojtaSvoboda\Reservations\Controllers\Reservations::getStateColor()) seems to always return null.

            $name = $this->getStateName($record->status_id);

Are you sure the assignment to $name is correct as $this->getStateName($record->status_id) (which targets VojtaSvoboda\Reservations\Controllers\Reservations::getStateName()) seems to always return null.

            return '<div><span style="' . $statusStyle . 'background-color:' . $color . '"></span> ' . $name . '</div>';

        } elseif ($columnName == 'returning') {
            return $this->isReturning($record->email) ? '<i class=" icon-star"></i>' : '';
        }
    }

    /**
     * Bulk actions
     *
     * @return mixed
     */
    public function index_onBulkAction()
    {
        if (($bulkAction = post('action')) && ($checkedIds = post('checked')) && is_array($checkedIds) && count($checkedIds))
        {
            /** @var ReservationsFacade $facade */
            $facade = App::make('vojtasvoboda.reservations.facade');

            if ($bulkAction == 'delete') {
                $facade->bulkDelete($checkedIds);
            } else {
                $facade->bulkStateChange($checkedIds, $bulkAction);
            }

            $msg = Lang::get('vojtasvoboda.reservations::lang.reservations.change_status_success');
            Flash::success($msg);
        }

        return $this->listRefresh();
    }

    /**
     * Return if User is returning.
     *
     * @param string $email Users email
     *
     * @return bool
     */
    private function isReturning($email)
    {
        /** @var ReservationsFacade $facade */
        $facade = App::make('vojtasvoboda.reservations.facade');

        return $facade->isUserReturning($email);
    }

    /**
     * Get color by state ident.
     *
     * @param $ident
     *
     * @return null
     */
    private function getStateColor($ident)

This method seems to be duplicated in your project.

    {
        if ($this->stateColors === null) {
            $this->stateColors = Status::lists('color', 'ident');
        }

        return isset($this->stateColors[$ident]) ? $this->stateColors[$ident] : null;
    }

    /**
     * Get name by state ident.
     *
     * @param $ident
     *
     * @return null
     */
    private function getStateName($ident)

This method seems to be duplicated in your project.

    {
        if ($this->stateNames === null) {
            $this->stateNames = Status::lists('name', 'ident');
        }

        return isset($this->stateNames[$ident]) ? $this->stateNames[$ident] : null;
    }
}