voidtek\WindguruIO\WindguruAPI

Complexity

Total Complexity

5

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	3
A	call()	0	16	2

<?php
/**
 * File WindguruAPI.php
 * 
 * PHP Version 5
 *
 * @category PHP
 * @package  WindguruIO
 * @author   Voidtek <vdacosta@voidtek.com>
 * @license  http://www.gnu.org/copyleft/gpl.html GNU General Public License
 * @link     https://github.com/voidtek/windguru.io
 */

namespace voidtek\WindguruIO;

use Http\Client\Common\Plugin;
use Http\Client\HttpClient;
use Http\Message\UriFactory;
use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\MessageFactoryDiscovery;
use Psr\Http\Message\ResponseInterface;

/**
 * WindguruAPI Class
 *
 * @category Class
 * @package  WindguruIO
 * @author   Voidtek <vdacosta@voidtek.com>
 * @license  http://www.gnu.org/copyleft/gpl.html GNU General Public License
 * @link     https://github.com/voidtek/windguru.io
 */
class WindguruAPI
{

    /**
     * The default Windguru endpoint template.
     * Example: 'https://www.windguru.cz/int/iapi.php?q=ads_spot&id_spot%5B%5D=42'
     * 
     * @var string;
    */
    const ENDPOINT='http://www.windguru.cz';
    
    /**
     * Private HttpClient
     * 
     * @var HttpClient
     */
    private $_httpClient;

    /**
     * Private MessageFactory
     * 
     * @var MessageFactory
     */
    private $_messageFactory;

    /**
     * Constructor WindguruAPI
     * 
     * @param HttpClient|null     $httpClient     The HttpClient parameter.
     * @param MessageFactory|null $messageFactory The messageFactory parameter.
     */
    public function __construct(
        HttpClient $httpClient = null, 
        MessageFactory $messageFactory = null
    ) {
    
        $this->_httpClient = $httpClient ?: HttpClientDiscovery::find();
        $this->_messageFactory = $messageFactory ?: MessageFactoryDiscovery::find();

It seems like $messageFactory ?: \Http\Discovery\MessageFactoryDiscovery::find() can also be of type object<Http\Message\MessageFactory>. However, the property $_messageFactory is declared as type object<voidtek\WindguruIO\MessageFactory>. Maybe add an additional type check?

    }

    /**
     * Call an API endpoint.
     *
     * @param string $someArgument The Argument for this call.
     *
     * @return string
     */
    public function call($someArgument)
    {
        $request = $this->_messageFactory
            ->createRequest(
                'GET', 
                self::ENDPOINT.'/some_operation?argument='.$someArgument
            );

        try {
            $response = $this->_httpClient->sendRequest($request);
        } catch (\Http\Client\Exception $e) {
            throw new \RuntimeException('Something happened during HTTP request');
        }

        return (string) $response->getBody();
    }
}