test.test_metrics.TestMetrics.setUp() - Code Metrics - Inspection of "Bumped version to 1.6" - vladvasiliu/kibana-prometheus-exporter-py - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f9598b...4c4a55 )

by Vlad

created 2019-04-02 11:14 UTC

test.test_metrics.TestMetrics.setUp() B

↳ Parent: test.test_metrics

Complexity

Conditions

Size

Total Lines	62
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	49
dl	0
loc	62
rs	8.669
c	0
b	0
f	0
cc	1
nop	1

How to fix Long Method

from unittest import TestCase
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from kibana_collector import Metrics



class TestMetrics(TestCase):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def setUp(self) -> None:
        self.metrics_dict = {
            'last_updated': '2019-04-02T03:56:41.078Z',
            'collection_interval_in_millis': 15000,
            'process': {
                'memory': {
                    'heap': {
                        'total_in_bytes': 175874048,
                        'used_in_bytes': 157139288,
                        'size_limit': 1526909922
                    },
                    'resident_set_size_in_bytes': 285655040
                },
                'event_loop_delay': 0.08109402656555176,
                'pid': 18595,
                'uptime_in_millis': 2494490
            },
            'os': {
                'load': {
                    '1m': 0.16357421875,
                    '5m': 0.13720703125,
                    '15m': 0.13037109375
                },
                'memory': {
                    'total_in_bytes': 8257908736,
                    'free_in_bytes': 193777664,
                    'used_in_bytes': 8064131072
                },
                'uptime_in_millis': 1212738000,
                'platform': 'linux',
                'platformRelease': 'linux-4.15.0-1034-aws',
                'distro': 'Ubuntu Linux',
                'distroRelease': 'Ubuntu Linux-18.04',
                'cgroup': {
                    'cpuacct': {
                        'control_group': '/system.slice/kibana.service',
                        'usage_nanos': 24967412414
                    },
                    'cpu': {
                        'control_group': '/system.slice/kibana.service',
                        'cfs_period_micros': 100000,
                        'cfs_quota_micros': -1,
                        'stat': {
                            'number_of_elapsed_periods': 0,
                            'number_of_times_throttled': 0,
                            'time_throttled_nanos': 0
                        }
                    }
                }
            },
            'response_times': {
                'avg_in_millis': 2.3333333333333335, 'max_in_millis': 3
            },
            'requests': {
                'disconnects': 0,
                'statusCodes': {},
                'total': 3,
                'status_codes': {
                    '302': 3
                }
            },
            'concurrent_connections': 0
        }

    def test_all_metrics_have_timestamps(self):
        metrics = Metrics(self.metrics_dict)
        for metric in metrics:
            for sample in metric.samples:
                self.assertIsNotNone(sample.timestamp, sample)


1			from unittest import TestCase
			0 ignored issues – show Coding Style introduced 2019-04-02 11:16 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3			from kibana_collector import Metrics
			0 ignored issues – show introduced 2019-04-02 11:16 UTC by Report Bug Copy Issue Report Unable to import 'kibana_collector' Loading history...
4
5
6			class TestMetrics(TestCase):
			0 ignored issues – show Coding Style introduced 2019-04-02 11:16 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
7			def setUp(self) -> None:
8			self.metrics_dict = {
9			'last_updated': '2019-04-02T03:56:41.078Z',
10			'collection_interval_in_millis': 15000,
11			'process': {
12			'memory': {
13			'heap': {
14			'total_in_bytes': 175874048,
15			'used_in_bytes': 157139288,
16			'size_limit': 1526909922
17			},
18			'resident_set_size_in_bytes': 285655040
19			},
20			'event_loop_delay': 0.08109402656555176,
21			'pid': 18595,
22			'uptime_in_millis': 2494490
23			},
24			'os': {
25			'load': {
26			'1m': 0.16357421875,
27			'5m': 0.13720703125,
28			'15m': 0.13037109375
29			},
30			'memory': {
31			'total_in_bytes': 8257908736,
32			'free_in_bytes': 193777664,
33			'used_in_bytes': 8064131072
34			},
35			'uptime_in_millis': 1212738000,
36			'platform': 'linux',
37			'platformRelease': 'linux-4.15.0-1034-aws',
38			'distro': 'Ubuntu Linux',
39			'distroRelease': 'Ubuntu Linux-18.04',
40			'cgroup': {
41			'cpuacct': {
42			'control_group': '/system.slice/kibana.service',
43			'usage_nanos': 24967412414
44			},
45			'cpu': {
46			'control_group': '/system.slice/kibana.service',
47			'cfs_period_micros': 100000,
48			'cfs_quota_micros': -1,
49			'stat': {
50			'number_of_elapsed_periods': 0,
51			'number_of_times_throttled': 0,
52			'time_throttled_nanos': 0
53			}
54			}
55			}
56			},
57			'response_times': {
58			'avg_in_millis': 2.3333333333333335, 'max_in_millis': 3
59			},
60			'requests': {
61			'disconnects': 0,
62			'statusCodes': {},
63			'total': 3,
64			'status_codes': {
65			'302': 3
66			}
67			},
68			'concurrent_connections': 0
69			}
70
71			def test_all_metrics_have_timestamps(self):
72			metrics = Metrics(self.metrics_dict)
73			for metric in metrics:
74			for sample in metric.samples:
75			self.assertIsNotNone(sample.timestamp, sample)
76

vladvasiliu / kibana-prometheus-exporter-py

Push — master ( f9598b...4c4a55 )

test.test_metrics.TestMetrics.setUp() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like