Issues in MessageTrait.php (master) - Issues in master - vistart/yii2-models - Measure and Improve Code Quality continuously with Scrutinizer

Issues (187)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

traits/MessageTrait.php (8 issues)

Labels

Bug 8

Severity

Minor 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 *  _   __ __ _____ _____ ___  ____  _____
 * | | / // // ___//_  _//   ||  __||_   _|
 * | |/ // /(__  )  / / / /| || |     | |
 * |___//_//____/  /_/ /_/ |_||_|     |_|
 * @link https://vistart.name/
 * @copyright Copyright (c) 2016 vistart
 * @license https://vistart.name/license/
 */

namespace vistart\Models\traits;

use yii\base\ModelEvent;
use yii\db\AfterSaveEvent;

/**
 * This trait should be used in models extended from models used BlameableTrait.
 * Notice: The models used BlameableTrait are also models used EntityTrait.
 *
 * @property $recipient
 * @version 2.0
 * @author vistart <[email protected]>
 */
trait MessageTrait
{
    use MutualTrait;

    public $attachmentAttribute = 'attachment';
    public $receivedAtAttribute = 'received_at';
    public $readAtAttribute = 'read_at';
    public static $eventMessageReceived = 'messageReceived';
    public static $eventMessageRead = 'messageRead';
    public $permitChangeContent = false;
    public $permitChangeReceivedAt = false;
    public $permitChangeReadAt = false;

    public function hasBeenReceived()
    {
        return is_string($this->receivedAtAttribute) ? !$this->isInitDatetime($this->getReceivedAt()) : false;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function hasBeenRead()
    {
        return is_string($this->readAtAttribute) ? !$this->isInitDatetime($this->getReadAt()) : false;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function touchReceived()
    {
        return $this->setReceivedAt(static::currentDatetime());
    }

    public function touchRead()
    {
        return $this->setReadAt(static::currentDatetime());
    }

    public function getReceivedAt()
    {
        if (is_string($this->receivedAtAttribute)) {
            $raAttribute = $this->receivedAtAttribute;
            return $this->$raAttribute;
        }
        return null;
    }

    public function setReceivedAt($receivedAt)
    {
        if (is_string($this->receivedAtAttribute)) {
            $raAttribute = $this->receivedAtAttribute;
            return $this->$raAttribute = $receivedAt;
        }
        return null;
    }

    public function getReadAt()
    {
        if (is_string($this->readAtAttribute)) {
            $raAttribute = $this->readAtAttribute;
            return $this->$raAttribute;
        }
        return null;
    }

    public function setReadAt($readAt)
    {
        if (is_string($this->readAtAttribute)) {
            $raAttribute = $this->readAtAttribute;
            return $this->$raAttribute = $readAt;
        }
        return null;
    }

    /**
     * @param ModelEvent $event
     */
    public function onInitReceivedAtAttribute($event)
    {
        $sender = $event->sender;
        /* @var $sender static */
        $sender->setReceivedAt(static::getInitDatetime($event));
    }

    /**
     * @param ModelEvent $event
     */
    public function onInitReadAtAttribute($event)
    {
        $sender = $event->sender;
        /* @var $sender static */
        $sender->setReadAt(static::getInitDatetime($event));
    }

    /**
     * We consider you have received the message if you read it.
     * @param ModelEvent $event
     */
    public function onReadAtChanged($event)
    {
        $sender = $event->sender;
        $raAttribute = $sender->readAtAttribute;
        if (!is_string($raAttribute)) {
            return;
        }
        $reaAttribute = $sender->receivedAtAttribute;
        if (is_string($reaAttribute) && !$sender->isInitDatetime($sender->$raAttribute) && $sender->isInitDatetime($sender->$reaAttribute)) {
            $sender->$reaAttribute = $sender->currentDatetime();
        }
        if ($sender->permitChangeReadAt) {
            return;
        }
        $oldRa = $sender->getOldAttribute($raAttribute);
        if ($oldRa != null && !$sender->isInitDatetime($oldRa) && $sender->$raAttribute != $oldRa) {
            $sender->$raAttribute = $oldRa;
            return;
        }
    }

    /**
     * You are not allowed to change receive time if you have received it.
     * @param ModelEvent $event
     */
    public function onReceivedAtChanged($event)
    {
        $sender = $event->sender;
        $raAttribute = $sender->receivedAtAttribute;
        if (!is_string($raAttribute)) {
            return;
        }
        if ($sender->permitChangeReceivedAt) {
            return;
        }
        $oldRa = $sender->getOldAttribute($raAttribute);
        if ($oldRa != null && !$sender->isInitDatetime($oldRa) && $sender->$raAttribute != $oldRa) {
            $sender->$raAttribute = $oldRa;
            return;
        }
    }

    /**
     * You are not allowed to change the content if it is not new message.
     * @param ModelEvent $event
     */
    public function onContentChanged($event)
    {
        $sender = $event->sender;
        if ($sender->permitChangeContent) {
            return;
        }
        $cAttribute = $sender->contentAttribute;
        $oldContent = $sender->getOldAttribute($cAttribute);
        if ($oldContent != $sender->$cAttribute) {
            $sender->$cAttribute = $oldContent;
        }
    }

    /**
     * Trigger message received or read events.
     * @param AfterSaveEvent $event
     */
    public function onMessageUpdated($event)
    {
        $sender = $event->sender;
        $reaAttribute = $sender->receivedAtAttribute;
        if (isset($event->changedAttributes[$reaAttribute]) && $event->changedAttributes[$reaAttribute] != $sender->$reaAttribute) {
            $sender->trigger(static::$eventMessageReceived);
        }
        $raAttribute = $sender->readAtAttribute;
        if (isset($event->changedAttributes[$raAttribute]) && $event->changedAttributes[$raAttribute] != $sender->$raAttribute) {
            $sender->trigger(static::$eventMessageRead);
        }
    }

    public function initMessageEvents()
    {
        $this->on(static::EVENT_BEFORE_INSERT, [$this, 'onInitReceivedAtAttribute']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->on(static::EVENT_BEFORE_INSERT, [$this, 'onInitReadAtAttribute']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->on(static::EVENT_BEFORE_UPDATE, [$this, 'onReceivedAtChanged']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->on(static::EVENT_BEFORE_UPDATE, [$this, 'onReadAtChanged']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->on(static::EVENT_BEFORE_UPDATE, [$this, 'onContentChanged']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->on(static::EVENT_AFTER_UPDATE, [$this, 'onMessageUpdated']);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getMessageRules()
    {
        $rules = [];
        $rules = array_merge($rules, $this->getMutualRules());
        if (is_string($this->attachmentAttribute)) {
            $rules[] = [$this->attachmentAttribute, 'safe'];
        }
        if (is_string($this->receivedAtAttribute)) {
            $rules[] = [$this->receivedAtAttribute, 'safe'];
        }
        if (is_string($this->readAtAttribute)) {
            $rules[] = [$this->readAtAttribute, 'safe'];
        }
        return $rules;
    }

    public function rules()
    {
        return array_merge(parent::rules(), $this->getMessageRules());
    }

    public function enabledFields()
    {
        $fields = parent::enabledFields();
        if (is_string($this->otherGuidAttribute)) {
            $fields[] = $this->otherGuidAttribute;
        }
        if (is_string($this->attachmentAttribute)) {
            $fields[] = $this->attachmentAttribute;
        }
        if (is_string($this->receivedAtAttribute)) {
            $fields[] = $this->receivedAtAttribute;
        }
        if (is_string($this->readAtAttribute)) {
            $fields[] = $this->readAtAttribute;
        }
        return $fields;
    }
}


1		<?php
2
3		/**
4		* _ __ __ _____ _____ ___ ____ _____
5		* \| \| / // // ___//_ _// \|\| __\|\|_ _\|
6		* \| \|/ // /(__ ) / / / /\| \|\| \| \| \|
7		* \|___//_//____/ /_/ /_/ \|_\|\|_\| \|_\|
8		* @link https://vistart.name/
9		* @copyright Copyright (c) 2016 vistart
10		* @license https://vistart.name/license/
11		*/
12
13		namespace vistart\Models\traits;
14
15		use yii\base\ModelEvent;
16		use yii\db\AfterSaveEvent;
17
18		/**
19		* This trait should be used in models extended from models used BlameableTrait.
20		* Notice: The models used BlameableTrait are also models used EntityTrait.
21		*
22		* @property $recipient
23		* @version 2.0
24		* @author vistart <[email protected]>
25		*/
26		trait MessageTrait
27		{
28		use MutualTrait;
29
30		public $attachmentAttribute = 'attachment';
31		public $receivedAtAttribute = 'received_at';
32		public $readAtAttribute = 'read_at';
33		public static $eventMessageReceived = 'messageReceived';
34		public static $eventMessageRead = 'messageRead';
35		public $permitChangeContent = false;
36		public $permitChangeReceivedAt = false;
37		public $permitChangeReadAt = false;
38
39	4	public function hasBeenReceived()
40		{
41	4	return is_string($this->receivedAtAttribute) ? !$this->isInitDatetime($this->getReceivedAt()) : false;
		0 ignored issues – show Bug introduced 2016-02-10 13:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `isInitDatetime()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42		}
43
44	4	public function hasBeenRead()
45		{
46	4	return is_string($this->readAtAttribute) ? !$this->isInitDatetime($this->getReadAt()) : false;
		0 ignored issues – show Bug introduced 2016-02-12 02:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `isInitDatetime()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
47		}
48
49	2	public function touchReceived()
50		{
51	2	return $this->setReceivedAt(static::currentDatetime());
52		}
53
54	2	public function touchRead()
55		{
56	2	return $this->setReadAt(static::currentDatetime());
57		}
58
59	4	public function getReceivedAt()
60		{
61	4	if (is_string($this->receivedAtAttribute)) {
62	4	$raAttribute = $this->receivedAtAttribute;
63	4	return $this->$raAttribute;
64		}
65		return null;
66		}
67
68	8	public function setReceivedAt($receivedAt)
69		{
70	8	if (is_string($this->receivedAtAttribute)) {
71	8	$raAttribute = $this->receivedAtAttribute;
72	8	return $this->$raAttribute = $receivedAt;
73		}
74		return null;
75		}
76
77	4	public function getReadAt()
78		{
79	4	if (is_string($this->readAtAttribute)) {
80	4	$raAttribute = $this->readAtAttribute;
81	4	return $this->$raAttribute;
82		}
83		return null;
84		}
85
86	8	public function setReadAt($readAt)
87		{
88	8	if (is_string($this->readAtAttribute)) {
89	8	$raAttribute = $this->readAtAttribute;
90	8	return $this->$raAttribute = $readAt;
91		}
92		return null;
93		}
94
95		/**
96		* @param ModelEvent $event
97		*/
98	8	public function onInitReceivedAtAttribute($event)
99		{
100	8	$sender = $event->sender;
101		/* @var $sender static */
102	8	$sender->setReceivedAt(static::getInitDatetime($event));
103	8	}
104
105		/**
106		* @param ModelEvent $event
107		*/
108	8	public function onInitReadAtAttribute($event)
109		{
110	8	$sender = $event->sender;
111		/* @var $sender static */
112	8	$sender->setReadAt(static::getInitDatetime($event));
113	8	}
114
115		/**
116		* We consider you have received the message if you read it.
117		* @param ModelEvent $event
118		*/
119	4	public function onReadAtChanged($event)
120		{
121	4	$sender = $event->sender;
122	4	$raAttribute = $sender->readAtAttribute;
123	4	if (!is_string($raAttribute)) {
124		return;
125		}
126	4	$reaAttribute = $sender->receivedAtAttribute;
127	4	if (is_string($reaAttribute) && !$sender->isInitDatetime($sender->$raAttribute) && $sender->isInitDatetime($sender->$reaAttribute)) {
128	2	$sender->$reaAttribute = $sender->currentDatetime();
129	2	}
130	4	if ($sender->permitChangeReadAt) {
131		return;
132		}
133	4	$oldRa = $sender->getOldAttribute($raAttribute);
134	4	if ($oldRa != null && !$sender->isInitDatetime($oldRa) && $sender->$raAttribute != $oldRa) {
135		$sender->$raAttribute = $oldRa;
136		return;
137		}
138	4	}
139
140		/**
141		* You are not allowed to change receive time if you have received it.
142		* @param ModelEvent $event
143		*/
144	4	public function onReceivedAtChanged($event)
145		{
146	4	$sender = $event->sender;
147	4	$raAttribute = $sender->receivedAtAttribute;
148	4	if (!is_string($raAttribute)) {
149		return;
150		}
151	4	if ($sender->permitChangeReceivedAt) {
152		return;
153		}
154	4	$oldRa = $sender->getOldAttribute($raAttribute);
155	4	if ($oldRa != null && !$sender->isInitDatetime($oldRa) && $sender->$raAttribute != $oldRa) {
156		$sender->$raAttribute = $oldRa;
157		return;
158		}
159	4	}
160
161		/**
162		* You are not allowed to change the content if it is not new message.
163		* @param ModelEvent $event
164		*/
165	4	public function onContentChanged($event)
166		{
167	4	$sender = $event->sender;
168	4	if ($sender->permitChangeContent) {
169		return;
170		}
171	4	$cAttribute = $sender->contentAttribute;
172	4	$oldContent = $sender->getOldAttribute($cAttribute);
173	4	if ($oldContent != $sender->$cAttribute) {
174	2	$sender->$cAttribute = $oldContent;
175	2	}
176	4	}
177
178		/**
179		* Trigger message received or read events.
180		* @param AfterSaveEvent $event
181		*/
182	4	public function onMessageUpdated($event)
183		{
184	4	$sender = $event->sender;
185	4	$reaAttribute = $sender->receivedAtAttribute;
186	4	if (isset($event->changedAttributes[$reaAttribute]) && $event->changedAttributes[$reaAttribute] != $sender->$reaAttribute) {
187	4	$sender->trigger(static::$eventMessageReceived);
188	4	}
189	4	$raAttribute = $sender->readAtAttribute;
190	4	if (isset($event->changedAttributes[$raAttribute]) && $event->changedAttributes[$raAttribute] != $sender->$raAttribute) {
191	2	$sender->trigger(static::$eventMessageRead);
192	2	}
193	4	}
194
195	8	public function initMessageEvents()
196		{
197	8	$this->on(static::EVENT_BEFORE_INSERT, [$this, 'onInitReceivedAtAttribute']);
		0 ignored issues – show Bug introduced 2016-02-11 02:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `on()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
198	8	$this->on(static::EVENT_BEFORE_INSERT, [$this, 'onInitReadAtAttribute']);
		0 ignored issues – show Bug introduced 2016-02-11 02:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `on()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
199	8	$this->on(static::EVENT_BEFORE_UPDATE, [$this, 'onReceivedAtChanged']);
		0 ignored issues – show Bug introduced 2016-02-12 02:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `on()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
200	8	$this->on(static::EVENT_BEFORE_UPDATE, [$this, 'onReadAtChanged']);
		0 ignored issues – show Bug introduced 2016-02-12 02:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `on()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
201	8	$this->on(static::EVENT_BEFORE_UPDATE, [$this, 'onContentChanged']);
		0 ignored issues – show Bug introduced 2016-02-12 02:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `on()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
202	8	$this->on(static::EVENT_AFTER_UPDATE, [$this, 'onMessageUpdated']);
		0 ignored issues – show Bug introduced 2016-02-15 04:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `on()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
203	8	}
204
205	8	public function getMessageRules()
206		{
207	8	$rules = [];
208	8	$rules = array_merge($rules, $this->getMutualRules());
209	8	if (is_string($this->attachmentAttribute)) {
210	8	$rules[] = [$this->attachmentAttribute, 'safe'];
211	8	}
212	8	if (is_string($this->receivedAtAttribute)) {
213	8	$rules[] = [$this->receivedAtAttribute, 'safe'];
214	8	}
215	8	if (is_string($this->readAtAttribute)) {
216	8	$rules[] = [$this->readAtAttribute, 'safe'];
217	8	}
218	8	return $rules;
219		}
220
221	8	public function rules()
222		{
223	8	return array_merge(parent::rules(), $this->getMessageRules());
224		}
225
226	8	public function enabledFields()
227		{
228	8	$fields = parent::enabledFields();
229	8	if (is_string($this->otherGuidAttribute)) {
230	8	$fields[] = $this->otherGuidAttribute;
231	8	}
232	8	if (is_string($this->attachmentAttribute)) {
233	8	$fields[] = $this->attachmentAttribute;
234	8	}
235	8	if (is_string($this->receivedAtAttribute)) {
236	8	$fields[] = $this->receivedAtAttribute;
237	8	}
238	8	if (is_string($this->readAtAttribute)) {
239	8	$fields[] = $this->readAtAttribute;
240	8	}
241	8	return $fields;
242		}
243		}
244

vistart / yii2-models

Issues (187)

Security Analysis no request data

traits/MessageTrait.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like