MessageQueryTrait - Code Metrics - Inspection of "2.0.0.20160210-nightly" - vistart/yii2-models - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a53812...c29406 )

by vistart

created 2016-02-10 13:34 UTC

MessageQueryTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	8
c	1
b	0
f	0
lcom	1
cbo	0
dl	0
loc	43
ccs	0
cts	24
cp	0
rs	10

4 Methods

Rating	Name	Size	Complexity
A	unread()	9	2
A	read()	9	2
A	unreceived()	9	2
A	received()	9	2

<?php

/**
 *  _   __ __ _____ _____ ___  ____  _____
 * | | / // // ___//_  _//   ||  __||_   _|
 * | |/ // /(__  )  / / / /| || |     | |
 * |___//_//____/  /_/ /_/ |_||_|     |_|
 * @link https://vistart.name/
 * @copyright Copyright (c) 2016 vistart
 * @license https://vistart.name/license/
 */

namespace vistart\Models\traits;

/**
 * Description of MessageQueryTrait
 *
 * @author vistart <[email protected]>
 */
trait MessageQueryTrait
{

    public function unread()
    {
        $model = $this->noInitModel;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $raAttribute = $model->readAtAttribute;
        if (!is_string($raAttribute)) {
            return $this;
        }
        return $this->andWhere([$this->$raAttribute => $model->initDatetime()]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function read()
    {
        $model = $this->noInitModel;
        $raAttribute = $model->readAtAttribute;
        if (!is_string($raAttribute)) {
            return $this;
        }
        return $this->andWhere(['!=', $this->$raAttribute, $model->initDatetime()]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function unreceived()
    {
        $model = $this->noInitModel;
        $raAttribute = $model->receivedAtAttribute;
        if (!is_string($raAttribute)) {
            return $this;
        }
        return $this->andWhere([$this->$raAttribute => $model->initDatetime()]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function received()
    {
        $model = $this->noInitModel;
        $raAttribute = $model->receivedAttribute;
        if (!is_string($raAttribute)) {
            return $this;
        }
        return $this->andWhere(['!=', $this->$raAttribute, $model->initDatetime()]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			/**
4			* _ __ __ _____ _____ ___ ____ _____
5			* \| \| / // // ___//_ _// \|\| __\|\|_ _\|
6			* \| \|/ // /(__ ) / / / /\| \|\| \| \| \|
7			* \|___//_//____/ /_/ /_/ \|_\|\|_\| \|_\|
8			* @link https://vistart.name/
9			* @copyright Copyright (c) 2016 vistart
10			* @license https://vistart.name/license/
11			*/
12
13			namespace vistart\Models\traits;
14
15			/**
16			* Description of MessageQueryTrait
17			*
18			* @author vistart <[email protected]>
19			*/
20			trait MessageQueryTrait
21			{
22
23			public function unread()
24			{
25			$model = $this->noInitModel;
			0 ignored issues – show Bug introduced 2016-02-10 13:41 UTC by Report Bug Copy Issue Report The property `noInitModel` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			$raAttribute = $model->readAtAttribute;
27			if (!is_string($raAttribute)) {
28			return $this;
29			}
30			return $this->andWhere([$this->$raAttribute => $model->initDatetime()]);
			0 ignored issues – show Bug introduced 2016-02-10 13:41 UTC by Report Bug Copy Issue Report It seems like `andWhere()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			}
32
33			public function read()
34			{
35			$model = $this->noInitModel;
36			$raAttribute = $model->readAtAttribute;
37			if (!is_string($raAttribute)) {
38			return $this;
39			}
40			return $this->andWhere(['!=', $this->$raAttribute, $model->initDatetime()]);
			0 ignored issues – show Bug introduced 2016-02-10 13:41 UTC by Report Bug Copy Issue Report It seems like `andWhere()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41			}
42
43			public function unreceived()
44			{
45			$model = $this->noInitModel;
46			$raAttribute = $model->receivedAtAttribute;
47			if (!is_string($raAttribute)) {
48			return $this;
49			}
50			return $this->andWhere([$this->$raAttribute => $model->initDatetime()]);
			0 ignored issues – show Bug introduced 2016-02-10 13:41 UTC by Report Bug Copy Issue Report It seems like `andWhere()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
51			}
52
53			public function received()
54			{
55			$model = $this->noInitModel;
56			$raAttribute = $model->receivedAttribute;
57			if (!is_string($raAttribute)) {
58			return $this;
59			}
60			return $this->andWhere(['!=', $this->$raAttribute, $model->initDatetime()]);
			0 ignored issues – show Bug introduced 2016-02-10 13:41 UTC by Report Bug Copy Issue Report It seems like `andWhere()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
61			}
62			}
63

vistart / yii2-models

Push — master ( a53812...c29406 )

MessageQueryTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like