Issues in Point.php - Fixed Issues - Inspection of "Fixed property not setted" - vinyvicente/doctrine-point-type - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( d82979...8d3b0f )

by Vinicius

created 2016-11-11 18:14 UTC

src/Point.php (2 issues)

Labels

Bug 2

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Viny;

/**
 * Class Point
 * @package Uello\ValueObject
 */
class Point
{
    /**
     * @param float $latitude
     * @param float $longitude
     */
    public function __construct(float $latitude, float $longitude)
    {
        $this->latitude  = $latitude;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->longitude = $longitude;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @return float
     */
    public function getLatitude(): float
    {
        return $this->latitude;
    }

    /**
     * @return float
     */
    public function getLongitude(): float
    {
        return $this->longitude;
    }

    /**
     * @return string
     */
    public function __toString(): string
    {
        return sprintf('POINT(%f %f)', $this->latitude, $this->longitude);
    }
}


GitHub Access Token became invalid

Push — master ( d82979...8d3b0f )

src/Point.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1			<?php
2
3			namespace Viny;
4
5			/**
6			* Class Point
7			* @package Uello\ValueObject
8			*/
9			class Point
10			{
11			/**
12			* @param float $latitude
13			* @param float $longitude
14			*/
15			public function __construct(float $latitude, float $longitude)
16			{
17			$this->latitude = $latitude;
			0 ignored issues – show Bug introduced 2016-11-11 18:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `latitude` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18			$this->longitude = $longitude;
			0 ignored issues – show Bug introduced 2016-11-11 18:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `longitude` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			}
20
21			/**
22			* @return float
23			*/
24			public function getLatitude(): float
25			{
26			return $this->latitude;
27			}
28
29			/**
30			* @return float
31			*/
32			public function getLongitude(): float
33			{
34			return $this->longitude;
35			}
36
37			/**
38			* @return string
39			*/
40			public function __toString(): string
41			{
42			return sprintf('POINT(%f %f)', $this->latitude, $this->longitude);
43			}
44			}
45

vinyvicente / doctrine-point-type

GitHub Access Token became invalid

Push — master ( d82979...8d3b0f )

src/Point.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like