Bill::approve() - Code Metrics - Inspection of "adiciona novos metodos e endpoints da api" - vindi/vindi-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

unknown

created 2017-09-04 20:11 UTC

Bill::approve() A

↳ Parent: Bill

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Vindi;

class Bill extends Resource
{
    /**
     * The endpoint that will hit the API.
     *
     * @return string
     */
    public function endpoint()
    {
        return 'bills';
    }

    /**
     * Make a POST request to bills/{id}/approve.
     *
     * @param int $id The resource's id.
     *
     * @return mixed
     */
    public function approve($id)
    {
        return $this->post($id, 'approve');
    }

    /**
     * Make a POST request to bills/{id}/charge.
     *
     * @param int $id The resource's id.
     * @param array $form_params.
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return mixed
     */
    public function charge($id, array $form_params = [])
    {
        return $this->post($id, 'charge', $form_params);
    }

    /**
     * Make a POST request to bills/{id}/invoice.
     *
     * @param int $id The resource's id.
     *
     * @return mixed
     */
    public function invoice($id)
    {
        return $this->post($id, 'invoice');
    }
}


1		<?php
2
3		namespace Vindi;
4
5		class Bill extends Resource
6		{
7		/**
8		* The endpoint that will hit the API.
9		*
10		* @return string
11		*/
12	18	public function endpoint()
13		{
14	18	return 'bills';
15		}
16
17		/**
18		* Make a POST request to bills/{id}/approve.
19		*
20		* @param int $id The resource's id.
21		*
22		* @return mixed
23		*/
24	2	public function approve($id)
25		{
26	2	return $this->post($id, 'approve');
27		}
28
29		/**
30		* Make a POST request to bills/{id}/charge.
31		*
32		* @param int $id The resource's id.
33		* @param array $form_params.
		0 ignored issues – show Documentation introduced 2017-09-04 20:14 UTC by Report Bug Copy Issue Report There is no parameter named `$form_params.`. Did you maybe mean `$form_params`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
34		*
35		* @return mixed
36		*/
37		public function charge($id, array $form_params = [])
38		{
39		return $this->post($id, 'charge', $form_params);
40		}
41
42		/**
43		* Make a POST request to bills/{id}/invoice.
44		*
45		* @param int $id The resource's id.
46		*
47		* @return mixed
48		*/
49		public function invoice($id)
50		{
51		return $this->post($id, 'invoice');
52		}
53		}
54

vindi / vindi-php

GitHub Access Token became invalid

Pull Request — master (#20)

Bill::approve() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like