Client::__construct() - Code Metrics - Inspection of "Test/error debug" - vindi/vindi-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#26)

unknown

created 2017-11-30 13:02 UTC

Client::__construct() A

↳ Parent: Client

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	2.0011

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	14
cts	15
cp	0.9333
rs	9.0856
c	0
b	0
f	0
cc	2
eloc	15
nc	2
nop	1
crap	2.0011

<?php namespace Vindi\Http;

use GuzzleHttp\Client as Guzzle;
use Vindi\Vindi;

class Client extends Guzzle
{
    /**
     * Client constructor.
     */
    public function __construct(array $config = [])
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $vindi = new Vindi;

        $host = isset($_SERVER['HTTP_HOST']) ? $_SERVER['HTTP_HOST'] : '';

        $config = array_merge([
            'base_uri'        => Vindi::getApiBase(),
            'auth'            => [$vindi->getApiKey(), '', 'BASIC'],
            'headers' => [
                'Content-Type' => 'application/json',
                'User-Agent'   => trim('Vindi-PHP/' . Vindi::$sdkVersion . "; {$host}"),
            ],
            'verify'  => $vindi->getCertPath(),
            'timeout' => 60,
            'curl.options' => [
                'CURLOPT_SSLVERSION' => 'CURL_SSLVERSION_TLSv1_2',
            ]
        ], $config);


        parent::__construct($config);
    }
}


1		<?php namespace Vindi\Http;
2
3		use GuzzleHttp\Client as Guzzle;
4		use Vindi\Vindi;
5
6		class Client extends Guzzle
7		{
8		/**
9		* Client constructor.
10		*/
11	428	public function __construct(array $config = [])
		0 ignored issues – show Coding Style introduced 2017-09-04 20:14 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
12		{
13	428	$vindi = new Vindi;
14
15	428	$host = isset($_SERVER['HTTP_HOST']) ? $_SERVER['HTTP_HOST'] : '';
16
17	428	$config = array_merge([
18	428	'base_uri' => Vindi::getApiBase(),
19	428	'auth' => [$vindi->getApiKey(), '', 'BASIC'],
20		'headers' => [
21	428	'Content-Type' => 'application/json',
22	428	'User-Agent' => trim('Vindi-PHP/' . Vindi::$sdkVersion . "; {$host}"),
23	428	],
24	428	'verify' => $vindi->getCertPath(),
25	428	'timeout' => 60,
26		'curl.options' => [
27	428	'CURLOPT_SSLVERSION' => 'CURL_SSLVERSION_TLSv1_2',
28		]
29	428	], $config);
30
31
32	428	parent::__construct($config);
33		}
34		}
35

vindi / vindi-php

GitHub Access Token became invalid

Pull Request — master (#26)

Client::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like