vimeo / psalm

src/Psalm/Internal/Analyzer/Statements/Block/IfAnalyzer.php

Doc Comments +9 added lines, -9 removed lines

@@ -122,7 +122,7 @@ 
         $if_clauses = array_values(
             array_map(
                 /**
-                 * @return Clause
+                 * @return false|null
                  */
                 function (Clause $c) use ($mixed_var_ids) {
                     $keys = array_keys($c->possibilities);
@@ -217,8 +217,8 @@ 
             $omit_keys = array_reduce(
                 $context->clauses,
                 /**
-                 * @param array<string> $carry
-                 * @return array<string>
+                 * @param StatementsAnalyzer $carry
+                 * @return false|null
                  */
                 function ($carry, Clause $clause) {
                     return array_merge($carry, array_keys($clause->possibilities));
@@ -553,7 +553,7 @@ 
                     $entry_clauses = array_values(
                         array_filter(
                             $entry_clauses,
-                            /** @return bool */
+                            /** @return \Psalm\Internal\Scope\IfConditionalScope */
                             function (Clause $c) use ($changed_var_ids) {
                                 return count($c->possibilities) > 1
                                     || $c->wedge
@@ -683,9 +683,9 @@ 
 
         $newish_var_ids = array_map(
             /**
-             * @param Type\Union $_
+             * @param StatementsAnalyzer $_
              *
-             * @return true
+             * @return \Psalm\Internal\Scope\IfConditionalScope
              */
             function (Type\Union $_) {
                 return true;
@@ -1044,7 +1044,7 @@ 
      * @param  StatementsAnalyzer           $statements_analyzer
      * @param  PhpParser\Node\Stmt\ElseIf_ $elseif
      * @param  IfScope                     $if_scope
-     * @param  Context                     $elseif_context
+     * @param  Context                     $else_context
      * @param  Context                     $outer_context
      *
      * @return false|null
@@ -1096,7 +1096,7 @@ 
 
         $elseif_clauses = array_map(
             /**
-             * @return Clause
+             * @return false|null
              */
             function (Clause $c) use ($mixed_var_ids) {
                 $keys = array_keys($c->possibilities);
@@ -1118,7 +1118,7 @@ 
 
         $entry_clauses = array_map(
             /**
-             * @return Clause
+             * @return false|null
              */
             function (Clause $c) use ($cond_assigned_var_ids) {
                 $keys = array_keys($c->possibilities);

src/Psalm/Internal/Analyzer/Statements/Block/LoopAnalyzer.php

Doc Comments -1 removed lines

@@ -32,7 +32,6 @@
      * @param  PhpParser\Node\Expr[]        $pre_conditions
      * @param  PhpParser\Node\Expr[]        $post_expressions
      * @param  Context                      loop_scope->loop_context
-     * @param  Context                      $loop_scope->loop_parent_context
      * @param  bool                         $is_do
      *
      * @return false|null

src/Psalm/Internal/Analyzer/Statements/Block/SwitchCaseAnalyzer.php

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
 class SwitchCaseAnalyzer
 {
     /**
-     * @param ?string $switch_var_id
+     * @param string|null $switch_var_id
      * @return null|false
      */
     public static function analyze(

src/Psalm/Internal/Analyzer/Statements/Expression/AssertionFinder.php

Doc Comments +1 added lines, -1 removed lines

@@ -2107,7 +2107,7 @@
     }
 
     /**
-     * @param  PhpParser\Node\Expr\FuncCall|PhpParser\Node\Expr\MethodCall|PhpParser\Node\Expr\StaticCall $expr
+     * @param  PhpParser\Node\Expr\FuncCall $expr
      * @param  string|null  $this_class_name
      * @param  FileSource   $source
      * @param  bool         $negate

src/Psalm/Internal/Analyzer/Statements/Expression/Assignment/ArrayAssignmentAnalyzer.php

Doc Comments +1 added lines

@@ -69,6 +69,7 @@
 
     /**
      *
+     * @param PhpParser\Node\Expr|null $assign_value
      * @return false|null
      */
     public static function updateArrayType(

src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOp/CoalesceAnalyzer.php

Doc Comments +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
         $if_clauses = array_values(
             array_map(
                 /**
-                 * @return \Psalm\Internal\Clause
+                 * @return boolean
                  */
                 function (\Psalm\Internal\Clause $c) use ($mixed_var_ids) {
                     $keys = array_keys($c->possibilities);

src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOp/NonDivArithmeticOpAnalyzer.php

Doc Comments +4 added lines

@@ -39,6 +39,10 @@
  */
 class NonDivArithmeticOpAnalyzer
 {
+    /**
+     * @param StatementsSource|null $statements_source
+     * @param Context $context
+     */
     public static function analyze(
         ?StatementsSource $statements_source,
         \Psalm\Internal\Provider\NodeDataProvider $nodes,

src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentAnalyzer.php

Doc Comments +3 added lines, -1 removed lines

@@ -47,8 +47,9 @@ 
 {
     /**
      * @param  ?string $self_fq_class_name
-     * @param  ?string $static_fq_class_name
+     * @param  string|null $static_fq_class_name
      * @param  array<string, array<string, array{Type\Union, 1?:int}>> $class_generic_params
+     * @param FunctionLikeParameter|null $function_param
      * @return false|null
      */
     public static function checkArgumentMatches(
@@ -414,6 +415,7 @@ 
 
     /**
      * @param Type\Atomic\ObjectLike|Type\Atomic\TArray|Type\Atomic\TList $unpacked_atomic_array
+     * @param null|Type\Union $signature_param_type
      * @return  null|false
      */
     public static function verifyType(

Unused Use Statements -1 removed lines

@@ -38,7 +38,6 @@
 use function strpos;
 use function explode;
 use function in_array;
-use Psalm\Issue\TaintedInput;
 
 /**
  * @internal

src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php

Doc Comments +1 added lines

@@ -693,6 +693,7 @@
      * @param  FunctionLikeParameter|null $last_param
      * @param  array<int, FunctionLikeParameter> $function_params
      * @param  FunctionLikeStorage|null $function_storage
+     * @param FunctionLikeParameter[] $function_params
      * @return false|null
      */
     private static function handlePossiblyMatchingByRefParam(