vimeo / psalm

src/Psalm/Internal/Analyzer/StatementsAnalyzer.php

Doc Comments +3 added lines, -2 removed lines

@@ -271,6 +271,7 @@ 
 
     /**
      * @psalm-return false|null
+     * @param null|Context $global_context
      */
     private static function analyzeStatement(
         StatementsAnalyzer $statements_analyzer,
@@ -344,9 +345,9 @@ 
                 $suppressed = array_filter(
                     array_map(
                         /**
-                         * @param string $line
+                         * @param StatementsAnalyzer $line
                          *
-                         * @return string
+                         * @return false|null
                          */
                         function ($line) {
                             return preg_split('/[\s]+/', $line)[0];

src/Psalm/Internal/Analyzer/TypeAnalyzer.php

Doc Comments +6 added lines, -4 removed lines

@@ -304,7 +304,7 @@ 
     /**
      * Used for comparing signature typehints, uses PHP's light contravariance rules
      *
-     * @param  ?Type\Union  $input_type
+     * @param  Type\Union|null  $input_type
      * @param  Type\Union   $container_type
      *
      * @return bool
@@ -501,8 +501,8 @@ 
 
     /**
      * @param  Codebase       $codebase
-     * @param  TNamedObject|TTemplateParam|TIterable  $input_type_part
-     * @param  TNamedObject|TTemplateParam|TIterable  $container_type_part
+     * @param  Type\Atomic  $input_type_part
+     * @param  Type\Atomic  $container_type_part
      * @param  bool           $allow_interface_equality
      *
      * @return bool
@@ -765,6 +765,7 @@ 
 
     /**
      * Does the input param atomic type match the given param atomic type
+     * @param TypeComparisonResult $atomic_comparison_result
      */
     public static function isAtomicContainedBy(
         Codebase $codebase,
@@ -1913,6 +1914,7 @@ 
     }
 
     /**
+     * @param TCallable $container_type_part
      * @return ?TCallable
      */
     public static function getCallableFromAtomic(
@@ -2388,7 +2390,7 @@ 
                 $container_params_can_be_undefined = (bool) array_reduce(
                     $container_type_part->properties,
                     /**
-                     * @param bool $carry
+                     * @param Codebase $carry
                      *
                      * @return bool
                      */

src/Psalm/Internal/Codebase/Analyzer.php

Doc Comments +5 added lines, -3 removed lines

@@ -343,8 +343,8 @@ 
 
         $analysis_worker =
             /**
-             * @param int $_
-             * @param string $file_path
+             * @param ProjectAnalyzer $_
+             * @param integer $file_path
              *
              * @return array
              */
@@ -363,7 +363,7 @@ 
 
         $task_done_closure =
             /**
-             * @param array<IssueData> $issues
+             * @param ProjectAnalyzer $issues
              */
             function (array $issues): void {
                 $has_error = false;
@@ -1399,6 +1399,7 @@ 
      * @param string $file_path
      * @param int $start
      * @param int $end
+     * @param string $issue_type
      *
      * @return list<IssueData>
      */
@@ -1425,6 +1426,7 @@ 
      * @param string $file_path
      * @param int $start
      * @param int $end
+     * @param string $issue_type
      *
      * @return void
      */

src/Psalm/Internal/Codebase/ClassLikes.php

Doc Comments +10 added lines, -6 removed lines

@@ -707,7 +707,7 @@ 
     }
 
     /**
-     * @param  lowercase-string  $fq_class_name
+     * @param  string  $fq_class_name
      *
      * @return bool
      */
@@ -780,6 +780,7 @@ 
     }
 
     /**
+     * @param Progress $progress
      * @return void
      */
     public function consolidateAnalyzedData(Methods $methods, ?Progress $progress, bool $find_unused_code)
@@ -1083,7 +1084,7 @@ 
     }
 
     /**
-     * @param lowercase-string|null $calling_method_id
+     * @param null|string $calling_method_id
      */
     public function handleClassLikeReferenceInMigration(
         \Psalm\Codebase $codebase,
@@ -1266,7 +1267,7 @@ 
     }
 
     /**
-     * @param lowercase-string|null $calling_method_id
+     * @param null|string $calling_method_id
      */
     public function handleDocblockTypeInMigration(
         \Psalm\Codebase $codebase,
@@ -1501,6 +1502,9 @@ 
         throw new \InvalidArgumentException('Must specify $visibility');
     }
 
+    /**
+     * @param \Psalm\Internal\Analyzer\StatementsAnalyzer $statements_analyzer
+     */
     public function getConstantForClass(
         string $class_name,
         string $constant_name,
@@ -2295,7 +2299,7 @@ 
     }
 
     /**
-     * @param  lowercase-string $fq_classlike_name_lc
+     * @param  string $fq_classlike_name_lc
      *
      * @return void
      */
@@ -2305,7 +2309,7 @@ 
     }
 
     /**
-     * @param  lowercase-string $fq_classlike_name_lc
+     * @param  string $fq_classlike_name_lc
      *
      * @return bool
      */
@@ -2316,7 +2320,7 @@ 
     }
 
     /**
-     * @param  lowercase-string $fq_classlike_name_lc
+     * @param  string $fq_classlike_name_lc
      *
      * @return bool
      */

src/Psalm/Internal/Codebase/Methods.php

Doc Comments +4 added lines, -4 removed lines

@@ -855,9 +855,9 @@ 
 
     /**
      * @param string $fq_class_name
-     * @param lowercase-string $method_name_lc
+     * @param string $method_name_lc
      * @param string $declaring_fq_class_name
-     * @param lowercase-string $declaring_method_name_lc
+     * @param string $declaring_method_name_lc
      *
      * @return void
      */
@@ -877,9 +877,9 @@ 
 
     /**
      * @param string $fq_class_name
-     * @param lowercase-string $method_name_lc
+     * @param string $method_name_lc
      * @param string $appearing_fq_class_name
-     * @param lowercase-string $appearing_method_name_lc
+     * @param string $appearing_method_name_lc
      *
      * @return void
      */

src/Psalm/Internal/Codebase/Reflection.php

Doc Comments +3 added lines, -3 removed lines

@@ -347,7 +347,7 @@ 
     }
 
     /**
-     * @param  callable-string $function_id
+     * @param  string $function_id
      *
      * @return false|null
      */
@@ -452,8 +452,8 @@ 
     }
 
     /**
-     * @param lowercase-string $fq_class_name
-     * @param lowercase-string $parent_class
+     * @param string $fq_class_name
+     * @param string $parent_class
      *
      * @return void
      */

src/Psalm/Internal/Codebase/Scanner.php

Doc Comments +2 added lines, -3 removed lines

@@ -260,7 +260,6 @@ 
 
     /**
      * @param  string  $fq_classlike_name
-     * @param  string|null  $referencing_file_path
      * @param  bool $analyze_too
      * @param  bool $store_failure
      * @param  array<string, mixed> $phantom_classes
@@ -360,7 +359,7 @@ 
              * @param int $_
              * @param string $file_path
              *
-             * @return void
+             * @return boolean
              */
             function ($_, $file_path) use ($filetype_scanners, $files_to_deep_scan) {
                 $this->scanFile(
@@ -409,7 +408,7 @@ 
                 },
                 $scanner_worker,
                 /**
-                 * @return PoolData
+                 * @return boolean
                  */
                 function () {
                     $this->progress->debug('Collecting data from forked scanner process' . PHP_EOL);

src/Psalm/Internal/Diff/ClassStatementsDiffer.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
             /**
              * @param string $a_code
              * @param string $b_code
-             * @param bool $body_change
+             * @param string $body_change
              *
              * @return bool
              */

src/Psalm/Internal/Diff/NamespaceStatementsDiffer.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     {
         list($trace, $x, $y, $bc) = self::calculateTrace(
             /**
-             * @param string $a_code
+             * @param PhpParser\Node\Stmt[] $a_code
              * @param string $b_code
              *
              * @return bool